[MediaWiki-commits] [Gerrit] raid: fix sudo rules for hpssacli (mostly for ms-be) - change (operations/puppet)

2016-05-30 Thread Faidon Liambotis (Code Review) 
Faidon Liambotis has submitted this change and it was merged.

Change subject: raid: fix sudo rules for hpssacli (mostly for ms-be)
..


raid: fix sudo rules for hpssacli (mostly for ms-be)

Some ms-be boxes have controllers in slot 3 and certainly more than 9
logical drives. Our current sudo rules (Debian's) don't cover these, so
expand them to be a little more inclusive.

Change-Id: I7b3356ff7547ed481106c35806664853f71c0ae3
---
M modules/raid/manifests/init.pp
1 file changed, 14 insertions(+), 14 deletions(-)

Approvals:
  Faidon Liambotis: Verified; Looks good to me, approved



diff --git a/modules/raid/manifests/init.pp b/modules/raid/manifests/init.pp
index 2a12820..23538e9 100644
--- a/modules/raid/manifests/init.pp
+++ b/modules/raid/manifests/init.pp
@@ -40,21 +40,21 @@
 user   => 'nagios',
 privileges => [
 'ALL = NOPASSWD: /usr/sbin/hpssacli controller all show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] ld 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] ld 
[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] 
show status',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] ld 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] ld * 
show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] show 
status',
 'ALL = NOPASSWD: /usr/sbin/hpacucli controller all show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] ld 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] ld 
[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] 
show status',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] ld 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] ld * 
show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] show 
status',
 ],
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b3356ff7547ed481106c35806664853f71c0ae3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis 
Gerrit-Reviewer: Faidon Liambotis 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] raid: fix sudo rules for hpssacli (mostly for ms-be) - change (operations/puppet)

2016-05-30 Thread Faidon Liambotis (Code Review) 
Faidon Liambotis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291791

Change subject: raid: fix sudo rules for hpssacli (mostly for ms-be)
..

raid: fix sudo rules for hpssacli (mostly for ms-be)

Some ms-be boxes have controllers in slot 3 and certainly more than 9
logical drives. Our current sudo rules (Debian's) don't cover these, so
expand them to be a little more inclusive.

Change-Id: I7b3356ff7547ed481106c35806664853f71c0ae3
---
M modules/raid/manifests/init.pp
1 file changed, 14 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/91/291791/1

diff --git a/modules/raid/manifests/init.pp b/modules/raid/manifests/init.pp
index 2a12820..23538e9 100644
--- a/modules/raid/manifests/init.pp
+++ b/modules/raid/manifests/init.pp
@@ -40,21 +40,21 @@
 user   => 'nagios',
 privileges => [
 'ALL = NOPASSWD: /usr/sbin/hpssacli controller all show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] ld 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] ld 
[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0129] 
show status',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] ld 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] ld * 
show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpssacli controller slot=[0-9] show 
status',
 'ALL = NOPASSWD: /usr/sbin/hpacucli controller all show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] ld 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] ld 
[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
all show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
-'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0129] 
show status',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] ld 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] ld * 
show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
all show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] pd 
[0-9][EIC]\:[0-9]\:[0-9][0-9] show',
+'ALL = NOPASSWD: /usr/sbin/hpacucli controller slot=[0-9] show 
status',
 ],
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/291791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b3356ff7547ed481106c35806664853f71c0ae3
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits