[MediaWiki-commits] [Gerrit] update.php: Don't check for mbstring extension - change (mediawiki/core)

2016-06-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: update.php: Don't check for mbstring extension
..


update.php: Don't check for mbstring extension

This check is redundant to the one in PHPVersionCheck.php which
was added in 41d1fa1c3a.

Change-Id: I32ab259939ca7e93ad6d08f2c04406ad8a973b5d
---
M maintenance/update.php
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/maintenance/update.php b/maintenance/update.php
index 0103189..b96e7eb 100755
--- a/maintenance/update.php
+++ b/maintenance/update.php
@@ -82,13 +82,6 @@
"ABORTING (see 
https://bugs.php.net/bug.php?id=45996).\n",
true );
}
-
-   if ( !function_exists( 'mb_strlen' ) ) {
-   $this->error(
-   "MediaWiki now requires the mbstring PHP 
extension, your system doesn't have it.\n"
-   . "ABORTING.\n",
-   true );
-   }
}
 
function execute() {

-- 
To view, visit https://gerrit.wikimedia.org/r/294408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I32ab259939ca7e93ad6d08f2c04406ad8a973b5d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Parent5446 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] update.php: Don't check for mbstring extension - change (mediawiki/core)

2016-06-14 Thread PleaseStand (Code Review) 
PleaseStand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/294408

Change subject: update.php: Don't check for mbstring extension
..

update.php: Don't check for mbstring extension

This check is redundant to the one in PHPVersionCheck.php.

Change-Id: I32ab259939ca7e93ad6d08f2c04406ad8a973b5d
---
M maintenance/update.php
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/08/294408/1

diff --git a/maintenance/update.php b/maintenance/update.php
index 0103189..b96e7eb 100755
--- a/maintenance/update.php
+++ b/maintenance/update.php
@@ -82,13 +82,6 @@
"ABORTING (see 
https://bugs.php.net/bug.php?id=45996).\n",
true );
}
-
-   if ( !function_exists( 'mb_strlen' ) ) {
-   $this->error(
-   "MediaWiki now requires the mbstring PHP 
extension, your system doesn't have it.\n"
-   . "ABORTING.\n",
-   true );
-   }
}
 
function execute() {

-- 
To view, visit https://gerrit.wikimedia.org/r/294408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32ab259939ca7e93ad6d08f2c04406ad8a973b5d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: PleaseStand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits