[MediaWiki-commits] [Gerrit] varnish: burn more cpu/mem on better gzip compression - change (operations/puppet)

2016-06-21 Thread BBlack (Code Review) 
BBlack has submitted this change and it was merged.

Change subject: varnish: burn more cpu/mem on better gzip compression
..


varnish: burn more cpu/mem on better gzip compression

This raises gzip_level and gzip_memlevel from 6/8 (default) to 8/9.  We have
CPU cycles to waste, and this can slightly reduce cache object storage sizes
and transferred bytes to clients.  Level 8 is what Cloudflare also uses, as 9
doesn't buy much for the potential big bump in CPU waste.  They also use a
hacked zlib that is faster and open source, we could package that if we see a
significant need in the future (e.g. if more applayer leaves compression to
varnish).

Did some preliminary manual testing and everything looks fine.

Will need to salt a runtime change of these parameters via
varnishadm as well, as the diff here only affects the setting for
future daemon restarts.

Change-Id: I305bbe4ac599b6def50691f20fd2da61d7feff05
---
M modules/varnish/templates/initscripts/varnish.systemd.erb
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  BBlack: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/varnish/templates/initscripts/varnish.systemd.erb 
b/modules/varnish/templates/initscripts/varnish.systemd.erb
index 9cd8ec3..f43524a 100644
--- a/modules/varnish/templates/initscripts/varnish.systemd.erb
+++ b/modules/varnish/templates/initscripts/varnish.systemd.erb
@@ -40,6 +40,8 @@
 -p listen_depth=4096 -p session_max=20 -p vcc_err_unref=off \
 -p nuke_limit=300 \
 -p http_req_size=24576 \
+-p gzip_level=8 \
+-p gzip_memlevel=9 \
 <%= @runtime_params -%> \
 <%= @extraopts -%> \
 <% if @vcl_config.fetch("enable_geoiplookup", false) -%>-p 
cc_command=${CC_COMMAND}<% end %>

-- 
To view, visit https://gerrit.wikimedia.org/r/295372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I305bbe4ac599b6def50691f20fd2da61d7feff05
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack 
Gerrit-Reviewer: BBlack 
Gerrit-Reviewer: Ema 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] varnish: burn more cpu/mem on better gzip compression - change (operations/puppet)

2016-06-21 Thread BBlack (Code Review) 
BBlack has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/295372

Change subject: varnish: burn more cpu/mem on better gzip compression
..

varnish: burn more cpu/mem on better gzip compression

This raises gzip_level and gzip_memlevel from 6/8 (default) to 8/9.  We have
CPU cycles to waste, and this can slightly reduce cache object storage sizes
and transferred bytes to clients.  Level 8 is what Cloudflare also uses, as 9
doesn't buy much for the potential big bump in CPU waste.  They also use a
hacked zlib that is faster and open source, we could package that if we see a
significant need in the future (e.g. if more applayer leaves compression to
varnish).

Did some preliminary manual testing and everything looks fine.

Will need to salt a runtime change of these parameters via
varnishadm as well, as the diff here only affects the setting for
future daemon restarts.

Change-Id: I305bbe4ac599b6def50691f20fd2da61d7feff05
---
M modules/varnish/templates/initscripts/varnish.systemd.erb
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/72/295372/1

diff --git a/modules/varnish/templates/initscripts/varnish.systemd.erb 
b/modules/varnish/templates/initscripts/varnish.systemd.erb
index 9cd8ec3..f43524a 100644
--- a/modules/varnish/templates/initscripts/varnish.systemd.erb
+++ b/modules/varnish/templates/initscripts/varnish.systemd.erb
@@ -40,6 +40,8 @@
 -p listen_depth=4096 -p session_max=20 -p vcc_err_unref=off \
 -p nuke_limit=300 \
 -p http_req_size=24576 \
+-p gzip_level=8 \
+-p gzip_memlevel=9 \
 <%= @runtime_params -%> \
 <%= @extraopts -%> \
 <% if @vcl_config.fetch("enable_geoiplookup", false) -%>-p 
cc_command=${CC_COMMAND}<% end %>

-- 
To view, visit https://gerrit.wikimedia.org/r/295372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I305bbe4ac599b6def50691f20fd2da61d7feff05
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits