[MediaWiki-commits] [Gerrit] Fix JsonDumperGeneratorTest on Windows - change (mediawiki...Wikibase)

2014-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/106733 Change subject: Fix JsonDumperGeneratorTest on Windows .. Fix JsonDumperGeneratorTest on Windows Change-Id:

[MediaWiki-commits] [Gerrit] DNM Take SpecialSetSiteLink badges out of experimental - change (mediawiki...Wikibase)

2014-01-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/106735 Change subject: DNM Take SpecialSetSiteLink badges out of experimental .. DNM Take SpecialSetSiteLink badges out of experimental

[MediaWiki-commits] [Gerrit] Merge Reference is Statements are the same - change (mediawiki...Wikibase)

2014-01-11 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/106897 Change subject: Merge Reference is Statements are the same .. Merge Reference is Statements are the same If statements have the same main

[MediaWiki-commits] [Gerrit] Remove all use of getSimpleSiteLink method - change (mediawiki...Wikibase)

2014-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107130 Change subject: Remove all use of getSimpleSiteLink method .. Remove all use of getSimpleSiteLink method Change-Id:

[MediaWiki-commits] [Gerrit] Remove all use of deprecated addSimpleSiteLink - change (mediawiki...Wikibase)

2014-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107132 Change subject: Remove all use of deprecated addSimpleSiteLink .. Remove all use of deprecated addSimpleSiteLink Change-Id:

[MediaWiki-commits] [Gerrit] Fix undefined classes - change (mediawiki...Wikibase)

2014-01-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107145 Change subject: Fix undefined classes .. Fix undefined classes Change-Id: Id61f3ed120f17ea4bee9d685e50fa1c10df74c81 --- M

[MediaWiki-commits] [Gerrit] Cleanup ChangeOp related files - change (mediawiki...Wikibase)

2014-01-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107576 Change subject: Cleanup ChangeOp related files .. Cleanup ChangeOp related files Change-Id: I568e71ba24299a3768a4325a54e17de48d300ecc ---

[MediaWiki-commits] [Gerrit] Create ChangeOpReferenceRemove class - change (mediawiki...Wikibase)

2014-01-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107577 Change subject: Create ChangeOpReferenceRemove class .. Create ChangeOpReferenceRemove class This simplifies ChangeOpReference by removing

[MediaWiki-commits] [Gerrit] Create ChangeOpQualifierRemove class - change (mediawiki...Wikibase)

2014-01-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107836 Change subject: Create ChangeOpQualifierRemove class .. Create ChangeOpQualifierRemove class Change-Id:

[MediaWiki-commits] [Gerrit] Reduce limits in NoClientOrRepoUsageTest - change (mediawiki...Wikibase)

2014-01-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/107843 Change subject: Reduce limits in NoClientOrRepoUsageTest .. Reduce limits in NoClientOrRepoUsageTest Change-Id:

[MediaWiki-commits] [Gerrit] Create ChangeOpClaimRemove class - change (mediawiki...Wikibase)

2014-01-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108035 Change subject: Create ChangeOpClaimRemove class .. Create ChangeOpClaimRemove class Change-Id: I16eb8a26d0cb292dd7f969d2736c54970bffc986

[MediaWiki-commits] [Gerrit] Inject Guid Validator and Parser in ChangeOpClaim - change (mediawiki...Wikibase)

2014-01-17 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108038 Change subject: Inject Guid Validator and Parser in ChangeOpClaim .. Inject Guid Validator and Parser in ChangeOpClaim Change-Id:

[MediaWiki-commits] [Gerrit] Add further tests for ChangeOpClaimRemove - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108494 Change subject: Add further tests for ChangeOpClaimRemove .. Add further tests for ChangeOpClaimRemove Change-Id:

[MediaWiki-commits] [Gerrit] Add further tests for ChangeOpReferenceRemove - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108495 Change subject: Add further tests for ChangeOpReferenceRemove .. Add further tests for ChangeOpReferenceRemove Change-Id:

[MediaWiki-commits] [Gerrit] Add further tests for ChangeOpQualifierRemove - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108497 Change subject: Add further tests for ChangeOpQualifierRemove .. Add further tests for ChangeOpQualifierRemove Change-Id:

[MediaWiki-commits] [Gerrit] Clean up error for claim index out of bounds - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108503 Change subject: Clean up error for claim index out of bounds .. Clean up error for claim index out of bounds This changes the uncaught

[MediaWiki-commits] [Gerrit] Remove use of deprecated datamodel classes in \api - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108506 Change subject: Remove use of deprecated datamodel classes in \api .. Remove use of deprecated datamodel classes in \api Change-Id:

[MediaWiki-commits] [Gerrit] Stop marking PermissionsTests as incomplete - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108508 Change subject: Stop marking PermissionsTests as incomplete .. Stop marking PermissionsTests as incomplete Change-Id:

[MediaWiki-commits] [Gerrit] Add hashes to qualifier serilization output - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108519 Change subject: Add hashes to qualifier serilization output .. Add hashes to qualifier serilization output - Adds new option for

[MediaWiki-commits] [Gerrit] Expand ResultBuilder testAddEntityRevision - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108525 Change subject: Expand ResultBuilder testAddEntityRevision .. Expand ResultBuilder testAddEntityRevision Change-Id:

[MediaWiki-commits] [Gerrit] Implement hack to avoid UI throwing this error - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108527 Change subject: Implement hack to avoid UI throwing this error .. Implement hack to avoid UI throwing this error Bug: 58394 Change-Id:

[MediaWiki-commits] [Gerrit] Include dataType id in API output - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108530 Change subject: Include dataType id in API output .. Include dataType id in API output Bug: 57213 Change-Id:

[MediaWiki-commits] [Gerrit] Change travis IRC template - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108532 Change subject: Change travis IRC template .. Change travis IRC template Travis takes up 3 lines after every message. I propose using only

[MediaWiki-commits] [Gerrit] Updated .gitignore - change (mediawiki...Wikibase)

2014-01-20 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Updated .gitignore .. Updated .gitignore Change-Id: If1742834f205b336f82e637cdef20cb506bd4cab --- M .gitignore 1 file changed, 3 insertions(+), 1

[MediaWiki-commits] [Gerrit] Clean up error for claim index out of bounds - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/108672 Change subject: Clean up error for claim index out of bounds .. Clean up error for claim index out of bounds This changes the uncaught

[MediaWiki-commits] [Gerrit] Use automatically generated classmap rather than a manual on... - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Use automatically generated classmap rather than a manual one for Wikibase Client .. Use automatically generated classmap rather than a manual one for

[MediaWiki-commits] [Gerrit] Use automatically generated classmap rather than a manual on... - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Use automatically generated classmap rather than a manual one for Wikibase Lib .. Use automatically generated classmap rather than a manual one for Wikibase

[MediaWiki-commits] [Gerrit] Run composer update in test bootstrap to rebuild classmap - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Run composer update in test bootstrap to rebuild classmap .. Run composer update in test bootstrap to rebuild classmap Change-Id:

[MediaWiki-commits] [Gerrit] Add doc to Wikibase Lib to avoid common fallacy - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Add doc to Wikibase Lib to avoid common fallacy .. Add doc to Wikibase Lib to avoid common fallacy Change-Id: I7a1a09dc6314414af82d5850864e4e5995b94e3d ---

[MediaWiki-commits] [Gerrit] Wikibase is not currently using Coveralls, so rem from Travi... - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Wikibase is not currently using Coveralls, so rem from Travis config .. Wikibase is not currently using Coveralls, so rem from Travis config Change-Id:

[MediaWiki-commits] [Gerrit] Remove clutter from repo entry point - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Remove clutter from repo entry point .. Remove clutter from repo entry point Change-Id: Iee10a2211baf843605c8a6ae877f8f52b796dc5d --- M repo/Wikibase.php 1

[MediaWiki-commits] [Gerrit] Remove clutter from Lib entry point - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Remove clutter from Lib entry point .. Remove clutter from Lib entry point Change-Id: Ic099706c90ca3a5c725575beedf521f5497f5e37 --- M lib/WikibaseLib.php 1

[MediaWiki-commits] [Gerrit] Remove the last manually maintained classmap of doom - change (mediawiki...Wikibase)

2014-01-21 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Remove the last manually maintained classmap of doom .. Remove the last manually maintained classmap of doom Change-Id:

[MediaWiki-commits] [Gerrit] update extension list - change (mediawiki...Wikidata)

2014-01-22 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: update extension list .. update extension list Change-Id: I4d7c9c22f95cbcf858f4a776dc8437c29369f7f2 --- M extension-list-wikidata 1 file changed, 4

[MediaWiki-commits] [Gerrit] Use a valid spdx license idenfitier - change (mediawiki...Wikibase)

2014-11-17 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Use a valid spdx license idenfitier .. Use a valid spdx license idenfitier See https://spdx.org/licenses/, as recommended by composer validate Change-Id:

[MediaWiki-commits] [Gerrit] When merging items, reuse conflicting labels as aliases - change (mediawiki...Wikibase)

2014-12-07 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/178062 Change subject: When merging items, reuse conflicting labels as aliases .. When merging items, reuse conflicting labels as aliases WIP

[MediaWiki-commits] [Gerrit] Simplify item disambig i18n search message - change (mediawiki...Wikibase)

2013-12-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/99362 Change subject: Simplify item disambig i18n search message .. Simplify item disambig i18n search message Bug: 57712 Change-Id:

[MediaWiki-commits] [Gerrit] Fix ResultBuilderTest fail when items in ns 0 - change (mediawiki...Wikibase)

2013-12-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/99363 Change subject: Fix ResultBuilderTest fail when items in ns 0 .. Fix ResultBuilderTest fail when items in ns 0 Change-Id:

[MediaWiki-commits] [Gerrit] Set isSetup in botEditTest class - change (mediawiki...Wikibase)

2013-12-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/99382 Change subject: Set isSetup in botEditTest class .. Set isSetup in botEditTest class Change-Id: Ia8376a7c0c1643d54cc0117d806477e60da3b975

[MediaWiki-commits] [Gerrit] Some cleanup in EditEntityTest - change (mediawiki...Wikibase)

2013-12-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Some cleanup in EditEntityTest .. Some cleanup in EditEntityTest Change-Id: I44da01b2bccedffae760abf2a72c131d1e2199fa --- M

[MediaWiki-commits] [Gerrit] Use higher ids in SetReferenceTest to fix travis - change (mediawiki...Wikibase)

2013-12-05 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/99399 Change subject: Use higher ids in SetReferenceTest to fix travis .. Use higher ids in SetReferenceTest to fix travis Change-Id:

[MediaWiki-commits] [Gerrit] Fix api test group - change (mediawiki...Wikibase)

2013-12-05 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Fix api test group .. Fix api test group Change-Id: Id8fc46bf744d3da4341d9ec9f9b68394ad9786da --- M repo/tests/phpunit/includes/api/FormatSnakValueTest.php

[MediaWiki-commits] [Gerrit] Fix index tag mode in XML getentities output - change (mediawiki...Wikibase)

2013-12-09 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/100367 Change subject: Fix index tag mode in XML getentities output .. Fix index tag mode in XML getentities output Change-Id:

[MediaWiki-commits] [Gerrit] Update gitignore after test files moved - change (mediawiki...Wikibase)

2013-12-10 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Update gitignore after test files moved .. Update gitignore after test files moved Change-Id: I363036eb646d910acf94d5e96097c0dea2bc06ef --- M .gitignore 1

[MediaWiki-commits] [Gerrit] Fix ResultBuilder test on travis - change (mediawiki...Wikibase)

2013-12-10 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/100572 Change subject: Fix ResultBuilder test on travis .. Fix ResultBuilder test on travis

[MediaWiki-commits] [Gerrit] Fix covers tags - change (mediawiki...Wikibase)

2013-12-13 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Fix covers tags .. Fix covers tags Change-Id: I86fd84f0a9ef6aaf5d0b3b00138dc7a93b7c0405 --- M client/tests/phpunit/includes/InterwikiSorterTest.php M

[MediaWiki-commits] [Gerrit] Fix covers tag for NumberValidator - change (mediawiki...Wikibase)

2013-12-13 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Fix covers tag for NumberValidator .. Fix covers tag for NumberValidator Change-Id: I3cea4112fa87ba565a5779c18ac5e03668493fe2 --- M

[MediaWiki-commits] [Gerrit] Cleanup of ClaimModificationHelper and related.. - change (mediawiki...Wikibase)

2013-11-13 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95125 Change subject: Cleanup of ClaimModificationHelper and related.. .. Cleanup of ClaimModificationHelper and related.. - Removes the

[MediaWiki-commits] [Gerrit] Fix EntityId related issue in WikiPageEntityLookup - change (mediawiki...Wikibase)

2013-11-13 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Fix EntityId related issue in WikiPageEntityLookup .. Fix EntityId related issue in WikiPageEntityLookup Change-Id:

[MediaWiki-commits] [Gerrit] Add Wikidata team to credits as Im no longer the only author... - change (mediawiki...WikibaseDataModel)

2013-11-13 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Add Wikidata team to credits as Im no longer the only author of this component .. Add Wikidata team to credits as Im no longer the only author of this

[MediaWiki-commits] [Gerrit] Add docs to MockRepository - change (mediawiki...Wikibase)

2013-11-13 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Add docs to MockRepository .. Add docs to MockRepository Change-Id: I032349482634f6bdfac320549d9d547751fb5a45 --- M lib/tests/phpunit/MockRepository.php 1

[MediaWiki-commits] [Gerrit] Fix random failing tests on travis - change (mediawiki...Wikibase)

2013-11-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95344 Change subject: Fix random failing tests on travis .. Fix random failing tests on travis Change-Id:

[MediaWiki-commits] [Gerrit] Move Getting sitelink targets to its own class - change (mediawiki...Wikibase)

2013-11-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95357 Change subject: Move Getting sitelink targets to its own class .. Move Getting sitelink targets to its own class Change-Id:

[MediaWiki-commits] [Gerrit] Further refactor GetEntitiesOutput - change (mediawiki...Wikibase)

2013-11-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95374 Change subject: Further refactor GetEntitiesOutput .. Further refactor GetEntitiesOutput Change-Id:

[MediaWiki-commits] [Gerrit] Check id entered in SpecialSetSiteLink is an ItemId - change (mediawiki...Wikibase)

2013-11-14 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Check id entered in SpecialSetSiteLink is an ItemId .. Check id entered in SpecialSetSiteLink is an ItemId (also make capitalisation of id more consistent

[MediaWiki-commits] [Gerrit] Implemented index parameter in ChangeOpClaim - change (mediawiki...Wikibase)

2013-11-14 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Implemented index parameter in ChangeOpClaim .. Implemented index parameter in ChangeOpClaim (requires change Iefeebdcc4c6bc8c477d3f234399bcd403466bd52) The

[MediaWiki-commits] [Gerrit] Add basic readme - change (mediawiki...Wikidata)

2013-11-14 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95387 Change subject: Add basic readme .. Add basic readme Change-Id: I2b633bf6246c4f38a9a1b00badf2e57aa1543e02 --- A README.md 1 file changed,

[MediaWiki-commits] [Gerrit] Fixed SetClaimTest - change (mediawiki...Wikibase)

2013-11-14 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Fixed SetClaimTest .. Fixed SetClaimTest Change-Id: I1bc3c33db318ee81a2efafeca8870727b3a3520e --- M repo/tests/phpunit/includes/api/SetClaimTest.php 1 file

[MediaWiki-commits] [Gerrit] Refactor Permissions tests into 2 seperate classes - change (mediawiki...Wikibase)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95597 Change subject: Refactor Permissions tests into 2 seperate classes .. Refactor Permissions tests into 2 seperate classes This can be used

[MediaWiki-commits] [Gerrit] General Cleanup of some Tests - change (mediawiki/core)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95606 Change subject: General Cleanup of some Tests .. General Cleanup of some Tests Style Fixes, Comment fixes Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup and expand Status tests - change (mediawiki/core)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95620 Change subject: Cleanup and expand Status tests .. Cleanup and expand Status tests Change-Id: Ib06df7196c903505fbc0a3945513c5681acaaff3 ---

[MediaWiki-commits] [Gerrit] implement MergeItemsUnitTest - change (mediawiki...Wikibase)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95645 Change subject: implement MergeItemsUnitTest .. implement MergeItemsUnitTest This is the first unit test within wikibase for api modules.

[MediaWiki-commits] [Gerrit] Add basic unit test for dieOnBadUser api method - change (mediawiki...Thanks)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95647 Change subject: Add basic unit test for dieOnBadUser api method .. Add basic unit test for dieOnBadUser api method Change-Id:

[MediaWiki-commits] [Gerrit] Add job for SideBarMenu - change (integration/jenkins-job-builder-config)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95653 Change subject: Add job for SideBarMenu .. Add job for SideBarMenu Change-Id: I613553cebb7be9c4dec96e6cbd1732cbe2d3ebed --- M

[MediaWiki-commits] [Gerrit] Add zuul trigger for SideBarMenu - change (integration/zuul-config)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95654 Change subject: Add zuul trigger for SideBarMenu .. Add zuul trigger for SideBarMenu REQUIRES jenkins job in I613553cebb7b Change-Id:

[MediaWiki-commits] [Gerrit] Fix SideBarMenu unit tests - change (mediawiki...SideBarMenu)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95655 Change subject: Fix SideBarMenu unit tests .. Fix SideBarMenu unit tests Change-Id: Ib33c539ccf2a3e7778f95280341ec3d4c1628fa4 --- M

[MediaWiki-commits] [Gerrit] Remove duplicate AnitSpoof extension entry - change (integration/jenkins-job-builder-config)

2013-11-15 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95660 Change subject: Remove duplicate AnitSpoof extension entry .. Remove duplicate AnitSpoof extension entry Change-Id:

[MediaWiki-commits] [Gerrit] Add some phpdocs for IDEs - change (mediawiki...EventLogging)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95769 Change subject: Add some phpdocs for IDEs .. Add some phpdocs for IDEs Change-Id: I1409c5130a2e3a414494f4ae21caf40510af4fa3 --- M

[MediaWiki-commits] [Gerrit] General fixes, style and comments / phpdoc - change (mediawiki...DPLforum)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95768 Change subject: General fixes, style and comments / phpdoc .. General fixes, style and comments / phpdoc Add phpdoc to benefit editors

[MediaWiki-commits] [Gerrit] Refactor skins/SideBarTest - change (mediawiki/core)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95772 Change subject: Refactor skins/SideBarTest .. Refactor skins/SideBarTest Fix todo Remove totally unneeded code.. Change-Id:

[MediaWiki-commits] [Gerrit] Further expand Status unit tests - change (mediawiki/core)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95770 Change subject: Further expand Status unit tests .. Further expand Status unit tests When writing these I came accross a case that doesnt

[MediaWiki-commits] [Gerrit] Split mocks/media/MockBitmaphandler file - change (mediawiki/core)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95771 Change subject: Split mocks/media/MockBitmaphandler file .. Split mocks/media/MockBitmaphandler file Change-Id:

[MediaWiki-commits] [Gerrit] Split HTMLCheckMatrixTest into 2 files - change (mediawiki/core)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95773 Change subject: Split HTMLCheckMatrixTest into 2 files .. Split HTMLCheckMatrixTest into 2 files Change-Id:

[MediaWiki-commits] [Gerrit] Fix travis irc channel - change (mediawiki...WikibaseQuery)

2013-11-16 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/95775 Change subject: Fix travis irc channel .. Fix travis irc channel Change-Id: I96390a90d4902e05e828f46e9ed223842b5cfe73 --- M .travis.yml 1

[MediaWiki-commits] [Gerrit] Ensure mPreparedEdit in WikiPage gets cleared if set. - change (mediawiki...Wikibase)

2013-11-18 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Ensure mPreparedEdit in WikiPage gets cleared if set. .. Ensure mPreparedEdit in WikiPage gets cleared if set. Depends on I770bf2d in core and fixes

[MediaWiki-commits] [Gerrit] Add .gitreview and .gitignore - change (mediawiki...DataValueImplementations)

2013-11-18 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Add .gitreview and .gitignore .. Add .gitreview and .gitignore Change-Id: I912edbb75a88a9a09c549eb97e661747f7230ad2 --- A .gitignore A .gitreview 2 files

[MediaWiki-commits] [Gerrit] Add .gitreview and .gitignore - change (mediawiki...DataValuesInterfaces)

2013-11-18 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Add .gitreview and .gitignore .. Add .gitreview and .gitignore Change-Id: I5e652b2ac1bb2e2379c903e41b14cdec4b477dcb --- A .gitignore A .gitreview 2 files

[MediaWiki-commits] [Gerrit] Make all DataValues?.* report to #wikidata - change (labs...grrrit)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96041 Change subject: Make all DataValues?.* report to #wikidata .. Make all DataValues?.* report to #wikidata Change-Id:

[MediaWiki-commits] [Gerrit] Switch Query and QueryEngine to checks only - change (integration/zuul-config)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96043 Change subject: Switch Query and QueryEngine to checks only .. Switch Query and QueryEngine to checks only Change-Id:

[MediaWiki-commits] [Gerrit] Remove dependancies that are not on gerrit - change (integration/jenkins-job-builder-config)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96044 Change subject: Remove dependancies that are not on gerrit .. Remove dependancies that are not on gerrit Change-Id:

[MediaWiki-commits] [Gerrit] Remove i18n wbsetstatementrank for removed module - change (mediawiki...Wikibase)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96049 Change subject: Remove i18n wbsetstatementrank for removed module .. Remove i18n wbsetstatementrank for removed module Change-Id:

[MediaWiki-commits] [Gerrit] Add i18n qqq for wbmergeitems - change (mediawiki...Wikibase)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96050 Change subject: Add i18n qqq for wbmergeitems .. Add i18n qqq for wbmergeitems Change-Id: Ica39d1cbd4ad0ab83482fba85f848690d2dc7448 --- M

[MediaWiki-commits] [Gerrit] Add extra context to i18n wbeditentity-override - change (mediawiki...Wikibase)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96052 Change subject: Add extra context to i18n wbeditentity-override .. Add extra context to i18n wbeditentity-override Change-Id:

[MediaWiki-commits] [Gerrit] Cleanup i18n file headers - change (mediawiki...Wikibase)

2013-11-18 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96054 Change subject: Cleanup i18n file headers .. Cleanup i18n file headers Change-Id: I801b73747d370860d85426ea9c20adf71a2d994a --- M

[MediaWiki-commits] [Gerrit] Remove copied code in system tests - change (mediawiki...WikibaseQuery)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96261 Change subject: Remove copied code in system tests .. Remove copied code in system tests Change-Id:

[MediaWiki-commits] [Gerrit] Add final tests for the Status class - change (mediawiki/core)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96286 Change subject: Add final tests for the Status class .. Add final tests for the Status class This class now should have roughly 100% unit

[MediaWiki-commits] [Gerrit] Fix RdfSerializer class phpdoc - change (mediawiki...Wikibase)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96301 Change subject: Fix RdfSerializer class phpdoc .. Fix RdfSerializer class phpdoc Change-Id: Id7cbb3e0cfcf57f2b2fc2f2fb5628085aa020cd9 --- M

[MediaWiki-commits] [Gerrit] Fix phpdoc for RdfBuilder class - change (mediawiki...Wikibase)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96302 Change subject: Fix phpdoc for RdfBuilder class .. Fix phpdoc for RdfBuilder class Change-Id: I17493edcca51b067c8ecff814c3ebabb1bcc2deb ---

[MediaWiki-commits] [Gerrit] Fix case where = should be === - change (mediawiki...Wikibase)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96303 Change subject: Fix case where = should be === .. Fix case where = should be === Change-Id: Id19235445e8b79df5b00ec4ff2e7132bb35a1a8e --- M

[MediaWiki-commits] [Gerrit] Cleanup MultiLangConstraintDetector Class - change (mediawiki...Wikibase)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96304 Change subject: Cleanup MultiLangConstraintDetector Class .. Cleanup MultiLangConstraintDetector Class This could be a potential class to

[MediaWiki-commits] [Gerrit] Fix code that is lying to us! - change (mediawiki...Wikibase)

2013-11-19 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96316 Change subject: Fix code that is lying to us! .. Fix code that is lying to us! Change-Id: I74d02d12ee1880467620e969ae32b7686493195a --- M

[MediaWiki-commits] [Gerrit] Initial step in moving out code from SimpleQuery special page - change (mediawiki...WikibaseQuery)

2013-11-19 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Initial step in moving out code from SimpleQuery special page .. Initial step in moving out code from SimpleQuery special page Includes introduction of two

[MediaWiki-commits] [Gerrit] Update dependency versions - change (mediawiki...WikibaseQueryEngine)

2013-11-19 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Update dependency versions .. Update dependency versions Change-Id: Ieb6088d9dbfdccb9e0beecd6e5d8d7276d48fe13 --- M composer.json 1 file changed, 3

[MediaWiki-commits] [Gerrit] Add ftp to default url schema types - change (mediawiki...Wikibase)

2013-11-20 Thread Addshore (Code Review)
Addshore has submitted this change and it was merged. Change subject: Add ftp to default url schema types .. Add ftp to default url schema types Bug: 54103 Change-Id: I77cb13d6c16a2dbc1677567eec1f4cbc0ae21eea --- M

[MediaWiki-commits] [Gerrit] Start wikidata puppet module for builder - change (operations/puppet)

2013-11-20 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/96552 Change subject: Start wikidata puppet module for builder .. Start wikidata puppet module for builder This 'wikidata 'module just serves as

[MediaWiki-commits] [Gerrit] Restore old result path in wbgetentites - change (mediawiki...Wikibase)

2013-11-25 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/97491 Change subject: Restore old result path in wbgetentites .. Restore old result path in wbgetentites Bug: 57529 Change-Id:

[MediaWiki-commits] [Gerrit] Make sure ApiResult is ready before using it - change (mediawiki...Wikibase)

2013-11-26 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/97736 Change subject: Make sure ApiResult is ready before using it .. Make sure ApiResult is ready before using it In core the ApiResult is not

[MediaWiki-commits] [Gerrit] Inject EntityTitleLookup to ResultBuilder - change (mediawiki...Wikibase)

2013-11-28 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/98099 Change subject: Inject EntityTitleLookup to ResultBuilder .. Inject EntityTitleLookup to ResultBuilder Change-Id:

[MediaWiki-commits] [Gerrit] use lowercase b in Bound i18n - change (mediawiki...Wikibase)

2013-12-02 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/98500 Change subject: use lowercase b in Bound i18n .. use lowercase b in Bound i18n Change-Id: Iac8fc3438fce28008250692e1818f4336f0a22fa --- M

[MediaWiki-commits] [Gerrit] Refactor Api LangAttributes to Terms - change (mediawiki...Wikibase)

2013-12-03 Thread Addshore (Code Review)
Addshore has uploaded a new change for review. https://gerrit.wikimedia.org/r/98794 Change subject: Refactor Api LangAttributes to Terms .. Refactor Api LangAttributes to Terms Change-Id:

  1   2   3   4   5   6   7   8   9   10   >