[MediaWiki-commits] [Gerrit] Update to master of VE core - change (mediawiki...VisualEditor)

2014-01-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/106731 Change subject: Update to master of VE core .. Update to master of VE core New changes: 1f7e944 Add method to fully destroy a target

[MediaWiki-commits] [Gerrit] Generic language inspector - change (VisualEditor/VisualEditor)

2014-01-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107203 Change subject: Generic language inspector .. Generic language inspector * Remove ULS dependencies * Use toggle widget for direction * Make

[MediaWiki-commits] [Gerrit] Update to master of VE core - change (mediawiki...VisualEditor)

2014-01-13 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107268 Change subject: Update to master of VE core .. Update to master of VE core New changes: d89cc15 Add sticky static property to inspector

[MediaWiki-commits] [Gerrit] Add csslint rule for duplicate background images to ve-mw ic... - change (mediawiki...VisualEditor)

2014-01-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107538 Change subject: Add csslint rule for duplicate background images to ve-mw icons CSS too .. Add csslint rule for duplicate background images

[MediaWiki-commits] [Gerrit] Update VE core submodule to master - change (mediawiki...VisualEditor)

2014-01-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107539 Change subject: Update VE core submodule to master .. Update VE core submodule to master New changes: 863288b Update OOjs UI to v0.1.0-pre

[MediaWiki-commits] [Gerrit] Separate concerns between FocusableNode and ProtectedNode - change (VisualEditor/VisualEditor)

2014-01-14 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107540 Change subject: Separate concerns between FocusableNode and ProtectedNode .. Separate concerns between FocusableNode and ProtectedNode *

[MediaWiki-commits] [Gerrit] About-group extra DOM data in toDomElements - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107638 Change subject: About-group extra DOM data in toDomElements .. About-group extra DOM data in toDomElements Although marked as

[MediaWiki-commits] [Gerrit] About-group extra DOM data in toDomElements - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107640 Change subject: About-group extra DOM data in toDomElements .. About-group extra DOM data in toDomElements Although marked as

[MediaWiki-commits] [Gerrit] Update VE core submodule to master - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107724 Change subject: Update VE core submodule to master .. Update VE core submodule to master New changes: b19c86d Make config default to an

[MediaWiki-commits] [Gerrit] Wrap text nodes in spans if trying to mark as data-ve-ignore - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Wrap text nodes in spans if trying to mark as data-ve-ignore .. Wrap text nodes in spans if trying to mark as data-ve-ignore Otherwise you're going to have a

[MediaWiki-commits] [Gerrit] About-group extra DOM data in toDomElements - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: About-group extra DOM data in toDomElements .. About-group extra DOM data in toDomElements Although marked as data-ve-ignore, it isn't ignored by Parsoid, so

[MediaWiki-commits] [Gerrit] About-group extra DOM data in toDomElements - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: About-group extra DOM data in toDomElements .. About-group extra DOM data in toDomElements Although marked as data-ve-ignore, it isn't ignored by Parsoid, so

[MediaWiki-commits] [Gerrit] Wrap text nodes in spans if trying to mark as data-ve-ignore - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Wrap text nodes in spans if trying to mark as data-ve-ignore .. Wrap text nodes in spans if trying to mark as data-ve-ignore Otherwise you're going to have a

[MediaWiki-commits] [Gerrit] Update VisualEditor to 1.23wmf9 branch for cherry-picks - change (mediawiki/core)

2014-01-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107746 Change subject: Update VisualEditor to 1.23wmf9 branch for cherry-picks .. Update VisualEditor to 1.23wmf9 branch for cherry-picks

[MediaWiki-commits] [Gerrit] Update VisualEditor to 1.23wmf10 branch for cherry-picks - change (mediawiki/core)

2014-01-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107747 Change subject: Update VisualEditor to 1.23wmf10 branch for cherry-picks .. Update VisualEditor to 1.23wmf10 branch for cherry-picks

[MediaWiki-commits] [Gerrit] Update VisualEditor to 1.23wmf9 branch for cherry-picks - change (mediawiki/core)

2014-01-15 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to 1.23wmf9 branch for cherry-picks .. Update VisualEditor to 1.23wmf9 branch for cherry-picks Change-Id:

[MediaWiki-commits] [Gerrit] Update VisualEditor to 1.23wmf10 branch for cherry-picks - change (mediawiki/core)

2014-01-15 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to 1.23wmf10 branch for cherry-picks .. Update VisualEditor to 1.23wmf10 branch for cherry-picks Change-Id:

[MediaWiki-commits] [Gerrit] Update VE core submodule to master - change (mediawiki...VisualEditor)

2014-01-15 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/107792 Change subject: Update VE core submodule to master .. Update VE core submodule to master New changes: e699956 Add method to show only

[MediaWiki-commits] [Gerrit] Fix JS error when closing autonumbered link inspector with i... - change (VisualEditor/VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108082 Change subject: Fix JS error when closing autonumbered link inspector with invalid title .. Fix JS error when closing autonumbered link

[MediaWiki-commits] [Gerrit] Prevent newFromAttributeChanges() from creating no-op transa... - change (VisualEditor/VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108085 Change subject: Prevent newFromAttributeChanges() from creating no-op transactions .. Prevent newFromAttributeChanges() from creating no-op

[MediaWiki-commits] [Gerrit] Update VE core submodule to master - change (mediawiki...VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108169 Change subject: Update VE core submodule to master .. Update VE core submodule to master New changes: 93e0069 Fix JS error when closing

[MediaWiki-commits] [Gerrit] Update VE core submodule to f981943126ba - change (mediawiki...VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108178 Change subject: Update VE core submodule to f981943126ba .. Update VE core submodule to f981943126ba New changes: 93e0069 Fix JS error when

[MediaWiki-commits] [Gerrit] Add updateSubmodule.sh script - change (mediawiki...VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108180 Change subject: Add updateSubmodule.sh script .. Add updateSubmodule.sh script Generates a commit that updates the VE core submodule to

[MediaWiki-commits] [Gerrit] Update VE core submodule to eb595b06 - change (mediawiki...VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108181 Change subject: Update VE core submodule to eb595b06 .. Update VE core submodule to eb595b06 New changes: 93e0069 Fix JS error when closing

[MediaWiki-commits] [Gerrit] Script to update the oojs-ui distribution - change (VisualEditor/VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108189 Change subject: Script to update the oojs-ui distribution .. Script to update the oojs-ui distribution Change-Id:

[MediaWiki-commits] [Gerrit] Update VE core submodule to master - change (mediawiki...VisualEditor)

2014-01-17 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/108190 Change subject: Update VE core submodule to master .. Update VE core submodule to master New changes: f981943 Fix toolbar indicators in

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (7922a50558) - change (VisualEditor/VisualEditor)

2014-11-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174589 Change subject: Update OOjs UI to v0.1.0-pre (7922a50558) .. Update OOjs UI to v0.1.0-pre (7922a50558) New changes: 491d279 Change document

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (7922a50558) - change (mediawiki/core)

2014-11-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174590 Change subject: Update OOjs UI to v0.1.0-pre (7922a50558) .. Update OOjs UI to v0.1.0-pre (7922a50558) New changes: 491d279 Change document

[MediaWiki-commits] [Gerrit] Follow-up Icdeaa4c: Load visualeditor-content-select-all mes... - change (mediawiki...VisualEditor)

2014-11-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Follow-up Icdeaa4c: Load visualeditor-content-select-all message .. Follow-up Icdeaa4c: Load visualeditor-content-select-all message Added in Ica731c59. It's

[MediaWiki-commits] [Gerrit] Follow-up Icdeaa4c: Load visualeditor-content-select-all mes... - change (mediawiki...VisualEditor)

2014-11-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Follow-up Icdeaa4c: Load visualeditor-content-select-all message .. Follow-up Icdeaa4c: Load visualeditor-content-select-all message Added in Ica731c59. It's

[MediaWiki-commits] [Gerrit] Update VisualEditor for cherry-pick - change (mediawiki/core)

2014-11-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor for cherry-pick .. Update VisualEditor for cherry-pick New changes: 8600054 Follow-up Icdeaa4c: Load visualeditor-content-select-all

[MediaWiki-commits] [Gerrit] Update VisualEditor for cherry-pick - change (mediawiki/core)

2014-11-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174607 Change subject: Update VisualEditor for cherry-pick .. Update VisualEditor for cherry-pick New changes: d796e2d Follow-up Icdeaa4c: Load

[MediaWiki-commits] [Gerrit] Update VisualEditor for cherry-pick - change (mediawiki/core)

2014-11-19 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174606 Change subject: Update VisualEditor for cherry-pick .. Update VisualEditor for cherry-pick New changes: 8600054 Follow-up Icdeaa4c: Load

[MediaWiki-commits] [Gerrit] Update VisualEditor for cherry-pick - change (mediawiki/core)

2014-11-19 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor for cherry-pick .. Update VisualEditor for cherry-pick New changes: d796e2d Follow-up Icdeaa4c: Load visualeditor-content-select-all

[MediaWiki-commits] [Gerrit] Revert Followup ca6a16f: use parent selector both for hidin... - change (oojs/ui)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174859 Change subject: Revert Followup ca6a16f: use parent selector both for hiding and showing windows .. Revert Followup ca6a16f: use parent

[MediaWiki-commits] [Gerrit] Revert Show the modal overlay as soon as openWindow is called - change (oojs/ui)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174863 Change subject: Revert Show the modal overlay as soon as openWindow is called .. Revert Show the modal overlay as soon as openWindow is

[MediaWiki-commits] [Gerrit] Update Flow for cherry-picks - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174871 Change subject: Update Flow for cherry-picks .. Update Flow for cherry-picks New changes: 3b38ec2 Bug: failed parsoid request on private

[MediaWiki-commits] [Gerrit] Update Flow for cherry-pick - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174873 Change subject: Update Flow for cherry-pick .. Update Flow for cherry-pick New changes: 09da29f Bug: topic list listener not listening to

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (2a36afc90f) - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174876 Change subject: Update OOjs UI to v0.1.0-pre (2a36afc90f) .. Update OOjs UI to v0.1.0-pre (2a36afc90f) New changes: 77d1ce2 Revert Followup

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (8b1aba079c) - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174878 Change subject: Update OOjs UI to v0.1.0-pre (8b1aba079c) .. Update OOjs UI to v0.1.0-pre (8b1aba079c) New changes: 950bdc3 Revert Followup

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (7f4ba6b368) - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174879 Change subject: Update OOjs UI to v0.1.0-pre (7f4ba6b368) .. Update OOjs UI to v0.1.0-pre (7f4ba6b368) New changes: 7c5b3f5 Revert Followup

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (7f4ba6b368) - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update OOjs UI to v0.1.0-pre (7f4ba6b368) .. Update OOjs UI to v0.1.0-pre (7f4ba6b368) New changes: 7c5b3f5 Revert Followup ca6a16f: use parent selector both

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.1.0-pre (2a36afc90f) - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update OOjs UI to v0.1.0-pre (2a36afc90f) .. Update OOjs UI to v0.1.0-pre (2a36afc90f) New changes: 77d1ce2 Revert Followup ca6a16f: use parent selector both

[MediaWiki-commits] [Gerrit] Update VisualEditor to I0550229. - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to I0550229. .. Update VisualEditor to I0550229. Change-Id: Iab8305be685e24e3a09e9a2b3414847f030d2751 --- M extensions/VisualEditor 1

[MediaWiki-commits] [Gerrit] Update VisualEditor for I0550229 and Ie79fe549 - change (mediawiki/core)

2014-11-20 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor for I0550229 and Ie79fe549 .. Update VisualEditor for I0550229 and Ie79fe549 Change-Id: If81508df61c76d6a976e9e3896396cc20b02c28b --- M

[MediaWiki-commits] [Gerrit] Revert Revert Show the modal overlay as soon as openWindow... - change (oojs/ui)

2014-11-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/174892 Change subject: Revert Revert Show the modal overlay as soon as openWindow is called .. Revert Revert Show the modal overlay as soon as

[MediaWiki-commits] [Gerrit] Update Edit schema to latest version - change (mediawiki...WikimediaEvents)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175102 Change subject: Update Edit schema to latest version .. Update Edit schema to latest version Change-Id:

[MediaWiki-commits] [Gerrit] Handle empty rowspan/colspan attributes correctly - change (VisualEditor/VisualEditor)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175116 Change subject: Handle empty rowspan/colspan attributes correctly .. Handle empty rowspan/colspan attributes correctly This commit

[MediaWiki-commits] [Gerrit] Consistently use ve.ui.WindowManager everywhere - change (VisualEditor/VisualEditor)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175125 Change subject: Consistently use ve.ui.WindowManager everywhere .. Consistently use ve.ui.WindowManager everywhere We were using

[MediaWiki-commits] [Gerrit] OO.ui.WindowManager - ve.ui.WindowManager - change (mediawiki...VisualEditor)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175127 Change subject: OO.ui.WindowManager - ve.ui.WindowManager .. OO.ui.WindowManager - ve.ui.WindowManager In keeping with Id6660a4b54 in VE

[MediaWiki-commits] [Gerrit] Focus the bookletLayout on ready in the template dialog - change (mediawiki...VisualEditor)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175184 Change subject: Focus the bookletLayout on ready in the template dialog .. Focus the bookletLayout on ready in the template dialog Depends

[MediaWiki-commits] [Gerrit] Fix the you are now logged in/out warning - change (mediawiki...VisualEditor)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175186 Change subject: Fix the you are now logged in/out warning .. Fix the you are now logged in/out warning It would tell you you were logged out

[MediaWiki-commits] [Gerrit] Blacklist all VisualEditor contentEditables, not just the ma... - change (mediawiki...UniversalLanguageSelector)

2014-11-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175190 Change subject: Blacklist all VisualEditor contentEditables, not just the main one .. Blacklist all VisualEditor contentEditables, not just

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (2d8aeef) - change (mediawiki...VisualEditor)

2014-11-24 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175643 Change subject: Update VE core submodule to master (2d8aeef) .. Update VE core submodule to master (2d8aeef) New changes: 24d7427 Handle

[MediaWiki-commits] [Gerrit] Track new pagedeleted save error in TargetEvents - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175795 Change subject: Track new pagedeleted save error in TargetEvents .. Track new pagedeleted save error in TargetEvents This also requires

[MediaWiki-commits] [Gerrit] Disable papaparse because it breaks everything - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175862 Change subject: Disable papaparse because it breaks everything .. Disable papaparse because it breaks everything Bug: T75896 Change-Id:

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (3270e6c) - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175871 Change subject: Update VE core submodule to master (3270e6c) .. Update VE core submodule to master (3270e6c) New changes: 959e54e Always

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (486b674) - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175885 Change subject: Update VE core submodule to master (486b674) .. Update VE core submodule to master (486b674) New changes: fd9219c Refactor

[MediaWiki-commits] [Gerrit] Make BookletLayout#focus not crash when there are zero pages - change (oojs/ui)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175892 Change subject: Make BookletLayout#focus not crash when there are zero pages .. Make BookletLayout#focus not crash when there are zero pages

[MediaWiki-commits] [Gerrit] Work around broken BooketLayout#focus method in OOUI for now - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175893 Change subject: Work around broken BooketLayout#focus method in OOUI for now .. Work around broken BooketLayout#focus method in OOUI for now

[MediaWiki-commits] [Gerrit] Followup 166a52b: unbreak tools that don't have commands - change (VisualEditor/VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175902 Change subject: Followup 166a52b: unbreak tools that don't have commands .. Followup 166a52b: unbreak tools that don't have commands As a

[MediaWiki-commits] [Gerrit] Allow empty IME test suite - change (VisualEditor/VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175905 Change subject: Allow empty IME test suite .. Allow empty IME test suite Remove exception that was thrown when the IME test suite is empty.

[MediaWiki-commits] [Gerrit] ve.init.mw.trackSubscriber: Populate platform field with hack - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175912 Change subject: ve.init.mw.trackSubscriber: Populate platform field with hack .. ve.init.mw.trackSubscriber: Populate platform field with

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (0e7f030) - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175914 Change subject: Update VE core submodule to master (0e7f030) .. Update VE core submodule to master (0e7f030) New changes: ba3ab28 Followup

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (f0a63dc) - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175921 Change subject: Update VE core submodule to master (f0a63dc) .. Update VE core submodule to master (f0a63dc) New changes: 7ac893b Editable

[MediaWiki-commits] [Gerrit] Revert ve.init.mw.trackSubscriber: Populate platform field ... - change (mediawiki...VisualEditor)

2014-11-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/175922 Change subject: Revert ve.init.mw.trackSubscriber: Populate platform field with hack .. Revert ve.init.mw.trackSubscriber: Populate platform

[MediaWiki-commits] [Gerrit] Followup 0165a53: fix typo causing undefined to be passed to... - change (mediawiki...VisualEditor)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/170985 Change subject: Followup 0165a53: fix typo causing undefined to be passed to mw.Title .. Followup 0165a53: fix typo causing undefined to be

[MediaWiki-commits] [Gerrit] Followup 0165a53: don't store an mw.Title object instead of ... - change (mediawiki...VisualEditor)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/170991 Change subject: Followup 0165a53: don't store an mw.Title object instead of a string in TemplateModel .. Followup 0165a53: don't store an

[MediaWiki-commits] [Gerrit] Populate LookupInputWidget on mousedown too - change (oojs/ui)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171006 Change subject: Populate LookupInputWidget on mousedown too .. Populate LookupInputWidget on mousedown too We were relying on this already

[MediaWiki-commits] [Gerrit] Add the RangeFix library to VisualEditor.php - change (mediawiki...VisualEditor)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171150 Change subject: Add the RangeFix library to VisualEditor.php .. Add the RangeFix library to VisualEditor.php It wasn't being loaded at all,

[MediaWiki-commits] [Gerrit] Fix indicator alignment in MWCategoryItemWidget - change (mediawiki...VisualEditor)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171165 Change subject: Fix indicator alignment in MWCategoryItemWidget .. Fix indicator alignment in MWCategoryItemWidget We were setting the

[MediaWiki-commits] [Gerrit] Revert Clear selection after tearing down surface to work a... - change (mediawiki...VisualEditor)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171177 Change subject: Revert Clear selection after tearing down surface to work around Firefox bug .. Revert Clear selection after tearing down

[MediaWiki-commits] [Gerrit] Update VE core submodule to master (caaff2c) - change (mediawiki...VisualEditor)

2014-11-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171180 Change subject: Update VE core submodule to master (caaff2c) .. Update VE core submodule to master (caaff2c) New changes: d0ab5bd

[MediaWiki-commits] [Gerrit] Followup 07251d0: add mobile target to rangefix - change (mediawiki...VisualEditor)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171306 Change subject: Followup 07251d0: add mobile target to rangefix .. Followup 07251d0: add mobile target to rangefix Bug: 73038 Change-Id:

[MediaWiki-commits] [Gerrit] Remove nonfunctional $icon/$indicator code from OptionWidget - change (oojs/ui)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171322 Change subject: Remove nonfunctional $icon/$indicator code from OptionWidget .. Remove nonfunctional $icon/$indicator code from OptionWidget

[MediaWiki-commits] [Gerrit] Remove the loading spinner at the end, not halfway through l... - change (mediawiki...VisualEditor)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171429 Change subject: Remove the loading spinner at the end, not halfway through loading .. Remove the loading spinner at the end, not halfway

[MediaWiki-commits] [Gerrit] Fix JS error when no data is passed to an event - change (mediawiki...WikimediaEvents)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171437 Change subject: Fix JS error when no data is passed to an event .. Fix JS error when no data is passed to an event Change-Id:

[MediaWiki-commits] [Gerrit] Followup 31bafa1: forgot to rename 'data' to 'args' for cita... - change (mediawiki...VisualEditor)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171447 Change subject: Followup 31bafa1: forgot to rename 'data' to 'args' for citation commands .. Followup 31bafa1: forgot to rename 'data' to

[MediaWiki-commits] [Gerrit] Add schema.Edit - change (mediawiki...WikimediaEvents)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171497 Change subject: Add schema.Edit .. Add schema.Edit Change-Id: I978eda96cd8a06b5d29d9b83694ff69f05effbe7 --- M WikimediaEvents.php 1 file

[MediaWiki-commits] [Gerrit] Add instrumentation for edit schema - change (mediawiki...VisualEditor)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171499 Change subject: Add instrumentation for edit schema .. Add instrumentation for edit schema Move ve.track() subscriber to its own file, and

[MediaWiki-commits] [Gerrit] ve.utils.js updates - change (mediawiki...VisualEditor)

2014-11-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171498 Change subject: ve.utils.js updates .. ve.utils.js updates Change-Id: Ibb7d7483b23edcccbd83dc8fadd4407dca380a25 --- M VisualEditor.php 1

[MediaWiki-commits] [Gerrit] Fix non-linear selection handling in ce.Surface#focus - change (VisualEditor/VisualEditor)

2014-11-06 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171734 Change subject: Fix non-linear selection handling in ce.Surface#focus .. Fix non-linear selection handling in ce.Surface#focus Table

[MediaWiki-commits] [Gerrit] Fix non-linear selection handling in ce.Surface#focus - change (VisualEditor/VisualEditor)

2014-11-06 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171757 Change subject: Fix non-linear selection handling in ce.Surface#focus .. Fix non-linear selection handling in ce.Surface#focus Table

[MediaWiki-commits] [Gerrit] Update VisualEditor core for cherry-pick - change (mediawiki...VisualEditor)

2014-11-06 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171759 Change subject: Update VisualEditor core for cherry-pick .. Update VisualEditor core for cherry-pick New changes: 8d910e0 Fix non-linear

[MediaWiki-commits] [Gerrit] Update VisualEditor core for cherry-pick - change (mediawiki...VisualEditor)

2014-11-06 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor core for cherry-pick .. Update VisualEditor core for cherry-pick New changes: 8d910e0 Fix non-linear selection handling in

[MediaWiki-commits] [Gerrit] Update VisualEditor for cherry-pick - change (mediawiki/core)

2014-11-06 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171761 Change subject: Update VisualEditor for cherry-pick .. Update VisualEditor for cherry-pick New changes: 4c8b313 Update VisualEditor core for

[MediaWiki-commits] [Gerrit] Remove and restore selection for non-isolated dialogs - change (VisualEditor/VisualEditor)

2014-11-07 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171882 Change subject: Remove and restore selection for non-isolated dialogs .. Remove and restore selection for non-isolated dialogs In

[MediaWiki-commits] [Gerrit] Fix craziness in template dialog focusing - change (mediawiki...VisualEditor)

2014-11-07 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/171997 Change subject: Fix craziness in template dialog focusing .. Fix craziness in template dialog focusing setMode() is called multiple times,

[MediaWiki-commits] [Gerrit] Followup a054a75: don't reintroduce removed template parameters - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172317 Change subject: Followup a054a75: don't reintroduce removed template parameters .. Followup a054a75: don't reintroduce removed template

[MediaWiki-commits] [Gerrit] Followup c232083: use getRelativeTitle for template titles - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172319 Change subject: Followup c232083: use getRelativeTitle for template titles .. Followup c232083: use getRelativeTitle for template titles

[MediaWiki-commits] [Gerrit] Followup a86d824: fix stupid stupid logic inversion - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172320 Change subject: Followup a86d824: fix stupid stupid logic inversion .. Followup a86d824: fix stupid stupid logic inversion Bug: 73235

[MediaWiki-commits] [Gerrit] Followup c232083: use getRelativeTitle for template titles - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172328 Change subject: Followup c232083: use getRelativeTitle for template titles .. Followup c232083: use getRelativeTitle for template titles

[MediaWiki-commits] [Gerrit] Followup a86d824: fix reference to this in foreach callback - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172329 Change subject: Followup a86d824: fix reference to this in foreach callback .. Followup a86d824: fix reference to this in foreach callback

[MediaWiki-commits] [Gerrit] Remove last usage of ve.bind() in VE-MW - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172334 Change subject: Remove last usage of ve.bind() in VE-MW .. Remove last usage of ve.bind() in VE-MW Change-Id:

[MediaWiki-commits] [Gerrit] Followup d4c133b: ve.js depends on oojs - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172339 Change subject: Followup d4c133b: ve.js depends on oojs .. Followup d4c133b: ve.js depends on oojs Change-Id:

[MediaWiki-commits] [Gerrit] Fix pasteSpecial command - change (VisualEditor/VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172403 Change subject: Fix pasteSpecial command .. Fix pasteSpecial command Change-Id: I5f2960984c463ebdac02165fb97548349c1a9f5a (cherry picked

[MediaWiki-commits] [Gerrit] Followup d4c133b: also make TargetEvents depend on ve.track() - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172431 Change subject: Followup d4c133b: also make TargetEvents depend on ve.track() .. Followup d4c133b: also make TargetEvents depend on

[MediaWiki-commits] [Gerrit] Followup 5c0c117: make the edit tab work with oldid= again - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172435 Change subject: Followup 5c0c117: make the edit tab work with oldid= again .. Followup 5c0c117: make the edit tab work with oldid= again

[MediaWiki-commits] [Gerrit] Followup d4c133b: also make TargetEvents depend on ve.track() - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172440 Change subject: Followup d4c133b: also make TargetEvents depend on ve.track() .. Followup d4c133b: also make TargetEvents depend on

[MediaWiki-commits] [Gerrit] Update VE core for cherry-picks - change (mediawiki...VisualEditor)

2014-11-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/172441 Change subject: Update VE core for cherry-picks .. Update VE core for cherry-picks New changes: 3eebf9d Remove and restore selection for

  1   2   3   4   5   6   7   8   9   10   >