[MediaWiki-commits] [Gerrit] integration/commit-message-validator[master]: Remove StopIteration for PEP 479 compatibility
jenkins-bot has submitted this change and it was merged. Change subject: Remove StopIteration for PEP 479 compatibility .. Remove StopIteration for PEP 479 compatibility Replace 'raise StopIteration' with 'return' which is a forward and backward compatible replacement to exit a generator. Change-Id: I5210ec038bd98e623207001c5b8832394805db7e --- M commit_message_validator/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/commit_message_validator/__init__.py b/commit_message_validator/__init__.py index bc83397..7c0f9b8 100644 --- a/commit_message_validator/__init__.py +++ b/commit_message_validator/__init__.py @@ -121,7 +121,7 @@ if normalized_name not in FOOTERS: # Meh. Not a name we care about -raise StopIteration +return if normalized_name in BAD_FOOTERS: # Treat as the correct name for the rest of the rules -- To view, visit https://gerrit.wikimedia.org/r/316515 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5210ec038bd98e623207001c5b8832394805db7e Gerrit-PatchSet: 1 Gerrit-Project: integration/commit-message-validator Gerrit-Branch: master Gerrit-Owner: BryanDavis Gerrit-Reviewer: Hashar Gerrit-Reviewer: Legoktm Gerrit-Reviewer: Paladox Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] integration/commit-message-validator[master]: Remove StopIteration for PEP 479 compatibility
BryanDavis has uploaded a new change for review. https://gerrit.wikimedia.org/r/316515 Change subject: Remove StopIteration for PEP 479 compatibility .. Remove StopIteration for PEP 479 compatibility Replace 'raise StopIteration' with 'return' which is a forward and backward compatible replacement to exit a generator. Change-Id: I5210ec038bd98e623207001c5b8832394805db7e --- M commit_message_validator/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/integration/commit-message-validator refs/changes/15/316515/1 diff --git a/commit_message_validator/__init__.py b/commit_message_validator/__init__.py index bc83397..7c0f9b8 100644 --- a/commit_message_validator/__init__.py +++ b/commit_message_validator/__init__.py @@ -121,7 +121,7 @@ if normalized_name not in FOOTERS: # Meh. Not a name we care about -raise StopIteration +return if normalized_name in BAD_FOOTERS: # Treat as the correct name for the rest of the rules -- To view, visit https://gerrit.wikimedia.org/r/316515 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5210ec038bd98e623207001c5b8832394805db7e Gerrit-PatchSet: 1 Gerrit-Project: integration/commit-message-validator Gerrit-Branch: master Gerrit-Owner: BryanDavis ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
