[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceGroupManager[master]: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

2018-01-17 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404663 )

Change subject: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and
..


WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

used new registry for admin tools.

Change-Id: I80d497d8a200199c698d230f846a4b28fd236223
---
M GroupManager.class.php
M extension.json
A src/AdminTool.php
3 files changed, 46 insertions(+), 15 deletions(-)

Approvals:
  Robert Vogel: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/GroupManager.class.php b/GroupManager.class.php
index fdb1e81..522f7fb 100644
--- a/GroupManager.class.php
+++ b/GroupManager.class.php
@@ -34,21 +34,6 @@
  */
 class GroupManager extends BsExtensionMW {
 
-   /**
-* constructor for GroupManager class
-*/
-   public function __construct() {
-   wfProfileIn( 'BS::'.__METHOD__ );
-   WikiAdmin::registerModule( 'GroupManager', [
-   'image' => 
'/extensions/BlueSpiceExtensions/WikiAdmin/resources/images/bs-btn_gruppe_v1.png',
-   'level' => 'wikiadmin',
-   'message' => 'bs-groupmanager-label',
-   'iconCls' => 'bs-icon-group',
-   'permissions' => [ 'groupmanager-viewspecialpage' ],
-   ]);
-   wfProfileOut( 'BS::'.__METHOD__ );
-   }
-
protected function initExt() {
wfProfileIn( 'BS::'.__METHOD__ );
$this->mCore->registerPermission( 
'groupmanager-viewspecialpage', array( 'sysop' ), array( 'type' => 'global' ) );
diff --git a/extension.json b/extension.json
index 4220b7c..a32af32 100644
--- a/extension.json
+++ b/extension.json
@@ -43,6 +43,12 @@
"ExtensionMessagesFiles": {
"SpecialGroupManagerAlias": 
"includes/specials/SpecialGroupManager.alias.php"
},
+   "BlueSpiceFoundationAdminToolRegistry": {
+   "bs-group-manager": "BlueSpice\\GroupManager\\AdminTool"
+   },
+   "AutoloadNamespaces": {
+   "BlueSpice\\GroupManager\\" : "src/"
+   },
"AutoloadClasses": {
"GroupManager": "GroupManager.class.php",
"BSApiTasksGroupManager": 
"includes/api/BSApiTasksGroupManager.php",
diff --git a/src/AdminTool.php b/src/AdminTool.php
new file mode 100644
index 000..3870c54
--- /dev/null
+++ b/src/AdminTool.php
@@ -0,0 +1,40 @@
+getLocalURL();
+   }
+
+   public function getDescription() {
+   return wfMessage( 'bs-groupmanager-desc' );
+   }
+
+   public function getName() {
+   return wfMessage( 'groupmanager' );
+   }
+
+   public function getClasses() {
+   $classes = array(
+   'bs-icon-group'
+   );
+
+   return implode( ' ', $classes );
+   }
+
+   public function getDataAttributes() {
+   }
+
+   public function getPermissions() {
+   $permissions = array(
+   'groupmanager-viewspecialpage'
+   );
+   return $permissions;
+   }
+
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/404663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80d497d8a200199c698d230f846a4b28fd236223
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceGroupManager
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceGroupManager[master]: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

2018-01-17 Thread Dvogel hallowelt (Code Review)
Dvogel hallowelt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404663 )

Change subject: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and
..

WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

used new registry for admin tools.

Change-Id: I80d497d8a200199c698d230f846a4b28fd236223
---
M GroupManager.class.php
M extension.json
A src/AdminTool.php
3 files changed, 46 insertions(+), 15 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceGroupManager 
refs/changes/63/404663/1

diff --git a/GroupManager.class.php b/GroupManager.class.php
index fdb1e81..522f7fb 100644
--- a/GroupManager.class.php
+++ b/GroupManager.class.php
@@ -34,21 +34,6 @@
  */
 class GroupManager extends BsExtensionMW {
 
-   /**
-* constructor for GroupManager class
-*/
-   public function __construct() {
-   wfProfileIn( 'BS::'.__METHOD__ );
-   WikiAdmin::registerModule( 'GroupManager', [
-   'image' => 
'/extensions/BlueSpiceExtensions/WikiAdmin/resources/images/bs-btn_gruppe_v1.png',
-   'level' => 'wikiadmin',
-   'message' => 'bs-groupmanager-label',
-   'iconCls' => 'bs-icon-group',
-   'permissions' => [ 'groupmanager-viewspecialpage' ],
-   ]);
-   wfProfileOut( 'BS::'.__METHOD__ );
-   }
-
protected function initExt() {
wfProfileIn( 'BS::'.__METHOD__ );
$this->mCore->registerPermission( 
'groupmanager-viewspecialpage', array( 'sysop' ), array( 'type' => 'global' ) );
diff --git a/extension.json b/extension.json
index 4220b7c..a32af32 100644
--- a/extension.json
+++ b/extension.json
@@ -43,6 +43,12 @@
"ExtensionMessagesFiles": {
"SpecialGroupManagerAlias": 
"includes/specials/SpecialGroupManager.alias.php"
},
+   "BlueSpiceFoundationAdminToolRegistry": {
+   "bs-group-manager": "BlueSpice\\GroupManager\\AdminTool"
+   },
+   "AutoloadNamespaces": {
+   "BlueSpice\\GroupManager\\" : "src/"
+   },
"AutoloadClasses": {
"GroupManager": "GroupManager.class.php",
"BSApiTasksGroupManager": 
"includes/api/BSApiTasksGroupManager.php",
diff --git a/src/AdminTool.php b/src/AdminTool.php
new file mode 100644
index 000..3870c54
--- /dev/null
+++ b/src/AdminTool.php
@@ -0,0 +1,40 @@
+getLocalURL();
+   }
+
+   public function getDescription() {
+   return wfMessage( 'bs-groupmanager-desc' );
+   }
+
+   public function getName() {
+   return wfMessage( 'groupmanager' );
+   }
+
+   public function getClasses() {
+   $classes = array(
+   'bs-icon-group'
+   );
+
+   return implode( ' ', $classes );
+   }
+
+   public function getDataAttributes() {
+   }
+
+   public function getPermissions() {
+   $permissions = array(
+   'groupmanager-viewspecialpage'
+   );
+   return $permissions;
+   }
+
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/404663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80d497d8a200199c698d230f846a4b28fd236223
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceGroupManager
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt 

___
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits