[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceNamespaceManager[master]: WikiAdmin is not Part of BlueSpice 3. Removed unneeded code and

2018-01-18 Thread Robert Vogel (Code Review)
Robert Vogel has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404938 )

Change subject: WikiAdmin is not Part of BlueSpice 3. Removed unneeded code and
..


WikiAdmin is not Part of BlueSpice 3. Removed unneeded code and

used new registry for admin tools

Change-Id: Iedf18c172f0441fd3ab3bc01c5dedd7e12985476
---
M NamespaceManager.class.php
M extension.json
A src/AdminTool.php
3 files changed, 43 insertions(+), 12 deletions(-)

Approvals:
  Robert Vogel: Verified; Looks good to me, approved



diff --git a/NamespaceManager.class.php b/NamespaceManager.class.php
index c6d4c3c..77652ad 100644
--- a/NamespaceManager.class.php
+++ b/NamespaceManager.class.php
@@ -49,18 +49,6 @@
'dir' => ''
);
 
-   public function __construct() {
-   wfProfileIn( 'BS::NamespaceManager::__construct' );
-   WikiAdmin::registerModule( 'NamespaceManager', [
-   'image' => 
'/extensions/BlueSpiceExtensions/WikiAdmin/resources/images/bs-btn_namespaces_v1.png',
-   'level' => 'wikiadmin',
-   'message' => 'bs-namespacemanager-label',
-   'iconCls' => 'bs-icon-register-box',
-   'permissions' => [ 'namespacemanager-viewspecialpage' ],
-   ]);
-   wfProfileOut( 'BS::NamespaceManager::__construct' );
-   }
-
/**
 * Initialization of NamespaceManager extension
 */
diff --git a/extension.json b/extension.json
index ce50fef..c04280a 100644
--- a/extension.json
+++ b/extension.json
@@ -17,6 +17,9 @@
"className": "NamespaceManager",
"extPath": "/BlueSpiceNamespaceManager"
}
+   },
+   "AdminToolRegistry": {
+   "bs-namespace-manager": 
"BlueSpice\\NamespaceManager\\AdminTool"
}
}
},
diff --git a/src/AdminTool.php b/src/AdminTool.php
new file mode 100644
index 000..b92348e
--- /dev/null
+++ b/src/AdminTool.php
@@ -0,0 +1,40 @@
+getLocalURL();
+   }
+
+   public function getDescription() {
+   return wfMessage( 'bs-namespacemanager-desc' );
+   }
+
+   public function getName() {
+   return wfMessage( 'bs-namespacemanager-label' );
+   }
+
+   public function getClasses() {
+   $classes = array(
+   'bs-icon-register-box'
+   );
+
+   return $classes;
+   }
+
+   public function getDataAttributes() {
+   }
+
+   public function getPermissions() {
+   $permissions = array(
+   'namespacemanager-viewspecialpage'
+   );
+   return $permissions;
+   }
+
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/404938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedf18c172f0441fd3ab3bc01c5dedd7e12985476
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceNamespaceManager
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceNamespaceManager[master]: WikiAdmin is not Part of BlueSpice 3. Removed unneeded code and

2018-01-18 Thread Dvogel hallowelt (Code Review)
Dvogel hallowelt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404938 )

Change subject: WikiAdmin is not Part of BlueSpice 3. Removed unneeded code and
..

WikiAdmin is not Part of BlueSpice 3. Removed unneeded code and

used new registry for admin tools

Change-Id: Iedf18c172f0441fd3ab3bc01c5dedd7e12985476
---
M NamespaceManager.class.php
M extension.json
A src/AdminTool.php
3 files changed, 43 insertions(+), 12 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceNamespaceManager 
refs/changes/38/404938/1

diff --git a/NamespaceManager.class.php b/NamespaceManager.class.php
index c6d4c3c..77652ad 100644
--- a/NamespaceManager.class.php
+++ b/NamespaceManager.class.php
@@ -49,18 +49,6 @@
'dir' => ''
);
 
-   public function __construct() {
-   wfProfileIn( 'BS::NamespaceManager::__construct' );
-   WikiAdmin::registerModule( 'NamespaceManager', [
-   'image' => 
'/extensions/BlueSpiceExtensions/WikiAdmin/resources/images/bs-btn_namespaces_v1.png',
-   'level' => 'wikiadmin',
-   'message' => 'bs-namespacemanager-label',
-   'iconCls' => 'bs-icon-register-box',
-   'permissions' => [ 'namespacemanager-viewspecialpage' ],
-   ]);
-   wfProfileOut( 'BS::NamespaceManager::__construct' );
-   }
-
/**
 * Initialization of NamespaceManager extension
 */
diff --git a/extension.json b/extension.json
index ce50fef..c04280a 100644
--- a/extension.json
+++ b/extension.json
@@ -17,6 +17,9 @@
"className": "NamespaceManager",
"extPath": "/BlueSpiceNamespaceManager"
}
+   },
+   "AdminToolRegistry": {
+   "bs-namespace-manager": 
"BlueSpice\\NamespaceManager\\AdminTool"
}
}
},
diff --git a/src/AdminTool.php b/src/AdminTool.php
new file mode 100644
index 000..b92348e
--- /dev/null
+++ b/src/AdminTool.php
@@ -0,0 +1,40 @@
+getLocalURL();
+   }
+
+   public function getDescription() {
+   return wfMessage( 'bs-namespacemanager-desc' );
+   }
+
+   public function getName() {
+   return wfMessage( 'bs-namespacemanager-label' );
+   }
+
+   public function getClasses() {
+   $classes = array(
+   'bs-icon-register-box'
+   );
+
+   return $classes;
+   }
+
+   public function getDataAttributes() {
+   }
+
+   public function getPermissions() {
+   $permissions = array(
+   'namespacemanager-viewspecialpage'
+   );
+   return $permissions;
+   }
+
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/404938
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedf18c172f0441fd3ab3bc01c5dedd7e12985476
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceNamespaceManager
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt 

___
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits