[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.7]: Upgrade mapdata lib to fix a bug on rowiki

2017-01-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330321 )

Change subject: Upgrade mapdata lib to fix a bug on rowiki
..


Upgrade mapdata lib to fix a bug on rowiki

Bug: T154117
Change-Id: I2a277fe5defd1aaa16c3fed1290358ec264c99c9
(cherry picked from commit 676956f7b472dbcf030eb3ee17df9d457d28fe39)
---
M lib/wikimedia-mapdata.js
M package.json
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/wikimedia-mapdata.js b/lib/wikimedia-mapdata.js
index 43c72e9..c18ef07 100644
--- a/lib/wikimedia-mapdata.js
+++ b/lib/wikimedia-mapdata.js
@@ -401,11 +401,11 @@
   HybridGroup.prototype.fetchExternalGroups = function () {
 var promises = [],
 group = this,
-key,
+i,
 externals = group.externals;
 
-for ( key in externals ) {
-  promises.push( externals[ key ].fetch() );
+for ( i = 0; i < externals.length; i++ ) {
+  promises.push( externals[ i ].fetch() );
 }
 
 return whenAllPromises( promises ).then( function () {
diff --git a/package.json b/package.json
index 4cc7213..fb83ed9 100644
--- a/package.json
+++ b/package.json
@@ -28,7 +28,7 @@
 "leaflet": "^0.7.7",
 "leaflet-sleep": "juliengirault/Leaflet.Sleep",
 "maki": "^0.5.0",
-"wikimedia-mapdata": 
"git+https://gerrit.wikimedia.org/r/mapdata#ee3a9e5dcfb89cffc28acb24e2cc281931ceaf08;,
+"wikimedia-mapdata": 
"git+https://gerrit.wikimedia.org/r/mapdata#dcd526f619c69c0297bf5ba486c26c2a9a91ee02;,
 "wmui-base": 
"git+https://phabricator.wikimedia.org/diffusion/WMUI/wikimedia-ui-base.git#v0.7.1;
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/330321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a277fe5defd1aaa16c3fed1290358ec264c99c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.29.0-wmf.7
Gerrit-Owner: Yurik 
Gerrit-Reviewer: JGirault 
Gerrit-Reviewer: Yurik 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.7]: Upgrade mapdata lib to fix a bug on rowiki

2017-01-03 Thread Yurik (Code Review) 
Yurik has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330321 )

Change subject: Upgrade mapdata lib to fix a bug on rowiki
..

Upgrade mapdata lib to fix a bug on rowiki

Bug: T154117
Change-Id: I2a277fe5defd1aaa16c3fed1290358ec264c99c9
(cherry picked from commit 676956f7b472dbcf030eb3ee17df9d457d28fe39)
---
M lib/wikimedia-mapdata.js
M package.json
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/21/330321/1

diff --git a/lib/wikimedia-mapdata.js b/lib/wikimedia-mapdata.js
index 43c72e9..c18ef07 100644
--- a/lib/wikimedia-mapdata.js
+++ b/lib/wikimedia-mapdata.js
@@ -401,11 +401,11 @@
   HybridGroup.prototype.fetchExternalGroups = function () {
 var promises = [],
 group = this,
-key,
+i,
 externals = group.externals;
 
-for ( key in externals ) {
-  promises.push( externals[ key ].fetch() );
+for ( i = 0; i < externals.length; i++ ) {
+  promises.push( externals[ i ].fetch() );
 }
 
 return whenAllPromises( promises ).then( function () {
diff --git a/package.json b/package.json
index 4cc7213..fb83ed9 100644
--- a/package.json
+++ b/package.json
@@ -28,7 +28,7 @@
 "leaflet": "^0.7.7",
 "leaflet-sleep": "juliengirault/Leaflet.Sleep",
 "maki": "^0.5.0",
-"wikimedia-mapdata": 
"git+https://gerrit.wikimedia.org/r/mapdata#ee3a9e5dcfb89cffc28acb24e2cc281931ceaf08;,
+"wikimedia-mapdata": 
"git+https://gerrit.wikimedia.org/r/mapdata#dcd526f619c69c0297bf5ba486c26c2a9a91ee02;,
 "wmui-base": 
"git+https://phabricator.wikimedia.org/diffusion/WMUI/wikimedia-ui-base.git#v0.7.1;
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/330321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a277fe5defd1aaa16c3fed1290358ec264c99c9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.29.0-wmf.7
Gerrit-Owner: Yurik 
Gerrit-Reviewer: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits