Fomafix has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311918
Change subject: Use an empty array instead of the uls-p-lang-dummy entry
......................................................................
Use an empty array instead of the uls-p-lang-dummy entry
Change-Id: I54a18f5bd85a8261a25e1160dda7a33fbdf3dd7b
---
M UniversalLanguageSelector.hooks.php
M resources/js/ext.uls.interface.js
2 files changed, 4 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/18/311918/1
diff --git a/UniversalLanguageSelector.hooks.php
b/UniversalLanguageSelector.hooks.php
index fed4065..a3e1a51 100644
--- a/UniversalLanguageSelector.hooks.php
+++ b/UniversalLanguageSelector.hooks.php
@@ -434,12 +434,10 @@
return true;
}
- // A dummy link, just to make sure that the section appears
- $template->data['language_urls'][] = [
- 'href' => '#',
- 'text' => '',
- 'class' => 'uls-p-lang-dummy',
- ];
+ // Set to an empty array, just to make sure that the section
appears
+ if ( $template->get( 'language_urls' ) === false ) {
+ $template->set( 'language_urls', [] );
+ }
return true;
}
diff --git a/resources/js/ext.uls.interface.js
b/resources/js/ext.uls.interface.js
index 910ac10..8873b59 100644
--- a/resources/js/ext.uls.interface.js
+++ b/resources/js/ext.uls.interface.js
@@ -319,8 +319,6 @@
$pLang.prepend( $ulsTrigger );
// Take care of any other elements with this class.
$ulsTrigger = $( '.uls-settings-trigger' );
- // Remove the dummy link, which was added to make sure
that the section appears
- $pLang.find( '.uls-p-lang-dummy' ).remove();
if ( !$pLang.find( 'div ul' ).children().length ) {
// Replace the title of the interlanguage links
area
--
To view, visit https://gerrit.wikimedia.org/r/311918
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54a18f5bd85a8261a25e1160dda7a33fbdf3dd7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Fomafix <foma...@googlemail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
