[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use list() without space before the parenthesis
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405726 )
Change subject: Use list() without space before the parenthesis
..
Use list() without space before the parenthesis
The `list ()` variant will be forbidden once the underlying MediaWiki
ruleset is updated to 0.11.1 (part of wmde/WikibaseCodeSniffer#18,
expected to become wikibase/wikibase-codesniffer 0.3.0).
Change-Id: Id79298185cba92f66220ad0738552f478e7ca4a1
---
M src/ConstraintCheck/Checker/CommonsLinkChecker.php
M src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
M src/ConstraintCheck/Helper/SparqlHelper.php
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Kreuz (WMDE): Looks good to me, approved
diff --git a/src/ConstraintCheck/Checker/CommonsLinkChecker.php
b/src/ConstraintCheck/Checker/CommonsLinkChecker.php
index 928e257..c091c23 100644
--- a/src/ConstraintCheck/Checker/CommonsLinkChecker.php
+++ b/src/ConstraintCheck/Checker/CommonsLinkChecker.php
@@ -146,7 +146,7 @@
if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
throw new MalformedTitleException(
'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); //
caught below
}
- list ( $defaultNamespace, $prefix ) =
$this->getCommonsNamespace( $namespace );
+ list( $defaultNamespace, $prefix ) =
$this->getCommonsNamespace( $namespace );
$title = $this->titleParser->parseTitle( $prefix .
$commonsLink, $defaultNamespace );
if ( $this->pageExists( $title ) ) {
$message = '';
diff --git a/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
b/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
index f516bbd..d1c74ca 100644
--- a/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
+++ b/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
@@ -159,7 +159,7 @@
$minuend = $snak->getDataValue();
/** @var PropertyId $property */
- list ( $min, $max, $property, $parameters ) =
$this->parseConstraintParameters( $constraint );
+ list( $min, $max, $property, $parameters ) =
$this->parseConstraintParameters( $constraint );
// checks only the first occurrence of the referenced property
(this constraint implies a single value constraint on that property)
/** @var Statement $otherStatement */
diff --git a/src/ConstraintCheck/Helper/SparqlHelper.php
b/src/ConstraintCheck/Helper/SparqlHelper.php
index 54bf3f7..86e851b 100644
--- a/src/ConstraintCheck/Helper/SparqlHelper.php
+++ b/src/ConstraintCheck/Helper/SparqlHelper.php
@@ -220,7 +220,7 @@
$dataType =
$this->propertyDataTypeLookup->getDataTypeIdForProperty(
$snak->getPropertyId()
);
- list ( $value, $isFullValue ) = $this->getRdfLiteral(
$dataType, $dataValue );
+ list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType,
$dataValue );
if ( $isFullValue ) {
$prefix .= 'v';
}
--
To view, visit https://gerrit.wikimedia.org/r/405726
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id79298185cba92f66220ad0738552f478e7ca4a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE)
Gerrit-Reviewer: Thiemo Kreuz (WMDE)
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use list() without space before the parenthesis
Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405726 )
Change subject: Use list() without space before the parenthesis
..
Use list() without space before the parenthesis
The `list ()` variant will be forbidden once the underlying MediaWiki
ruleset is updated to 0.11.1 (part of wmde/WikibaseCodeSniffer#18,
expected to become wikibase/wikibase-codesniffer 0.3.0).
Change-Id: Id79298185cba92f66220ad0738552f478e7ca4a1
---
M src/ConstraintCheck/Checker/CommonsLinkChecker.php
M src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
M src/ConstraintCheck/Helper/SparqlHelper.php
3 files changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/26/405726/1
diff --git a/src/ConstraintCheck/Checker/CommonsLinkChecker.php
b/src/ConstraintCheck/Checker/CommonsLinkChecker.php
index 928e257..c091c23 100644
--- a/src/ConstraintCheck/Checker/CommonsLinkChecker.php
+++ b/src/ConstraintCheck/Checker/CommonsLinkChecker.php
@@ -146,7 +146,7 @@
if ( !$this->commonsLinkIsWellFormed( $commonsLink ) ) {
throw new MalformedTitleException(
'wbqc-violation-message-commons-link-not-well-formed', $commonsLink ); //
caught below
}
- list ( $defaultNamespace, $prefix ) =
$this->getCommonsNamespace( $namespace );
+ list( $defaultNamespace, $prefix ) =
$this->getCommonsNamespace( $namespace );
$title = $this->titleParser->parseTitle( $prefix .
$commonsLink, $defaultNamespace );
if ( $this->pageExists( $title ) ) {
$message = '';
diff --git a/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
b/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
index f516bbd..d1c74ca 100644
--- a/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
+++ b/src/ConstraintCheck/Checker/DiffWithinRangeChecker.php
@@ -159,7 +159,7 @@
$minuend = $snak->getDataValue();
/** @var PropertyId $property */
- list ( $min, $max, $property, $parameters ) =
$this->parseConstraintParameters( $constraint );
+ list( $min, $max, $property, $parameters ) =
$this->parseConstraintParameters( $constraint );
// checks only the first occurrence of the referenced property
(this constraint implies a single value constraint on that property)
/** @var Statement $otherStatement */
diff --git a/src/ConstraintCheck/Helper/SparqlHelper.php
b/src/ConstraintCheck/Helper/SparqlHelper.php
index 54bf3f7..86e851b 100644
--- a/src/ConstraintCheck/Helper/SparqlHelper.php
+++ b/src/ConstraintCheck/Helper/SparqlHelper.php
@@ -220,7 +220,7 @@
$dataType =
$this->propertyDataTypeLookup->getDataTypeIdForProperty(
$snak->getPropertyId()
);
- list ( $value, $isFullValue ) = $this->getRdfLiteral(
$dataType, $dataValue );
+ list( $value, $isFullValue ) = $this->getRdfLiteral( $dataType,
$dataValue );
if ( $isFullValue ) {
$prefix .= 'v';
}
--
To view, visit https://gerrit.wikimedia.org/r/405726
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id79298185cba92f66220ad0738552f478e7ca4a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE)
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
