[MediaWiki-commits] [Gerrit] [BrowserTest] Rename iframe to window_frame - change (mediawiki...VisualEditor)

2015-02-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: [BrowserTest] Rename iframe to window_frame
..


[BrowserTest] Rename iframe to window_frame

It's not an iframe anymore, so the name shouldn't be confusing.

Change-Id: Id93595d56d7d88871ab79ca91e1714d9a70fad17
---
M 
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
2 files changed, 23 insertions(+), 23 deletions(-)

Approvals:
  Zfilipin: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
 
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index 5836406..742a301 100644
--- 
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++ 
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -123,10 +123,10 @@
 end
 
 Then(/^I should see category dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element]
+[@current_page.window_frame_element]
   )
 end
 
@@ -221,31 +221,31 @@
 end
 
 Then(/^I should see Special character Insertion window$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 -2
   )
 end
 
 Then(/^I should see save changes dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 -2
   )
 end
 
 Then(/^I should see Page settings dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
 
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 0
   )
@@ -293,7 +293,7 @@
   on(VisualEditorPage).link_list_element.when_present(5).should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.link_list_element, @current_page.iframe_element, 
@current_page.new_link_element],
+[@current_page.link_list_element, @current_page.window_frame_element, 
@current_page.new_link_element],
 nil,
 0
   )
@@ -308,19 +308,19 @@
 end
 
 Then(/^I should see media editing dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element]
+[@current_page.window_frame_element]
   )
 end
 
 Then(/^I should see media caption dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
 
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 0
   )
@@ -328,15 +328,15 @@
   capture_screenshot(
 
"VisualEditor_Media_alternative_text-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
 [@current_page.media_alternative_block_element],
-@current_page.iframe_element
+@current_page.window_frame_element
   )
 end
 
 Then(/^I should see media advanced settings dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 0
   )
@@ -367,10 +367,10 @@
 end
 
 Then(/^I should see Basic Reference dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element]
+[@current_page.window_frame_element]
   )
 end
 
@@ -400,13 +400,13 @@
 
 Then(/^I should see the f

[MediaWiki-commits] [Gerrit] [BrowserTest] Rename iframe to window_frame - change (mediawiki...VisualEditor)

2015-01-28 Thread Amire80 (Code Review) 
Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/187099

Change subject: [BrowserTest] Rename iframe to window_frame
..

[BrowserTest] Rename iframe to window_frame

It's not an iframe anymore, so the name shouldn't be confusing.

Change-Id: Id93595d56d7d88871ab79ca91e1714d9a70fad17
---
M 
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
2 files changed, 23 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/99/187099/1

diff --git 
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
 
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index 5836406..742a301 100644
--- 
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++ 
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -123,10 +123,10 @@
 end
 
 Then(/^I should see category dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element]
+[@current_page.window_frame_element]
   )
 end
 
@@ -221,31 +221,31 @@
 end
 
 Then(/^I should see Special character Insertion window$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 -2
   )
 end
 
 Then(/^I should see save changes dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 -2
   )
 end
 
 Then(/^I should see Page settings dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
 
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 0
   )
@@ -293,7 +293,7 @@
   on(VisualEditorPage).link_list_element.when_present(5).should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.link_list_element, @current_page.iframe_element, 
@current_page.new_link_element],
+[@current_page.link_list_element, @current_page.window_frame_element, 
@current_page.new_link_element],
 nil,
 0
   )
@@ -308,19 +308,19 @@
 end
 
 Then(/^I should see media editing dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element]
+[@current_page.window_frame_element]
   )
 end
 
 Then(/^I should see media caption dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
 
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 0
   )
@@ -328,15 +328,15 @@
   capture_screenshot(
 
"VisualEditor_Media_alternative_text-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
 [@current_page.media_alternative_block_element],
-@current_page.iframe_element
+@current_page.window_frame_element
   )
 end
 
 Then(/^I should see media advanced settings dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element],
+[@current_page.window_frame_element],
 nil,
 0
   )
@@ -367,10 +367,10 @@
 end
 
 Then(/^I should see Basic Reference dialog box$/) do
-  on(VisualEditorPage).iframe_element.when_present.should be_visible
+  on(VisualEditorPage).window_frame_element.when_present.should be_visible
   capture_screenshot(
 "#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
-[@current_page.iframe_element]
+[@current_page.window_frame_element]
   )