[MediaWiki-commits] [Gerrit] Code style fixes to check_load_from_localstorage.js - change (mediawiki...Collection)

2015-03-31 Thread Cscott (Code Review) 
Cscott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/200921

Change subject: Code style fixes to check_load_from_localstorage.js
..

Code style fixes to check_load_from_localstorage.js

Change-Id: I697090cf9a68e53f3c241dfcff2240e89c7d1e78
---
M js/check_load_from_localstorage.js
1 file changed, 12 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/21/200921/1

diff --git a/js/check_load_from_localstorage.js 
b/js/check_load_from_localstorage.js
index 3822af3..342860f 100644
--- a/js/check_load_from_localstorage.js
+++ b/js/check_load_from_localstorage.js
@@ -1,33 +1,32 @@
 /*global confirm, collection_dialogtxt */
-(function($) {
+( function( $ ) {
 
 var script_url = mw.util.wikiScript();
 
-$(function() {
-   var c = $.jStorage.get('collection');
+$( function () {
+   var c = $.jStorage.get( 'collection' );
if (c) {
var num_pages = 0;
-   for (var i = 0; i  c.items.length; i++) {
-   if (c.items[i].type === 'article') {
+   for ( var i = 0; i  c.items.length; i++ ) {
+   if ( c.items[i].type === 'article' ) {
num_pages++;
}
}
-   if (num_pages) {
+   if ( num_pages ) {
var txt = collection_dialogtxt;
txt = txt.replace(/%TITLE%/, c.title ? '(' + c.title + 
')' : '');
txt = txt.replace(/%NUMPAGES%/, num_pages);
-   if (confirm(txt)) {
-   $.post(script_url, {
+   if ( confirm( txt ) ) {
+   $.post( script_url, {
'action': 'ajax',
'rs': 'wfAjaxPostCollection',
'rsargs[]': [JSON.stringify(c)]
-   }, function(result) {
+   }, function( result ) {
location.href = result.redirect_url;
-   }, 'json');
+   }, 'json' );
}
}
}
-});
- 
-})(jQuery);
+} );
 
+} )( jQuery );

-- 
To view, visit https://gerrit.wikimedia.org/r/200921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I697090cf9a68e53f3c241dfcff2240e89c7d1e78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Cscott canan...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Code style fixes to check_load_from_localstorage.js - change (mediawiki...Collection)

2015-03-31 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Code style fixes to check_load_from_localstorage.js
..


Code style fixes to check_load_from_localstorage.js

Change-Id: I697090cf9a68e53f3c241dfcff2240e89c7d1e78
---
M js/check_load_from_localstorage.js
1 file changed, 12 insertions(+), 13 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/js/check_load_from_localstorage.js 
b/js/check_load_from_localstorage.js
index 3822af3..342860f 100644
--- a/js/check_load_from_localstorage.js
+++ b/js/check_load_from_localstorage.js
@@ -1,33 +1,32 @@
 /*global confirm, collection_dialogtxt */
-(function($) {
+( function( $ ) {
 
 var script_url = mw.util.wikiScript();
 
-$(function() {
-   var c = $.jStorage.get('collection');
+$( function () {
+   var c = $.jStorage.get( 'collection' );
if (c) {
var num_pages = 0;
-   for (var i = 0; i  c.items.length; i++) {
-   if (c.items[i].type === 'article') {
+   for ( var i = 0; i  c.items.length; i++ ) {
+   if ( c.items[i].type === 'article' ) {
num_pages++;
}
}
-   if (num_pages) {
+   if ( num_pages ) {
var txt = collection_dialogtxt;
txt = txt.replace(/%TITLE%/, c.title ? '(' + c.title + 
')' : '');
txt = txt.replace(/%NUMPAGES%/, num_pages);
-   if (confirm(txt)) {
-   $.post(script_url, {
+   if ( confirm( txt ) ) {
+   $.post( script_url, {
'action': 'ajax',
'rs': 'wfAjaxPostCollection',
'rsargs[]': [JSON.stringify(c)]
-   }, function(result) {
+   }, function( result ) {
location.href = result.redirect_url;
-   }, 'json');
+   }, 'json' );
}
}
}
-});
- 
-})(jQuery);
+} );
 
+} )( jQuery );

-- 
To view, visit https://gerrit.wikimedia.org/r/200921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I697090cf9a68e53f3c241dfcff2240e89c7d1e78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Cscott canan...@wikimedia.org
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Arlolra abrea...@wikimedia.org
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits