[MediaWiki-commits] [Gerrit] Fix build - change (apps...wikipedia)

2015-04-03 Thread Fjalapeno (Code Review)
Fjalapeno has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/201749

Change subject: Fix build
..

Fix build

Workaround for fastlane bug : https://github.com/KrauseFx/fastlane/issues/176

Change-Id: I2151277940920e5a79bb64a4ab73a15f56af94df
---
M fastlane/Fastfile
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/49/201749/1

diff --git a/fastlane/Fastfile b/fastlane/Fastfile
index 2a40fce..1b3e0fe 100644
--- a/fastlane/Fastfile
+++ b/fastlane/Fastfile
@@ -57,6 +57,7 @@
   # Create and sign the IPA (and DSYM)
   ipa({
 scheme: 'Wikipedia Alpha',
+configuration: 'Alpha', #Prevents fastlane from passing --configuration 
Release - bug?
 clean: nil, # this means 'Do Clean'. Clean project before building.
 archive: nil, # this means 'Do Archive'. Archive project to the Xcode 
organizer after building.
 # verbose: nil, # this means 'Do Verbose'.
@@ -102,6 +103,7 @@
   # Create and sign the IPA (and DSYM)
   ipa({
 scheme: 'Wikipedia Beta',
+configuration: 'Beta', #Prevents fastlane from passing --configuration 
Release - bug?
 clean: true,
 archive: nil
   })

-- 
To view, visit https://gerrit.wikimedia.org/r/201749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2151277940920e5a79bb64a4ab73a15f56af94df
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno cfl...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix build - change (apps...wikipedia)

2015-04-03 Thread Mhurd (Code Review)
Mhurd has submitted this change and it was merged.

Change subject: Fix build
..


Fix build

Workaround for fastlane bug : https://github.com/KrauseFx/fastlane/issues/176

Change-Id: I2151277940920e5a79bb64a4ab73a15f56af94df
---
M fastlane/Fastfile
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Mhurd: Looks good to me, approved
  Bgerstle: Looks good to me, approved



diff --git a/fastlane/Fastfile b/fastlane/Fastfile
index 2a40fce..1b3e0fe 100644
--- a/fastlane/Fastfile
+++ b/fastlane/Fastfile
@@ -57,6 +57,7 @@
   # Create and sign the IPA (and DSYM)
   ipa({
 scheme: 'Wikipedia Alpha',
+configuration: 'Alpha', #Prevents fastlane from passing --configuration 
Release - bug?
 clean: nil, # this means 'Do Clean'. Clean project before building.
 archive: nil, # this means 'Do Archive'. Archive project to the Xcode 
organizer after building.
 # verbose: nil, # this means 'Do Verbose'.
@@ -102,6 +103,7 @@
   # Create and sign the IPA (and DSYM)
   ipa({
 scheme: 'Wikipedia Beta',
+configuration: 'Beta', #Prevents fastlane from passing --configuration 
Release - bug?
 clean: true,
 archive: nil
   })

-- 
To view, visit https://gerrit.wikimedia.org/r/201749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2151277940920e5a79bb64a4ab73a15f56af94df
Gerrit-PatchSet: 2
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno cfl...@wikimedia.org
Gerrit-Reviewer: Bgerstle bgers...@wikimedia.org
Gerrit-Reviewer: Dr0ptp4kt ab...@wikimedia.org
Gerrit-Reviewer: Mhurd mh...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix build - change (apps...wikipedia)

2015-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/185464

Change subject: Fix build
..

Fix build

Quote da single quote

Change-Id: Id0b2a9123ee7774670fcf3050b8ba8cf0a04962d
---
M wikipedia/res/values-qq/strings.xml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/64/185464/1

diff --git a/wikipedia/res/values-qq/strings.xml 
b/wikipedia/res/values-qq/strings.xml
index 9e18b89..6773c62 100644
--- a/wikipedia/res/values-qq/strings.xml
+++ b/wikipedia/res/values-qq/strings.xml
@@ -179,7 +179,7 @@
   string name=create_account_password_repeat_hint{{Identical|Repeat 
password}}/string
   string name=create_account_passwords_mismatch_error{{Identical|Passwords 
do not match}}/string
   string name=create_account_username_exists_errorUsed as error message on 
creating a user account where the username already exists./string
-  string name=create_account_ip_throttle_errorUsed as an error message on 
creating a user account where the user's IP has created too many accounts 
already and hit the account creation throttle./string
+  string name=create_account_ip_throttle_errorUsed as an error message on 
creating a user account where the user\'s IP has created too many accounts 
already and hit the account creation throttle./string
   string name=create_account_open_proxy_errorUsed as error message on 
creating a user account where the user is trying to create an account from a 
blocked open proxy./string
   string name=create_account_noname_errorUsed as an error message during 
account creation when the account creation failed because username that was 
provided is invalid./string
   string name=create_account_invalid_email_errorUsed as an error message 
during account creation when the account creation failed because the email that 
was provided is invalid./string

-- 
To view, visit https://gerrit.wikimedia.org/r/185464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0b2a9123ee7774670fcf3050b8ba8cf0a04962d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND bsitzm...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Fix build - change (apps...wikipedia)

2015-01-16 Thread Dbrant (Code Review)
Dbrant has submitted this change and it was merged.

Change subject: Fix build
..


Fix build

Quote da single quote

Change-Id: Id0b2a9123ee7774670fcf3050b8ba8cf0a04962d
---
M wikipedia/res/values-qq/strings.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dbrant: Looks good to me, approved



diff --git a/wikipedia/res/values-qq/strings.xml 
b/wikipedia/res/values-qq/strings.xml
index 9e18b89..6773c62 100644
--- a/wikipedia/res/values-qq/strings.xml
+++ b/wikipedia/res/values-qq/strings.xml
@@ -179,7 +179,7 @@
   string name=create_account_password_repeat_hint{{Identical|Repeat 
password}}/string
   string name=create_account_passwords_mismatch_error{{Identical|Passwords 
do not match}}/string
   string name=create_account_username_exists_errorUsed as error message on 
creating a user account where the username already exists./string
-  string name=create_account_ip_throttle_errorUsed as an error message on 
creating a user account where the user's IP has created too many accounts 
already and hit the account creation throttle./string
+  string name=create_account_ip_throttle_errorUsed as an error message on 
creating a user account where the user\'s IP has created too many accounts 
already and hit the account creation throttle./string
   string name=create_account_open_proxy_errorUsed as error message on 
creating a user account where the user is trying to create an account from a 
blocked open proxy./string
   string name=create_account_noname_errorUsed as an error message during 
account creation when the account creation failed because username that was 
provided is invalid./string
   string name=create_account_invalid_email_errorUsed as an error message 
during account creation when the account creation failed because the email that 
was provided is invalid./string

-- 
To view, visit https://gerrit.wikimedia.org/r/185464
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0b2a9123ee7774670fcf3050b8ba8cf0a04962d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND bsitzm...@wikimedia.org
Gerrit-Reviewer: Dbrant dbr...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits