[MediaWiki-commits] [Gerrit] Fix undefined variable - change (mediawiki...Flow)

2014-03-07 Thread EBernhardson (Code Review) 
EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/117623

Change subject: Fix undefined variable
..

Fix undefined variable

Change-Id: I695686e47f0fb56f52bf5e926530bf09e5ab288b
---
M includes/Formatter/RecentChanges.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/23/117623/1

diff --git a/includes/Formatter/RecentChanges.php 
b/includes/Formatter/RecentChanges.php
index cac2b94..089b2a4 100644
--- a/includes/Formatter/RecentChanges.php
+++ b/includes/Formatter/RecentChanges.php
@@ -82,7 +82,7 @@
if ( in_array( $changeData['action'], array( 'edit-post', 
'edit-header', 'edit-title' ) ) ) {
list( $href, $msg ) = $this-revisionDiffLink(
$title,
-   $workflow-getId(),
+   $workflowId,
$revision-getRevisionId(),
$revision-getPrevRevisionId()
);

-- 
To view, visit https://gerrit.wikimedia.org/r/117623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I695686e47f0fb56f52bf5e926530bf09e5ab288b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson ebernhard...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix undefined variable - change (mediawiki...Flow)

2014-03-07 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Fix undefined variable
..


Fix undefined variable

Change-Id: I695686e47f0fb56f52bf5e926530bf09e5ab288b
---
M includes/Formatter/RecentChanges.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Formatter/RecentChanges.php 
b/includes/Formatter/RecentChanges.php
index cac2b94..089b2a4 100644
--- a/includes/Formatter/RecentChanges.php
+++ b/includes/Formatter/RecentChanges.php
@@ -82,7 +82,7 @@
if ( in_array( $changeData['action'], array( 'edit-post', 
'edit-header', 'edit-title' ) ) ) {
list( $href, $msg ) = $this-revisionDiffLink(
$title,
-   $workflow-getId(),
+   $workflowId,
$revision-getRevisionId(),
$revision-getPrevRevisionId()
);

-- 
To view, visit https://gerrit.wikimedia.org/r/117623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I695686e47f0fb56f52bf5e926530bf09e5ab288b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson ebernhard...@wikimedia.org
Gerrit-Reviewer: Chad ch...@wikimedia.org
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Fix undefined variable - change (mediawiki...Flow)

2014-01-16 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/108002


Change subject: Fix undefined variable
..

Fix undefined variable

Change-Id: I633f0d507c569419458e18e5b64a339880bfa12c
---
M includes/Data/ObjectManager.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/02/108002/1

diff --git a/includes/Data/ObjectManager.php b/includes/Data/ObjectManager.php
index 3563682..6c9f306 100644
--- a/includes/Data/ObjectManager.php
+++ b/includes/Data/ObjectManager.php
@@ -756,7 +756,7 @@
} elseif ( $key === 'OFFSET' ) {
// OFFSET is just an integer
if ( ! is_numeric( $value ) ) {
-   wfDebug( __METHOD__.: non-numeric 
offset $offset\n );
+   wfDebug( __METHOD__.: non-numeric 
offset $value\n );
return false;
}
} elseif ( $key === 'GROUP BY' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/108002
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I633f0d507c569419458e18e5b64a339880bfa12c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits