[MediaWiki-commits] [Gerrit] Removing exception in case rev is null - change (mediawiki/core)

2013-05-06 Thread Kaldari (Code Review) 
Kaldari has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62556


Change subject: Removing exception in case rev is null
..

Removing exception in case rev is null

Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
---
M includes/User.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/56/62556/1

diff --git a/includes/User.php b/includes/User.php
index 9a0b768..d114b99 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1848,8 +1848,6 @@
) {
$newMessageRevision = 
$newMessageLinks[0]['rev'];
$newMessageRevisionId = 
$newMessageRevision-getId();
-   } else {
-   throw new MWException( Unexpected values from 
User::getNewMessageLinks() );
}
}
return $newMessageRevisionId;

-- 
To view, visit https://gerrit.wikimedia.org/r/62556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Kaldari rkald...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Removing exception in case rev is null - change (mediawiki/core)

2013-05-06 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Removing exception in case rev is null
..


Removing exception in case rev is null

Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
---
M includes/User.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Bsitu: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/User.php b/includes/User.php
index 9a0b768..d114b99 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1848,8 +1848,6 @@
) {
$newMessageRevision = 
$newMessageLinks[0]['rev'];
$newMessageRevisionId = 
$newMessageRevision-getId();
-   } else {
-   throw new MWException( Unexpected values from 
User::getNewMessageLinks() );
}
}
return $newMessageRevisionId;

-- 
To view, visit https://gerrit.wikimedia.org/r/62556
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Kaldari rkald...@wikimedia.org
Gerrit-Reviewer: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Removing exception in case rev is null - change (mediawiki/core)

2013-05-06 Thread Bsitu (Code Review) 
Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/62559


Change subject: Removing exception in case rev is null
..

Removing exception in case rev is null

Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
---
M includes/User.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/62559/1

diff --git a/includes/User.php b/includes/User.php
index 1ae1720..dbb3073 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1845,8 +1845,6 @@
if ( count( $newMessageLinks ) === 1  
$newMessageLinks[0]['wiki'] === wfWikiID() ) {
$newMessageRevision = 
$newMessageLinks[0]['rev'];
$newMessageRevisionId = 
$newMessageRevision-getId();
-   } else {
-   throw new MWException( Unexpected values from 
User::getNewMessageLinks() );
}
}
return $newMessageRevisionId;

-- 
To view, visit https://gerrit.wikimedia.org/r/62559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.22wmf3
Gerrit-Owner: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: Kaldari rkald...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Removing exception in case rev is null - change (mediawiki/core)

2013-05-06 Thread Bsitu (Code Review) 
Bsitu has submitted this change and it was merged.

Change subject: Removing exception in case rev is null
..


Removing exception in case rev is null

Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
---
M includes/User.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Bsitu: Verified; Looks good to me, approved



diff --git a/includes/User.php b/includes/User.php
index 1ae1720..dbb3073 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1845,8 +1845,6 @@
if ( count( $newMessageLinks ) === 1  
$newMessageLinks[0]['wiki'] === wfWikiID() ) {
$newMessageRevision = 
$newMessageLinks[0]['rev'];
$newMessageRevisionId = 
$newMessageRevision-getId();
-   } else {
-   throw new MWException( Unexpected values from 
User::getNewMessageLinks() );
}
}
return $newMessageRevisionId;

-- 
To view, visit https://gerrit.wikimedia.org/r/62559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2fe2961876dcdc9bde3bca9584fcbe2294629eba
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.22wmf3
Gerrit-Owner: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: Kaldari rkald...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits