Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315659

Change subject: build: run karma test with just "npm test"
......................................................................

build: run karma test with just "npm test"

Make npm install to also invoke "bower install". One less command to
enter/remember.
Add bower has a development dependency.
Introduce the "test" script which just invokes "karma start".

Usage:

 git clone
 npm install
 npm test

Note there is a jQuery version mismatch in the dependencies,filled as
T148020.

Bug: T148019
Change-Id: I3a737b979bff0e6578f10c687c91ce8a5d150591
---
M README.md
M package.json
2 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/dashiki 
refs/changes/59/315659/1

diff --git a/README.md b/README.md
index 2bfd401..5e1ae52 100644
--- a/README.md
+++ b/README.md
@@ -76,7 +76,7 @@
 ```
 
 # Tests
-We use karma to run tests
+We use karma with the Chromium webbrowser to run tests
 
 The way the karma installation works has changed with 0.12. It's documented 
here how to install it now:
 http://karma-runner.github.io/0.12/intro/installation.html. For global 
installation you'll need 
@@ -85,7 +85,13 @@
 
 To start running tests:
 ```
-karma start
+npm install
+npm test
+```
+Or:
+```
+npm install
+./node_modules/.bin/karma start
 ```
 
 # Deploy
diff --git a/package.json b/package.json
index fce3573..5a4e049 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,13 @@
 {
+  "private": true,
   "name": "dashiki",
   "version": "0.0.0",
+  "scripts": {
+    "postinstall": "bower install",
+    "test": "karma start"
+  },
   "devDependencies": {
+    "bower": "^1.7.9",
     "chalk": "~0.4.0",
     "cheerio": "^0.19.0",
     "deeply": "~0.1.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/315659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a737b979bff0e6578f10c687c91ce8a5d150591
Gerrit-PatchSet: 1
Gerrit-Project: analytics/dashiki
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to