[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove dead feed CardView code

2016-09-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Hygiene: remove dead feed CardView code
..


Hygiene: remove dead feed CardView code

Remove unused code in HorizontalScrollingListCardView.

Change-Id: I0feb7d5373594ab29735c655d52228adb8b926ff
---
M app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
M app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
2 files changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Dbrant: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
 
b/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
index 965d23a..914faa2 100644
--- 
a/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
+++ 
b/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
@@ -25,7 +25,6 @@
 
 public abstract class HorizontalScrollingListCardView extends CardView {
 @BindView(R.id.view_horizontal_scrolling_list_card_header) View headerView;
-@BindView(R.id.view_horizontal_scrolling_list_card_footer) View footerView;
 @BindView(R.id.view_horizontal_scrolling_list_card_list) RecyclerView 
recyclerView;
 
 @Nullable private FeedViewCallback callback;
@@ -56,11 +55,6 @@
 protected void header(@NonNull View view) {
 ViewUtil.replace(headerView, view);
 headerView = view;
-}
-
-protected void footer(@NonNull View view) {
-ViewUtil.replace(footerView, view);
-footerView = view;
 }
 
 @Nullable
diff --git a/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml 
b/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
index d3f082e..7285592 100644
--- a/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
+++ b/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
@@ -19,9 +19,4 @@
 android:layout_marginRight="12dp"
 android:clipChildren="false"/>
 
-
-
 
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/311631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0feb7d5373594ab29735c655d52228adb8b926ff
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Dbrant 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove dead feed CardView code

2016-09-19 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311631

Change subject: Hygiene: remove dead feed CardView code
..

Hygiene: remove dead feed CardView code

Remove unused code in HorizontalScrollingListCardView.

Change-Id: I0feb7d5373594ab29735c655d52228adb8b926ff
---
M app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
M app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
2 files changed, 0 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/31/311631/1

diff --git 
a/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
 
b/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
index 965d23a..914faa2 100644
--- 
a/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
+++ 
b/app/src/main/java/org/wikipedia/feed/view/HorizontalScrollingListCardView.java
@@ -25,7 +25,6 @@
 
 public abstract class HorizontalScrollingListCardView extends CardView {
 @BindView(R.id.view_horizontal_scrolling_list_card_header) View headerView;
-@BindView(R.id.view_horizontal_scrolling_list_card_footer) View footerView;
 @BindView(R.id.view_horizontal_scrolling_list_card_list) RecyclerView 
recyclerView;
 
 @Nullable private FeedViewCallback callback;
@@ -56,11 +55,6 @@
 protected void header(@NonNull View view) {
 ViewUtil.replace(headerView, view);
 headerView = view;
-}
-
-protected void footer(@NonNull View view) {
-ViewUtil.replace(footerView, view);
-footerView = view;
 }
 
 @Nullable
diff --git a/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml 
b/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
index d3f082e..7285592 100644
--- a/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
+++ b/app/src/main/res/layout/view_horizontal_scrolling_list_card.xml
@@ -19,9 +19,4 @@
 android:layout_marginRight="12dp"
 android:clipChildren="false"/>
 
-
-
 
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/311631
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0feb7d5373594ab29735c655d52228adb8b926ff
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits