Kaartic has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370804 )
Change subject: Show edit summary across multiple lines
......................................................................
Show edit summary across multiple lines
This allows users to read the long summaries as a whole instead
of having to scroll through the summary to read them which could
be hard, sometimes.
While at it, change the file's to be more appropriate.
Change-Id: Ia2af44bddeac7e8d653d5e7ebd5baf90049eea63
---
M app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
M app/src/main/res/layout/activity_edit_section.xml
R app/src/main/res/layout/fragment_preview_edit_summary.xml
3 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/04/370804/1
diff --git
a/app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
b/app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
index 6df478c..59f3722 100644
--- a/app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
+++ b/app/src/main/java/org/wikipedia/edit/summaries/EditSummaryFragment.java
@@ -27,7 +27,7 @@
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
- editSummaryContainer =
inflater.inflate(R.layout.fragment_preview_summary, container, false);
+ editSummaryContainer =
inflater.inflate(R.layout.fragment_preview_edit_summary, container, false);
summaryText = (AutoCompleteTextView)
editSummaryContainer.findViewById(R.id.edit_summary_edit);
// Explicitly enable standard dictionary autocompletion in the edit
summary box
diff --git a/app/src/main/res/layout/activity_edit_section.xml
b/app/src/main/res/layout/activity_edit_section.xml
index e6c42c5..fae51d6 100644
--- a/app/src/main/res/layout/activity_edit_section.xml
+++ b/app/src/main/res/layout/activity_edit_section.xml
@@ -54,7 +54,7 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
class="org.wikipedia.edit.summaries.EditSummaryFragment"
- tools:layout="@layout/fragment_preview_summary"/>
+ tools:layout="@layout/fragment_preview_edit_summary"/>
</LinearLayout>
<include layout="@layout/group_captcha" />
diff --git a/app/src/main/res/layout/fragment_preview_summary.xml
b/app/src/main/res/layout/fragment_preview_edit_summary.xml
similarity index 92%
rename from app/src/main/res/layout/fragment_preview_summary.xml
rename to app/src/main/res/layout/fragment_preview_edit_summary.xml
index d5ec923..21a437c 100644
--- a/app/src/main/res/layout/fragment_preview_summary.xml
+++ b/app/src/main/res/layout/fragment_preview_edit_summary.xml
@@ -24,8 +24,7 @@
android:paddingRight="16dp"
android:imeOptions="actionDone|flagNoExtractUi"
android:maxLength="255"
- android:textColor="?attr/edit_text_color"
- android:maxLines="1" />
+ android:textColor="?attr/edit_text_color" />
</android.support.design.widget.TextInputLayout>
</LinearLayout>
--
To view, visit https://gerrit.wikimedia.org/r/370804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2af44bddeac7e8d653d5e7ebd5baf90049eea63
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Kaartic <kaarticsivaraam91...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
