[MediaWiki-commits] [Gerrit] marvin[master]: Fix: escape start script wildcard

2017-08-10 Thread Jhernandez (Code Review) 
Jhernandez has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370799 )

Change subject: Fix: escape start script wildcard
..


Fix: escape start script wildcard

The package.json start script should escape its task wildcard argument
to forbid shell completion. Previously, when a file named `dev:foo`
existed, the following error occurred:

  ERROR: Task not found: "dev:foo"

Also, super minor formatting change to place `-s` arguments
consistently.

Change-Id: I724b29c82b5db50b0b3842bb9563c31361f909d8
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jhernandez: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index c838752..f7be2a2 100644
--- a/package.json
+++ b/package.json
@@ -3,11 +3,11 @@
   "version": "0.0.0",
   "description": "An API driven skin for MediaWiki",
   "scripts": {
-"start": "run-p -sn dev:*",
+"start": "run-p -sn dev:\\*",
 "dev:client": "NODE_ENV=development webpack -w",
 "dev:server": "NODE_ENV=development nodemon -w dist/client -w src/server/ 
src/server/index.js",
 "prod:build": "NODE_ENV=production webpack -p",
-"format": "npm run -s lint -- --fix",
+"format": "npm run lint -s -- --fix",
 "format:all": "npm run format -s -- '{src,test}/**/*.js'",
 "lint": "eslint --cache --max-warnings 0",
 "lint:all": "npm run lint -s -- '{src,test}/**/*.js'",

-- 
To view, visit https://gerrit.wikimedia.org/r/370799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I724b29c82b5db50b0b3842bb9563c31361f909d8
Gerrit-PatchSet: 2
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] marvin[master]: Fix: escape start script wildcard

2017-08-09 Thread Niedzielski (Code Review) 
Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370799 )

Change subject: Fix: escape start script wildcard
..

Fix: escape start script wildcard

The package.json start script should escape its task wildcard argument
to forbid shell completion. Previously, when a file named `dev:foo`
existed, the following error occurred:

  ERROR: Task not found: "dev:foo"

Change-Id: I724b29c82b5db50b0b3842bb9563c31361f909d8
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/marvin refs/changes/99/370799/1

diff --git a/package.json b/package.json
index 956d5d0..8aaebbb 100644
--- a/package.json
+++ b/package.json
@@ -3,7 +3,7 @@
   "version": "0.0.0",
   "description": "An API driven skin for MediaWiki",
   "scripts": {
-"start": "run-p -n dev:*",
+"start": "run-p -n dev:\\*",
 "dev:client": "NODE_ENV=development webpack -w",
 "dev:server": "NODE_ENV=development nodemon -w dist/client -w src/server/ 
src/server/index.js",
 "prod:build": "NODE_ENV=production webpack -p",

-- 
To view, visit https://gerrit.wikimedia.org/r/370799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I724b29c82b5db50b0b3842bb9563c31361f909d8
Gerrit-PatchSet: 1
Gerrit-Project: marvin
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits