[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Force User::__toString() return value to be string

2016-10-18 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged.

Change subject: Force User::__toString() return value to be string
..


Force User::__toString() return value to be string

Bug: T148486
Change-Id: I19f483b16c99d05f4d1626ee89ba1cfb7a78d52b
(cherry picked from commit c21f49aec738fcdc4bc6d5779accd8f2f53c49fe)
---
M includes/user/User.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/user/User.php b/includes/user/User.php
index 240b8ce..75d5581 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -325,7 +325,7 @@
 * @return string
 */
public function __toString() {
-   return $this->getName();
+   return (string)$this->getName();
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/316729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19f483b16c99d05f4d1626ee89ba1cfb7a78d52b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_27]: Force User::__toString() return value to be string

2016-10-18 Thread Code Review
Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316729

Change subject: Force User::__toString() return value to be string
..

Force User::__toString() return value to be string

Bug: T148486
Change-Id: I19f483b16c99d05f4d1626ee89ba1cfb7a78d52b
(cherry picked from commit c21f49aec738fcdc4bc6d5779accd8f2f53c49fe)
---
M includes/user/User.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/29/316729/1

diff --git a/includes/user/User.php b/includes/user/User.php
index 240b8ce..75d5581 100644
--- a/includes/user/User.php
+++ b/includes/user/User.php
@@ -325,7 +325,7 @@
 * @return string
 */
public function __toString() {
-   return $this->getName();
+   return (string)$this->getName();
}
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/316729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19f483b16c99d05f4d1626ee89ba1cfb7a78d52b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits