[MediaWiki-commits] [Gerrit] mediawiki/core[master]: MultiHttpClient: Don't use wfArrayToCgi()

2016-09-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: MultiHttpClient: Don't use wfArrayToCgi()
..


MultiHttpClient: Don't use wfArrayToCgi()

http_build_query() should be functionally identical.

Change-Id: Ia7d909e97a89d66dbe5187e9a0423e2ecf8561e8
---
M includes/libs/MultiHttpClient.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/libs/MultiHttpClient.php 
b/includes/libs/MultiHttpClient.php
index 320a0b6..fdcbf49 100644
--- a/includes/libs/MultiHttpClient.php
+++ b/includes/libs/MultiHttpClient.php
@@ -351,7 +351,7 @@
// In PHP 5.2 and later, '@' is interpreted as 
a file upload if POSTFIELDS
// is an array, but not if it's a string. So 
convert $req['body'] to a string
// for safety.
-   $req['body'] = wfArrayToCgi( $req['body'] );
+   $req['body'] = http_build_query( $req['body'] );
}
curl_setopt( $ch, CURLOPT_POSTFIELDS, $req['body'] );
} else {

-- 
To view, visit https://gerrit.wikimedia.org/r/311922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7d909e97a89d66dbe5187e9a0423e2ecf8561e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: MultiHttpClient: Don't use wfArrayToCgi()

2016-09-21 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311922

Change subject: MultiHttpClient: Don't use wfArrayToCgi()
..

MultiHttpClient: Don't use wfArrayToCgi()

http_build_query() should be functionally identical.

Change-Id: Ia7d909e97a89d66dbe5187e9a0423e2ecf8561e8
---
M includes/libs/MultiHttpClient.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/22/311922/1

diff --git a/includes/libs/MultiHttpClient.php 
b/includes/libs/MultiHttpClient.php
index 320a0b6..fdcbf49 100644
--- a/includes/libs/MultiHttpClient.php
+++ b/includes/libs/MultiHttpClient.php
@@ -351,7 +351,7 @@
// In PHP 5.2 and later, '@' is interpreted as 
a file upload if POSTFIELDS
// is an array, but not if it's a string. So 
convert $req['body'] to a string
// for safety.
-   $req['body'] = wfArrayToCgi( $req['body'] );
+   $req['body'] = http_build_query( $req['body'] );
}
curl_setopt( $ch, CURLOPT_POSTFIELDS, $req['body'] );
} else {

-- 
To view, visit https://gerrit.wikimedia.org/r/311922
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7d909e97a89d66dbe5187e9a0423e2ecf8561e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits