[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Clarify phpdoc of DatabaseUpdater::addExtensionUpdate

2016-10-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Clarify phpdoc of DatabaseUpdater::addExtensionUpdate
..


Clarify phpdoc of DatabaseUpdater::addExtensionUpdate

Change-Id: Ibc9951e70b8388f5c23c3e05e31e20bd037beacb
---
M includes/installer/DatabaseUpdater.php
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Gergő Tisza: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/installer/DatabaseUpdater.php 
b/includes/installer/DatabaseUpdater.php
index 6f066ce..6a702e9 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -222,12 +222,11 @@
 *
 * @since 1.17
 *
-* @param array $update The update to run. Format is the following:
-*first item is the callback function, it also can be a
-*simple string with the name of a function in this 
class,
-*following elements are parameters to the function.
-*Note that callback functions will receive this object 
as
-*first parameter.
+* @param array $update The update to run. Format is [ $callback, 
$params... ]
+*   $callback is the method to call; either a DatabaseUpdater method 
name or a callable.
+*   Must be serializable (ie. no anonymous functions allowed). The 
rest of the parameters
+*   (if any) will be passed to the callback. The first parameter 
passed to the callback
+*   is always this object.
 */
public function addExtensionUpdate( array $update ) {
$this->extensionUpdates[] = $update;

-- 
To view, visit https://gerrit.wikimedia.org/r/316513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc9951e70b8388f5c23c3e05e31e20bd037beacb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Clarify phpdoc of DatabaseUpdater::addExtensionUpdate

2016-10-17 Thread Code Review 
Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316513

Change subject: Clarify phpdoc of DatabaseUpdater::addExtensionUpdate
..

Clarify phpdoc of DatabaseUpdater::addExtensionUpdate

Change-Id: Ibc9951e70b8388f5c23c3e05e31e20bd037beacb
---
M includes/installer/DatabaseUpdater.php
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/13/316513/1

diff --git a/includes/installer/DatabaseUpdater.php 
b/includes/installer/DatabaseUpdater.php
index 6f066ce..6a702e9 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -222,12 +222,11 @@
 *
 * @since 1.17
 *
-* @param array $update The update to run. Format is the following:
-*first item is the callback function, it also can be a
-*simple string with the name of a function in this 
class,
-*following elements are parameters to the function.
-*Note that callback functions will receive this object 
as
-*first parameter.
+* @param array $update The update to run. Format is [ $callback, 
$params... ]
+*   $callback is the method to call; either a DatabaseUpdater method 
name or a callable.
+*   Must be serializable (ie. no anonymous functions allowed). The 
rest of the parameters
+*   (if any) will be passed to the callback. The first parameter 
passed to the callback
+*   is always this object.
 */
public function addExtensionUpdate( array $update ) {
$this->extensionUpdates[] = $update;

-- 
To view, visit https://gerrit.wikimedia.org/r/316513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc9951e70b8388f5c23c3e05e31e20bd037beacb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits