Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371585 )
Change subject: Remove passed FunctionComment.SpacingAfter from phpcs.xml
......................................................................
Remove passed FunctionComment.SpacingAfter from phpcs.xml
After fix of the other MediaWiki.Commenting.FunctionComment sniffs the
SpacingAfter now passed, because it allows to align the variables
Change-Id: If5b0bd16028761abc2c47ace9e97d37ad14bb36f
---
M phpcs.xml
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/85/371585/1
diff --git a/phpcs.xml b/phpcs.xml
index 2831a2b..ad3b334 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,13 +2,9 @@
<ruleset name="MediaWiki">
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="Generic.ControlStructures.InlineControlStructure" />
- <!-- Disable rules added in 0.8.0 that don't pass yet -->
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude
name="MediaWiki.Commenting.FunctionComment.Missing.Protected" />
<exclude
name="MediaWiki.Commenting.FunctionComment.Missing.Public" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.SpacingAfter" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.SpacingAfterParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.SpacingAfterParamType" />
<exclude
name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentStart"
/>
<exclude
name="MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentEnd"
/>
<exclude
name="MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures"
/>
--
To view, visit https://gerrit.wikimedia.org/r/371585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5b0bd16028761abc2c47ace9e97d37ad14bb36f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
