[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused DatabaseBase::debug() method

2016-09-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused DatabaseBase::debug() method
..


Remove unused DatabaseBase::debug() method

This just trivially wrapped getFlags()/setFlags() anyway

Change-Id: Iab5b508f6746098b66da00c8bf038215cb2359ef
---
M includes/libs/rdbms/database/DatabaseBase.php
1 file changed, 0 insertions(+), 19 deletions(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/libs/rdbms/database/DatabaseBase.php 
b/includes/libs/rdbms/database/DatabaseBase.php
index ef72998..e008705 100644
--- a/includes/libs/rdbms/database/DatabaseBase.php
+++ b/includes/libs/rdbms/database/DatabaseBase.php
@@ -30,25 +30,6 @@
  */
 abstract class DatabaseBase extends Database {
/**
-* Boolean, controls output of large amounts of debug information.
-* @param bool|null $debug
-*   - true to enable debugging
-*   - false to disable debugging
-*   - omitted or null to do nothing
-*
-* @return bool Previous value of the flag
-* @deprecated since 1.28; use setFlag()
-*/
-   public function debug( $debug = null ) {
-   $res = $this->getFlag( DBO_DEBUG );
-   if ( $debug !== null ) {
-   $debug ? $this->setFlag( DBO_DEBUG ) : 
$this->clearFlag( DBO_DEBUG );
-   }
-
-   return $res;
-   }
-
-   /**
 * Get search engine class. All subclasses of this need to implement 
this
 * if they wish to use searching.
 *

-- 
To view, visit https://gerrit.wikimedia.org/r/311601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab5b508f6746098b66da00c8bf038215cb2359ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused DatabaseBase::debug() method

2016-09-19 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311601

Change subject: Remove unused DatabaseBase::debug() method
..

Remove unused DatabaseBase::debug() method

This just trivially wrapped getFlags()/setFlags() anyway

Change-Id: Iab5b508f6746098b66da00c8bf038215cb2359ef
---
M includes/libs/rdbms/database/DatabaseBase.php
1 file changed, 0 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/01/311601/1

diff --git a/includes/libs/rdbms/database/DatabaseBase.php 
b/includes/libs/rdbms/database/DatabaseBase.php
index ef72998..e008705 100644
--- a/includes/libs/rdbms/database/DatabaseBase.php
+++ b/includes/libs/rdbms/database/DatabaseBase.php
@@ -30,25 +30,6 @@
  */
 abstract class DatabaseBase extends Database {
/**
-* Boolean, controls output of large amounts of debug information.
-* @param bool|null $debug
-*   - true to enable debugging
-*   - false to disable debugging
-*   - omitted or null to do nothing
-*
-* @return bool Previous value of the flag
-* @deprecated since 1.28; use setFlag()
-*/
-   public function debug( $debug = null ) {
-   $res = $this->getFlag( DBO_DEBUG );
-   if ( $debug !== null ) {
-   $debug ? $this->setFlag( DBO_DEBUG ) : 
$this->clearFlag( DBO_DEBUG );
-   }
-
-   return $res;
-   }
-
-   /**
 * Get search engine class. All subclasses of this need to implement 
this
 * if they wish to use searching.
 *

-- 
To view, visit https://gerrit.wikimedia.org/r/311601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab5b508f6746098b66da00c8bf038215cb2359ef
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits