jenkins-bot has submitted this change and it was merged. Change subject: Remove all Ruby code ......................................................................
Remove all Ruby code The only Ruby code were Selenium tests. There broken and not needed now. Bug: T145792 Change-Id: I7c76bd0825e8cb2cfa251327f0d2c4f634a54eef Depends-On: I21717c19f87ed99d200bc204fd4cb17e2e557541 --- D .rubocop.yml D .rubocop_todo.yml D Gemfile D Gemfile.lock D tests/browser/features/aftv5.feature D tests/browser/features/step_definitions/aftv5_steps.rb D tests/browser/features/support/env.rb D tests/browser/features/support/pages/aftv5_page.rb 8 files changed, 0 insertions(+), 301 deletions(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/.rubocop.yml b/.rubocop.yml deleted file mode 100644 index cc32da4..0000000 --- a/.rubocop.yml +++ /dev/null @@ -1 +0,0 @@ -inherit_from: .rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml deleted file mode 100644 index f7c54cf..0000000 --- a/.rubocop_todo.yml +++ /dev/null @@ -1,22 +0,0 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2014-10-20 17:19:56 +0200 using RuboCop version 0.26.1. -# The point is for the user to remove these configuration records -# one by one as the offenses are removed from the code base. -# Note that changes in the inspected code, or installation of new -# versions of RuboCop, may require this file to be generated again. - -# Offense count: 5 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 158 - -# Offense count: 1 -# Cop supports --auto-correct. -Style/SpaceInsideRangeLiteral: - Enabled: false - -# Offense count: 27 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiterals: - Enabled: false diff --git a/Gemfile b/Gemfile deleted file mode 100755 index 94c4b18..0000000 --- a/Gemfile +++ /dev/null @@ -1,7 +0,0 @@ -# ruby=ruby-2.1.1 -# ruby-gemset=browsertests - -source "https://rubygems.org"; - -gem "mediawiki_selenium" -gem "rubocop", require: false diff --git a/Gemfile.lock b/Gemfile.lock deleted file mode 100644 index 78ae3c8..0000000 --- a/Gemfile.lock +++ /dev/null @@ -1,81 +0,0 @@ -GEM - remote: https://rubygems.org/ - specs: - ast (2.0.0) - astrolabe (1.3.0) - parser (>= 2.2.0.pre.3, < 3.0) - builder (3.2.2) - childprocess (0.5.2) - ffi (~> 1.0, >= 1.0.11) - cucumber (1.3.14) - builder (>= 2.1.2) - diff-lcs (>= 1.1.3) - gherkin (~> 2.12) - multi_json (>= 1.7.5, < 2.0) - multi_test (>= 0.1.1) - data_magic (0.18) - faker (>= 1.1.2) - yml_reader (>= 0.2) - diff-lcs (1.2.5) - faker (1.3.0) - i18n (~> 0.5) - ffi (1.9.3) - gherkin (2.12.2) - multi_json (~> 1.3) - headless (1.0.1) - i18n (0.6.9) - json (1.8.1) - mediawiki_selenium (0.2.20) - cucumber (~> 1.3, >= 1.3.10) - headless (~> 1.0, >= 1.0.1) - json (~> 1.8, >= 1.8.1) - net-http-persistent (~> 2.9, >= 2.9.1) - page-object (~> 0.9, >= 0.9.5) - rest-client (~> 1.6, >= 1.6.7) - rspec-expectations (~> 2.14, >= 2.14.4) - syntax (~> 1.2, >= 1.2.0) - mime-types (2.2) - multi_json (1.9.2) - multi_test (0.1.1) - net-http-persistent (2.9.4) - page-object (0.9.8) - page_navigation (>= 0.9) - selenium-webdriver (>= 2.40.0) - watir-webdriver (>= 0.6.8) - page_navigation (0.9) - data_magic (>= 0.14) - parser (2.2.0.pre.4) - ast (>= 1.1, < 3.0) - slop (~> 3.4, >= 3.4.5) - powerpack (0.0.9) - rainbow (2.0.0) - rest-client (1.6.7) - mime-types (>= 1.16) - rspec-expectations (2.14.5) - diff-lcs (>= 1.1.3, < 2.0) - rubocop (0.26.1) - astrolabe (~> 1.3) - parser (>= 2.2.0.pre.4, < 3.0) - powerpack (~> 0.0.6) - rainbow (>= 1.99.1, < 3.0) - ruby-progressbar (~> 1.4) - ruby-progressbar (1.6.0) - rubyzip (1.1.3) - selenium-webdriver (2.41.0) - childprocess (>= 0.5.0) - multi_json (~> 1.0) - rubyzip (~> 1.0) - websocket (~> 1.0.4) - slop (3.6.0) - syntax (1.2.0) - watir-webdriver (0.6.9) - selenium-webdriver (>= 2.18.0) - websocket (1.0.7) - yml_reader (0.2) - -PLATFORMS - ruby - -DEPENDENCIES - mediawiki_selenium - rubocop diff --git a/tests/browser/features/aftv5.feature b/tests/browser/features/aftv5.feature deleted file mode 100644 index 3ad7e50..0000000 --- a/tests/browser/features/aftv5.feature +++ /dev/null @@ -1,36 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -# See http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Platforms for internet_explorer_6 -@chrome @firefox @internet_explorer_7 @internet_explorer_8 @internet_explorer_9 @internet_explorer_10 @phantomjs -Feature: AFTv5 - - Background: - Given I am at an AFTv5 page - - Scenario: Check if AFTv5 is on the page - Then AFTv5 should be there - - Scenario: Click Yes return and click No - When I click Yes and No - Then I can always return to AFTv5 input - - Scenario: Check Whats this with Learn more - When I click Whats this - Then I see a floating text window with Learn more link - - Scenario: Click yes and see feedback guide and terms - When I click Yes - Then I see helpful feedback guide and terms - - Scenario: Click yes and leave feedback - When I click Yes - Then I can enter and save text diff --git a/tests/browser/features/step_definitions/aftv5_steps.rb b/tests/browser/features/step_definitions/aftv5_steps.rb deleted file mode 100644 index b5b3c32..0000000 --- a/tests/browser/features/step_definitions/aftv5_steps.rb +++ /dev/null @@ -1,103 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -Given(/^I am at an AFTv5 page$/) do - visit AFTv5Page -end - -When(/^I click Whats this$/) do - on(AFTv5Page) do |page| - page.whats_this_element.when_present.click - end -end -When(/^I click Yes$/) do - on(AFTv5Page) do |page| - page.yes_element.when_present.click - end -end -When(/^I click Yes and No$/) do - on(AFTv5Page) do |page| - page.yes_element.exists? - page.yes_element.when_present.click - page.back_to_yesno - page.no_element.when_present.click - page.back_to_yesno - end -end - -Then(/^AFTv5 should be there$/) do - on(AFTv5Page) do |page| - page.yes_element.when_present.should be_visible - page.no_element.when_present.should be_visible - page.whats_this_element.when_present.should be_visible - end -end -Then(/^After saving I have links to feedback page and See all comments available$/) do - on(AFTv5Page) do |page| - page.feedback_page_element.when_present.click - page.all_comments_element.should be_true - end -end -Then(/^Comments are shown Relevant and All and Sort By$/) do - on(AFTv5Page) do |page| - page.most_relevant.should be_true - page.sort_by_element.should be_true - end -end -Then(/^I can always return to AFTv5 input$/) do - on(AFTv5Page) do |page| - page.yes_element.should be_true - page.no_element.should be_true - end -end -Then(/^I can enter and save text$/) do - on(AFTv5Page) do |page| - @input_string = "Automated test did this #{('a' .. 'z').to_a.shuffle[0, 10].join}" - page.input_area_element.send_keys "Hello from #{@input_string}" - page.post_feedback_element.when_present.click - page.wait_until(10) do - page.text.include? "Thanks!" - end - page.text.should include "Your post can be viewed on this feedback page." - # ONLY ANONS GET "CREATE ACCOUNT"/LOG IN MESSAGE - page.create_account_element.should be_true - page.log_in_element.should be_true - end -end -Then(/^I have links to Learn more and View Article$/) do - on(AFTv5Page) do |page| - page.learn_more_element.should be_true - page.view_article_element.should be_true - end -end -Then(/^I see a floating text window with Learn more link$/) do - on(AFTv5Page) do |page| - page.text.should include "Wikipedia would like to hear what you think of this article. Share your feedback with the editors -- and help improve this page" - page.learn_more_element.should be_true - end -end -Then(/^I see helpful feedback guide and terms$/) do - on(AFTv5Page) do |page| - page.helpful_feedback_element.should be_true - page.terms_element.should be_true - end -end -Then(/^When I click to navigate to comments page my saved comment appears$/) do - on(AFTv5Page) do |page| - page.wait_until(10) do - page.all_comments_element.visible? - end - page.all_comments_element.when_present.click - page.wait_until(10) do - page.text.include? @input_string - end - end -end diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb deleted file mode 100644 index 515ff78..0000000 --- a/tests/browser/features/support/env.rb +++ /dev/null @@ -1,12 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -require "mediawiki_selenium" diff --git a/tests/browser/features/support/pages/aftv5_page.rb b/tests/browser/features/support/pages/aftv5_page.rb deleted file mode 100644 index de57316..0000000 --- a/tests/browser/features/support/pages/aftv5_page.rb +++ /dev/null @@ -1,39 +0,0 @@ -# -# This file is subject to the license terms in the LICENSE file found in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/LICENSE. No part of -# qa-browsertests, including this file, may be copied, modified, propagated, or -# distributed except according to the terms contained in the LICENSE file. -# -# Copyright 2012-2014 by the Mediawiki developers. See the CREDITS file in the -# qa-browsertests top-level directory and at -# https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS -# -require "page-object" - -# AFTv5 page object -class AFTv5Page - include PageObject - - include URL - page_url URL.url("Aftpage") - - div(:aft_box, id: "mw-articlefeedbackv5") - a(:all_comments, text: /All comments/) - a(:back_to_yesno, text: "Back to step 1") - span(:create_account, text: "Create an account") - a(:edit, text: "Edit source") - a(:feedback_page, text: "feedback page") - a(:helpful_feedback, href: "http://en.wikipedia.org/wiki/Wikipedia:Feedback_guidelines";, text: "helpful feedback") - text_area(:input_area, id: "articleFeedbackv5-find-feedback") - a(:learn_more, text: /Learn more/) - a(:log_in, text: "Log in") - a(:most_relevant, text: /Most relevant/) - span(:no, text: "No") - span(:post_feedback, text: "Post your feedback") - select(:sort_by, id: "articleFeedbackv5-sort-select") - a(:terms, href: "//wikimediafoundation.org/wiki/Feedback_privacy_statement", text: "terms") - a(:view_article, text: "View article") - a(:whats_this, text: "What's this?") - span(:yes, text: "Yes") -end -- To view, visit https://gerrit.wikimedia.org/r/310572 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c76bd0825e8cb2cfa251327f0d2c4f634a54eef Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
