[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Better explode() for CargoLuaLibrary

2016-09-18 Thread Yaron Koren (Code Review) 
Yaron Koren has submitted this change and it was merged.

Change subject: Better explode() for CargoLuaLibrary
..


Better explode() for CargoLuaLibrary

Change-Id: Id2956fdb30279275ecab18094f04537ac1c41169
---
M CargoLua.library.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/CargoLua.library.php b/CargoLua.library.php
index b480283..3bf4644 100644
--- a/CargoLua.library.php
+++ b/CargoLua.library.php
@@ -51,7 +51,7 @@
 
$result = array();
 
-   $fieldArray = array_map( 'trim', explode( ',', $fields ) );
+   $fieldArray = CargoUtils::smartSplit( ',', $fields );
 
$rowIndex = 1; // because Lua arrays start at 1
foreach ( $rows as $row ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/311361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id2956fdb30279275ecab18094f04537ac1c41169
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Better explode() for CargoLuaLibrary

2016-09-18 Thread Yaron Koren (Code Review) 
Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311361

Change subject: Better explode() for CargoLuaLibrary
..

Better explode() for CargoLuaLibrary

Change-Id: Id2956fdb30279275ecab18094f04537ac1c41169
---
M CargoLua.library.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/61/311361/2

diff --git a/CargoLua.library.php b/CargoLua.library.php
index b480283..3bf4644 100644
--- a/CargoLua.library.php
+++ b/CargoLua.library.php
@@ -51,7 +51,7 @@
 
$result = array();
 
-   $fieldArray = array_map( 'trim', explode( ',', $fields ) );
+   $fieldArray = CargoUtils::smartSplit( ',', $fields );
 
$rowIndex = 1; // because Lua arrays start at 1
foreach ( $rows as $row ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/311361
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id2956fdb30279275ecab18094f04537ac1c41169
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits