[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Further removal of Date handling from getAllOrValues()

[Yaron Koren (Code Review)]

Yaron Koren has submitted this change and it was merged.

Change subject: Further removal of Date handling from getAllOrValues()
..


Further removal of Date handling from getAllOrValues()

Change-Id: I33a241a192a16fd9265bd5f5b5e61ead9021f3a0
---
M drilldown/CargoAppliedFilter.php
1 file changed, 1 insertion(+), 7 deletions(-)

Approvals:
  Yaron Koren: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/drilldown/CargoAppliedFilter.php b/drilldown/CargoAppliedFilter.php
index ab00fd2..b7902f5 100644
--- a/drilldown/CargoAppliedFilter.php
+++ b/drilldown/CargoAppliedFilter.php
@@ -158,13 +158,7 @@
$cdb = CargoUtils::getDB();
$res = $cdb->select( $tableName, "DISTINCT " . $value_field );
while ( $row = $cdb->fetchRow( $res ) ) {
-   if ( $this->filter->fieldDescription->mType == 'Date' &&
-   $this->filter->getTimePeriod() == 'month' ) {
-   $value_string = 
CargoDrilldownUtils::monthToString( $row[1] ) . " " . $row[0];
-   } else {
-   $value_string = $row[0];
-   }
-   $possible_values[] = $value_string;
+   $possible_values[] = $row[0];
}
$cdb->freeResult( $res );
return $possible_values;

-- 
To view, visit https://gerrit.wikimedia.org/r/316370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I33a241a192a16fd9265bd5f5b5e61ead9021f3a0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Further removal of Date handling from getAllOrValues()

[Yaron Koren (Code Review)]

Yaron Koren has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316370

Change subject: Further removal of Date handling from getAllOrValues()
..

Further removal of Date handling from getAllOrValues()

Change-Id: I33a241a192a16fd9265bd5f5b5e61ead9021f3a0
---
M drilldown/CargoAppliedFilter.php
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/70/316370/2

diff --git a/drilldown/CargoAppliedFilter.php b/drilldown/CargoAppliedFilter.php
index ab00fd2..b7902f5 100644
--- a/drilldown/CargoAppliedFilter.php
+++ b/drilldown/CargoAppliedFilter.php
@@ -158,13 +158,7 @@
$cdb = CargoUtils::getDB();
$res = $cdb->select( $tableName, "DISTINCT " . $value_field );
while ( $row = $cdb->fetchRow( $res ) ) {
-   if ( $this->filter->fieldDescription->mType == 'Date' &&
-   $this->filter->getTimePeriod() == 'month' ) {
-   $value_string = 
CargoDrilldownUtils::monthToString( $row[1] ) . " " . $row[0];
-   } else {
-   $value_string = $row[0];
-   }
-   $possible_values[] = $value_string;
+   $possible_values[] = $row[0];
}
$cdb->freeResult( $res );
return $possible_values;

-- 
To view, visit https://gerrit.wikimedia.org/r/316370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33a241a192a16fd9265bd5f5b5e61ead9021f3a0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Cargo
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits