[MediaWiki-commits] [Gerrit] mediawiki...CleanChanges[master]: Do not load ext.cleanchanges.uls unnecessarily

2016-10-20 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Do not load ext.cleanchanges.uls unnecessarily
..


Do not load ext.cleanchanges.uls unnecessarily

Bug: T146476
Change-Id: Idb3ae1d29b8267891e9d00b7cb6f8603b9b5ef76
---
M CleanChanges_body.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  KartikMistry: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/CleanChanges_body.php b/CleanChanges_body.php
index 053dfea..1cc51c0 100644
--- a/CleanChanges_body.php
+++ b/CleanChanges_body.php
@@ -8,9 +8,11 @@
 * Determines which version of changes list to provide, or none.
 */
public static function hook( User $user, Skin $skin, &$list ) {
+   global $wgCCTrailerFilter;
+
$list = null;
 
-   if ( defined( 'ULS_VERSION' ) ) {
+   if ( $wgCCTrailerFilter && defined( 'ULS_VERSION' ) ) {
$skin->getOutput()->addModules( 'ext.cleanchanges.uls' 
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/315646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb3ae1d29b8267891e9d00b7cb6f8603b9b5ef76
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CleanChanges
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: KartikMistry 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CleanChanges[master]: Do not load ext.cleanchanges.uls unnecessarily

2016-10-13 Thread Nikerabbit (Code Review) 
Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315646

Change subject: Do not load ext.cleanchanges.uls unnecessarily
..

Do not load ext.cleanchanges.uls unnecessarily

Bug: T146476
Change-Id: Idb3ae1d29b8267891e9d00b7cb6f8603b9b5ef76
---
M CleanChanges_body.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CleanChanges 
refs/changes/46/315646/1

diff --git a/CleanChanges_body.php b/CleanChanges_body.php
index 053dfea..8462b48 100644
--- a/CleanChanges_body.php
+++ b/CleanChanges_body.php
@@ -8,9 +8,12 @@
 * Determines which version of changes list to provide, or none.
 */
public static function hook( User $user, Skin $skin, &$list ) {
+   global $wgCCTrailerFilter;
+
$list = null;
 
-   if ( defined( 'ULS_VERSION' ) ) {
+
+   if ( $wgCCTrailerFilter && defined( 'ULS_VERSION' ) ) {
$skin->getOutput()->addModules( 'ext.cleanchanges.uls' 
);
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/315646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb3ae1d29b8267891e9d00b7cb6f8603b9b5ef76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CleanChanges
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits