[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Minor fix for phan 0.8.5

2017-08-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371041 )

Change subject: Minor fix for phan 0.8.5
..


Minor fix for phan 0.8.5

- run should return a bool
- suppress issue for noop stub

Bug: T172935
Change-Id: I5f57e57ad0b6c89991f3cc95bc4068332fb98ffc
---
M src/CognateUpdater.php
M src/LocalJobSubmitJob.php
2 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/CognateUpdater.php b/src/CognateUpdater.php
index 0ae2246..9c2bd90 100644
--- a/src/CognateUpdater.php
+++ b/src/CognateUpdater.php
@@ -61,6 +61,10 @@
return $updater;
}
 
+   /**
+* @suppress PhanTypeMissingReturn
+* @return array
+*/
protected function getCoreUpdateList() {
// not used but is abstract and must be implemented
}
diff --git a/src/LocalJobSubmitJob.php b/src/LocalJobSubmitJob.php
index 58f76fa..9bdd942 100644
--- a/src/LocalJobSubmitJob.php
+++ b/src/LocalJobSubmitJob.php
@@ -36,6 +36,8 @@
foreach ( array_unique( $sites ) as $dbName ) {
JobQueueGroup::singleton( $dbName )->push( $job );
}
+
+   return true;
}
 
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f57e57ad0b6c89991f3cc95bc4068332fb98ffc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cognate
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Cognate[master]: Minor fix for phan 0.8.5

2017-08-10 Thread WMDE-Fisch (Code Review) 
WMDE-Fisch has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371041 )

Change subject: Minor fix for phan 0.8.5
..

Minor fix for phan 0.8.5

- run should return a bool
- suppress issue for noop stub

Bug: T172935
Change-Id: I5f57e57ad0b6c89991f3cc95bc4068332fb98ffc
---
M src/CognateUpdater.php
M src/LocalJobSubmitJob.php
2 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cognate 
refs/changes/41/371041/1

diff --git a/src/CognateUpdater.php b/src/CognateUpdater.php
index 0ae2246..9c2bd90 100644
--- a/src/CognateUpdater.php
+++ b/src/CognateUpdater.php
@@ -61,6 +61,10 @@
return $updater;
}
 
+   /**
+* @suppress PhanTypeMissingReturn
+* @return array
+*/
protected function getCoreUpdateList() {
// not used but is abstract and must be implemented
}
diff --git a/src/LocalJobSubmitJob.php b/src/LocalJobSubmitJob.php
index 58f76fa..9bdd942 100644
--- a/src/LocalJobSubmitJob.php
+++ b/src/LocalJobSubmitJob.php
@@ -36,6 +36,8 @@
foreach ( array_unique( $sites ) as $dbName ) {
JobQueueGroup::singleton( $dbName )->push( $job );
}
+
+   return true;
}
 
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/371041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f57e57ad0b6c89991f3cc95bc4068332fb98ffc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cognate
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits