[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Replace Linker::link() with LinkRenderer in special pages

2017-08-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/359688 )

Change subject: Replace Linker::link() with LinkRenderer in special pages
..


Replace Linker::link() with LinkRenderer in special pages

Bug: T149346
Change-Id: Ib4bf6bd1e585a671a77658d1b9a51a1f59a5a350
---
M frontend/specialpages/actions/RevisionReview_body.php
M frontend/specialpages/reports/ConfiguredPages_body.php
M frontend/specialpages/reports/PendingChanges_body.php
M frontend/specialpages/reports/ProblemChanges_body.php
M frontend/specialpages/reports/ReviewedPages_body.php
M frontend/specialpages/reports/ReviewedVersions_body.php
M frontend/specialpages/reports/StablePages_body.php
M frontend/specialpages/reports/UnreviewedPages_body.php
M frontend/specialpages/reports/ValidationStatistics_body.php
9 files changed, 52 insertions(+), 37 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/frontend/specialpages/actions/RevisionReview_body.php 
b/frontend/specialpages/actions/RevisionReview_body.php
index 974a95b..6fc5917 100644
--- a/frontend/specialpages/actions/RevisionReview_body.php
+++ b/frontend/specialpages/actions/RevisionReview_body.php
@@ -182,11 +182,12 @@
}
 
protected function getSpecialLinks() {
+   $linkRenderer = $this->getLinkRenderer();
$s = '' . $this->msg( 'returnto' )->rawParams(
-   Linker::linkKnown( SpecialPage::getTitleFor( 
'UnreviewedPages' ) )
+   $linkRenderer->makeKnownLink( SpecialPage::getTitleFor( 
'UnreviewedPages' ) )
)->escaped() . '';
$s .= '' . $this->msg( 'returnto' )->rawParams(
-   Linker::linkKnown( SpecialPage::getTitleFor( 
'PendingChanges' ) )
+   $linkRenderer->makeKnownLink( SpecialPage::getTitleFor( 
'PendingChanges' ) )
)->escaped() . '';
return $s;
}
diff --git a/frontend/specialpages/reports/ConfiguredPages_body.php 
b/frontend/specialpages/reports/ConfiguredPages_body.php
index b62561a..89f9849 100644
--- a/frontend/specialpages/reports/ConfiguredPages_body.php
+++ b/frontend/specialpages/reports/ConfiguredPages_body.php
@@ -71,11 +71,12 @@
public function formatRow( $row ) {
$title = Title::newFromRow( $row );
# Link to page
-   $link = Linker::link( $title );
+   $linkRenderer = $this->getLinkRenderer();
+   $link = $linkRenderer->makeLink( $title );
# Link to page configuration
-   $config = Linker::linkKnown(
+   $config = $linkRenderer->makeKnownLink(
SpecialPage::getTitleFor( 'Stabilization' ),
-   $this->msg( 'configuredpages-config' )->escaped(),
+   $this->msg( 'configuredpages-config' )->text(),
[],
'page=' . $title->getPrefixedUrl()
);
diff --git a/frontend/specialpages/reports/PendingChanges_body.php 
b/frontend/specialpages/reports/PendingChanges_body.php
index efff67d..f621f89 100644
--- a/frontend/specialpages/reports/PendingChanges_body.php
+++ b/frontend/specialpages/reports/PendingChanges_body.php
@@ -225,14 +225,17 @@
$title = Title::newFromRow( $row );
$stxt = ChangesList::showCharacterDifference( $row->rev_len, 
$row->page_len );
# Page links...
-   $link = Linker::link( $title );
-   $hist = Linker::linkKnown( $title,
-   $this->msg( 'hist' )->escaped(),
+   $linkRenderer = $this->getLinkRenderer();
+   $link = $linkRenderer->makeLink( $title );
+   $hist = $linkRenderer->makeKnownLink(
+   $title,
+   $this->msg( 'hist' )->text(),
[],
[ 'action' => 'history' ]
);
-   $review = Linker::linkKnown( $title,
-   $this->msg( 'pendingchanges-diff' )->escaped(),
+   $review = $linkRenderer->makeKnownLink(
+   $title,
+   $this->msg( 'pendingchanges-diff' )->text(),
[],
[ 'diff' => 'cur', 'oldid' => $row->stable ] + 
FlaggedRevs::diffOnlyCGI()
);
diff --git a/frontend/specialpages/reports/ProblemChanges_body.php 
b/frontend/specialpages/reports/ProblemChanges_body.php
index d832c63..e21f270 100644
--- a/frontend/specialpages/reports/ProblemChanges_body.php
+++ b/frontend/specialpages/reports/ProblemChanges_body.php
@@ -193,9 +193,11 @@
$css = $quality = $tags = $underReview = '';
 
$title = Title::newFromRow( $row );
-   $link = Linker::link( $title );
-

[MediaWiki-commits] [Gerrit] mediawiki...FlaggedRevs[master]: Replace Linker::link() with LinkRenderer in special pages

2017-06-17 Thread Code Review 
Matěj Suchánek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359688 )

Change subject: Replace Linker::link() with LinkRenderer in special pages
..

Replace Linker::link() with LinkRenderer in special pages

Bug: T149346
Change-Id: Ib4bf6bd1e585a671a77658d1b9a51a1f59a5a350
---
M frontend/specialpages/actions/RevisionReview_body.php
M frontend/specialpages/reports/ConfiguredPages_body.php
M frontend/specialpages/reports/PendingChanges_body.php
M frontend/specialpages/reports/ProblemChanges_body.php
M frontend/specialpages/reports/ReviewedPages_body.php
M frontend/specialpages/reports/ReviewedVersions_body.php
M frontend/specialpages/reports/StablePages_body.php
M frontend/specialpages/reports/UnreviewedPages_body.php
M frontend/specialpages/reports/ValidationStatistics_body.php
9 files changed, 45 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/88/359688/1

diff --git a/frontend/specialpages/actions/RevisionReview_body.php 
b/frontend/specialpages/actions/RevisionReview_body.php
index 38d7bbd..9fa9584 100644
--- a/frontend/specialpages/actions/RevisionReview_body.php
+++ b/frontend/specialpages/actions/RevisionReview_body.php
@@ -183,10 +183,10 @@
 
protected function getSpecialLinks() {
$s = '' . $this->msg( 'returnto' )->rawParams(
-   Linker::linkKnown( SpecialPage::getTitleFor( 
'UnreviewedPages' ) )
+   $this->getLinkRenderer()->makeLink( 
SpecialPage::getTitleFor( 'UnreviewedPages' ) )
)->escaped() . '';
$s .= '' . $this->msg( 'returnto' )->rawParams(
-   Linker::linkKnown( SpecialPage::getTitleFor( 
'PendingChanges' ) )
+   $this->getLinkRenderer()->makeKnownLink( 
SpecialPage::getTitleFor( 'PendingChanges' ) )
)->escaped() . '';
return $s;
}
diff --git a/frontend/specialpages/reports/ConfiguredPages_body.php 
b/frontend/specialpages/reports/ConfiguredPages_body.php
index b62561a..c52f089 100644
--- a/frontend/specialpages/reports/ConfiguredPages_body.php
+++ b/frontend/specialpages/reports/ConfiguredPages_body.php
@@ -71,11 +71,11 @@
public function formatRow( $row ) {
$title = Title::newFromRow( $row );
# Link to page
-   $link = Linker::link( $title );
+   $link = $this->getLinkRenderer()->makeLink( $title );
# Link to page configuration
-   $config = Linker::linkKnown(
+   $config = $this->getLinkRenderer()->makeKnownLink(
SpecialPage::getTitleFor( 'Stabilization' ),
-   $this->msg( 'configuredpages-config' )->escaped(),
+   $this->msg( 'configuredpages-config' )->text(),
[],
'page=' . $title->getPrefixedUrl()
);
diff --git a/frontend/specialpages/reports/PendingChanges_body.php 
b/frontend/specialpages/reports/PendingChanges_body.php
index 83729f9..dc28929 100644
--- a/frontend/specialpages/reports/PendingChanges_body.php
+++ b/frontend/specialpages/reports/PendingChanges_body.php
@@ -225,14 +225,16 @@
$title = Title::newFromRow( $row );
$stxt = ChangesList::showCharacterDifference( $row->rev_len, 
$row->page_len );
# Page links...
-   $link = Linker::link( $title );
-   $hist = Linker::linkKnown( $title,
-   $this->msg( 'hist' )->escaped(),
+   $link = $this->getLinkRenderer()->makeLink( $title );
+   $hist = $this->getLinkRenderer()->makeKnownLink(
+   $title,
+   $this->msg( 'hist' )->text(),
[],
[ 'action' => 'history' ]
);
-   $review = Linker::linkKnown( $title,
-   $this->msg( 'pendingchanges-diff' )->escaped(),
+   $review = $this->getLinkRenderer()->makeKnownLink(
+   $title,
+   $this->msg( 'pendingchanges-diff' )->text(),
[],
[ 'diff' => 'cur', 'oldid' => $row->stable ] + 
FlaggedRevs::diffOnlyCGI()
);
diff --git a/frontend/specialpages/reports/ProblemChanges_body.php 
b/frontend/specialpages/reports/ProblemChanges_body.php
index 18d0d1a..51d67f0 100644
--- a/frontend/specialpages/reports/ProblemChanges_body.php
+++ b/frontend/specialpages/reports/ProblemChanges_body.php
@@ -193,9 +193,10 @@
$css = $quality = $tags = $underReview = '';
 
$title = Title::newFromRow( $row );
-   $link = Linker::link( $title );
-   $review = Linker::linkKnown( $title,
-   $this->msg( 'pendingchanges-di