[MediaWiki-commits] [Gerrit] mediawiki...Genealogy[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371301 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..
build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
Change-Id: Ibb364a84c580be529249eced638923a2a1850aad
---
M composer.json
M phpcs.xml
M src/Person.php
M src/Traverser.php
M src/Tree.php
5 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/composer.json b/composer.json
index 64ac8b5..346dafb 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "^0.9",
- "mediawiki/mediawiki-codesniffer": "0.10.1",
+ "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 74e9072..199630f 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,5 +1,6 @@
-
+
+
.
diff --git a/src/Person.php b/src/Person.php
index 3ce05cd..97c43c0 100644
--- a/src/Person.php
+++ b/src/Person.php
@@ -209,7 +209,7 @@
*/
protected function getPropInbound( $type ) {
$dbr = wfGetDB( DB_SLAVE );
- $tables = [ 'pp'=>'page_props', 'p'=>'page' ];
+ $tables = [ 'pp' => 'page_props', 'p' => 'page' ];
$columns = [ 'pp_value', 'page_title' ];
$where = [
@@ -217,7 +217,7 @@
'pp_propname' . $dbr->buildLike( 'genealogy ', $type.'
', $dbr->anyString() ),
'pp_page = page_id',
];
- $results = $dbr->select( $tables, $columns, $where, __METHOD__,
[], [ 'page'=>[] ] );
+ $results = $dbr->select( $tables, $columns, $where, __METHOD__,
[], [ 'page' => [] ] );
$out = [];
foreach ( $results as $res ) {
$title = Title::newFromText( $res->page_title );
diff --git a/src/Traverser.php b/src/Traverser.php
index b403971..104e5a5 100644
--- a/src/Traverser.php
+++ b/src/Traverser.php
@@ -22,7 +22,7 @@
/**
* Traverse all ancestors.
* @param Person $person The person to start at.
-* @param integer $depth The height to ascend to.
+* @param int $depth The height to ascend to.
*/
public function ancestors( Person $person, $depth = null ) {
// Visit this person and their partners.
@@ -44,7 +44,7 @@
/**
* Traverse all descendants.
* @param Person $person The person to start at.
-* @param integer $depth The depth to descend to.
+* @param int $depth The depth to descend to.
*/
public function descendants( Person $person, $depth = null ) {
// Visit this person and their partners.
diff --git a/src/Tree.php b/src/Tree.php
index ac4e9ab..e8316f4 100644
--- a/src/Tree.php
+++ b/src/Tree.php
@@ -23,7 +23,7 @@
/**
* Set the number of levels the tree will go up to from the ancestors'
starting points.
-* @param integer $ancestor_depth The new ancestor depth.
+* @param int $ancestor_depth The new ancestor depth.
*/
public function setAncestorDepth( $ancestor_depth ) {
$this->ancestor_depth = $ancestor_depth;
@@ -31,7 +31,7 @@
/**
* Set the number of levels the tree will go down to from the
descendants' starting points.
-* @param integer $descendant_depth The new descendant depth.
+* @param int $descendant_depth The new descendant depth.
*/
public function setDescendantDepth( $descendant_depth ) {
$this->descendant_depth = $descendant_depth;
--
To view, visit https://gerrit.wikimedia.org/r/371301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb364a84c580be529249eced638923a2a1850aad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Genealogy
Gerrit-Branch: master
Gerrit-Owner: Legoktm
Gerrit-Reviewer: Legoktm
Gerrit-Reviewer: Samwilson
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Genealogy[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/371301 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
..
build: Updating mediawiki/mediawiki-codesniffer to 0.11.0
Change-Id: Ibb364a84c580be529249eced638923a2a1850aad
---
M composer.json
M phpcs.xml
M src/Person.php
M src/Traverser.php
M src/Tree.php
5 files changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Genealogy
refs/changes/01/371301/1
diff --git a/composer.json b/composer.json
index 64ac8b5..346dafb 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "^0.9",
- "mediawiki/mediawiki-codesniffer": "0.10.1",
+ "mediawiki/mediawiki-codesniffer": "0.11.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 74e9072..199630f 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,5 +1,6 @@
-
+
+
.
diff --git a/src/Person.php b/src/Person.php
index 3ce05cd..97c43c0 100644
--- a/src/Person.php
+++ b/src/Person.php
@@ -209,7 +209,7 @@
*/
protected function getPropInbound( $type ) {
$dbr = wfGetDB( DB_SLAVE );
- $tables = [ 'pp'=>'page_props', 'p'=>'page' ];
+ $tables = [ 'pp' => 'page_props', 'p' => 'page' ];
$columns = [ 'pp_value', 'page_title' ];
$where = [
@@ -217,7 +217,7 @@
'pp_propname' . $dbr->buildLike( 'genealogy ', $type.'
', $dbr->anyString() ),
'pp_page = page_id',
];
- $results = $dbr->select( $tables, $columns, $where, __METHOD__,
[], [ 'page'=>[] ] );
+ $results = $dbr->select( $tables, $columns, $where, __METHOD__,
[], [ 'page' => [] ] );
$out = [];
foreach ( $results as $res ) {
$title = Title::newFromText( $res->page_title );
diff --git a/src/Traverser.php b/src/Traverser.php
index b403971..104e5a5 100644
--- a/src/Traverser.php
+++ b/src/Traverser.php
@@ -22,7 +22,7 @@
/**
* Traverse all ancestors.
* @param Person $person The person to start at.
-* @param integer $depth The height to ascend to.
+* @param int $depth The height to ascend to.
*/
public function ancestors( Person $person, $depth = null ) {
// Visit this person and their partners.
@@ -44,7 +44,7 @@
/**
* Traverse all descendants.
* @param Person $person The person to start at.
-* @param integer $depth The depth to descend to.
+* @param int $depth The depth to descend to.
*/
public function descendants( Person $person, $depth = null ) {
// Visit this person and their partners.
diff --git a/src/Tree.php b/src/Tree.php
index ac4e9ab..e8316f4 100644
--- a/src/Tree.php
+++ b/src/Tree.php
@@ -23,7 +23,7 @@
/**
* Set the number of levels the tree will go up to from the ancestors'
starting points.
-* @param integer $ancestor_depth The new ancestor depth.
+* @param int $ancestor_depth The new ancestor depth.
*/
public function setAncestorDepth( $ancestor_depth ) {
$this->ancestor_depth = $ancestor_depth;
@@ -31,7 +31,7 @@
/**
* Set the number of levels the tree will go down to from the
descendants' starting points.
-* @param integer $descendant_depth The new descendant depth.
+* @param int $descendant_depth The new descendant depth.
*/
public function setDescendantDepth( $descendant_depth ) {
$this->descendant_depth = $descendant_depth;
--
To view, visit https://gerrit.wikimedia.org/r/371301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb364a84c580be529249eced638923a2a1850aad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Genealogy
Gerrit-Branch: master
Gerrit-Owner: Legoktm
Gerrit-Reviewer: Legoktm
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
