[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: QA: Simplify toast notification step some more

2017-08-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370880 )

Change subject: QA: Simplify toast notification step some more
..


QA: Simplify toast notification step some more

If mediawiki.notification has loaded that should be enough to assume
the toast is ready to have its text checked.

Change-Id: Ic546877eae0ea6dd59dbf88bf9267bcd1957f779
---
M tests/browser/features/step_definitions/common_article_steps.rb
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/tests/browser/features/step_definitions/common_article_steps.rb 
b/tests/browser/features/step_definitions/common_article_steps.rb
index c08ee3a..d2296a2 100644
--- a/tests/browser/features/step_definitions/common_article_steps.rb
+++ b/tests/browser/features/step_definitions/common_article_steps.rb
@@ -39,9 +39,6 @@
 Then(/^I should see a toast with message "(.+)"$/) do |msg|
   on(ArticlePage) do |page|
 page.wait_until_rl_module_ready('mediawiki.notification')
-page.wait_until do
-  page.toast_element.when_present.text.include? msg
-end
 expect(page.toast_element.when_present.text).to match msg
   end
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/370880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic546877eae0ea6dd59dbf88bf9267bcd1957f779
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: QA: Simplify toast notification step some more

2017-08-09 Thread Jdlrobson (Code Review) 
Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370880 )

Change subject: QA: Simplify toast notification step some more
..

QA: Simplify toast notification step some more

If mediawiki.notification has loaded that should be enough to assume
the toast is ready to have its text checked.

Change-Id: Ic546877eae0ea6dd59dbf88bf9267bcd1957f779
---
M tests/browser/features/step_definitions/common_article_steps.rb
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/80/370880/1

diff --git a/tests/browser/features/step_definitions/common_article_steps.rb 
b/tests/browser/features/step_definitions/common_article_steps.rb
index c08ee3a..d2296a2 100644
--- a/tests/browser/features/step_definitions/common_article_steps.rb
+++ b/tests/browser/features/step_definitions/common_article_steps.rb
@@ -39,9 +39,6 @@
 Then(/^I should see a toast with message "(.+)"$/) do |msg|
   on(ArticlePage) do |page|
 page.wait_until_rl_module_ready('mediawiki.notification')
-page.wait_until do
-  page.toast_element.when_present.text.include? msg
-end
 expect(page.toast_element.when_present.text).to match msg
   end
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/370880
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic546877eae0ea6dd59dbf88bf9267bcd1957f779
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits