jenkins-bot has submitted this change and it was merged.
Change subject: QA: Don't skip browser tests
......................................................................
QA: Don't skip browser tests
Instead of skipping these now run on a per commit basis.
If they are not important we should remove them from the repo
but they seem useful to me.
These tests were skipped without explanation as part of the migration
to Selenium jobs in 3be30ef850f6bca711c930ed529c93edfb157fd8
which doesn't seem helpful as removing the
en.m.wikipedia.beta.wmflabs.org tag has the same effect while still
allowing them to run somewhere.
If they have been skipped intentionally, this merge will reveal issues
with running these on the beta cluster which we can document in a
Phabricator ticket and promptly remove the tag
en.m.wikipedia.beta.wmflabs.org to ensure they pass again but still
run somewhere.
Change-Id: I3477edc1c0fd0386eb8e00f6d455bdb075d2e96a
---
M tests/browser/features/search.feature
M tests/browser/features/special.feature
M tests/browser/features/special_watchlist.feature
3 files changed, 3 insertions(+), 4 deletions(-)
Approvals:
Jhobs: Looks good to me, but someone else must approve
Bmansurov: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/search.feature
b/tests/browser/features/search.feature
index 3a25e70..ec385f6 100644
--- a/tests/browser/features/search.feature
+++ b/tests/browser/features/search.feature
@@ -1,4 +1,4 @@
-@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @skip @test2.m.wikipedia.org
@vagrant
+@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @integration
@test2.m.wikipedia.org @vagrant
Feature: Search
Background:
diff --git a/tests/browser/features/special.feature
b/tests/browser/features/special.feature
index 0bfdcdf..46f60b7 100644
--- a/tests/browser/features/special.feature
+++ b/tests/browser/features/special.feature
@@ -1,11 +1,10 @@
-@chrome @firefox @test2.m.wikipedia.org @vagrant
+@chrome @firefox @test2.m.wikipedia.org @vagrant @integration
Feature: Generic special page features
Background:
Given I am using the mobile site
And I am on the "Main Page" page
- @skip
Scenario: Search from Watchlist
Given I am logged into the mobile website
When I click on "Watchlist" in the main navigation menu
diff --git a/tests/browser/features/special_watchlist.feature
b/tests/browser/features/special_watchlist.feature
index 84f752e..de01d4b 100644
--- a/tests/browser/features/special_watchlist.feature
+++ b/tests/browser/features/special_watchlist.feature
@@ -1,4 +1,4 @@
-@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @integration @skip
@test2.m.wikipedia.org @vagrant
+@chrome @en.m.wikipedia.beta.wmflabs.org @firefox @integration
@test2.m.wikipedia.org @vagrant
Feature: Manage Watchlist
Background:
--
To view, visit https://gerrit.wikimedia.org/r/315113
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3477edc1c0fd0386eb8e00f6d455bdb075d2e96a
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jhobs <jhob...@wikimedia.org>
Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
