[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Use “OOUI” as unified name in code comments
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404634 )
Change subject: Use “OOUI” as unified name in code comments
..
Use “OOUI” as unified name in code comments
Bug: T182360
Change-Id: I20e85bf4d5ef55797b5be59ae1772f791d504ade
---
M resources/mmv/ui/mmv.ui.download.pane.js
M resources/mmv/ui/mmv.ui.download.pane.less
M resources/mmv/ui/mmv.ui.reuse.dialog.js
M resources/mmv/ui/mmv.ui.reuse.embed.less
M resources/mmv/ui/mmv.ui.reuse.share.less
5 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/resources/mmv/ui/mmv.ui.download.pane.js
b/resources/mmv/ui/mmv.ui.download.pane.js
index d7fd273..7c7ecb7 100644
--- a/resources/mmv/ui/mmv.ui.download.pane.js
+++ b/resources/mmv/ui/mmv.ui.download.pane.js
@@ -81,7 +81,7 @@
* @param {jQuery} $container
*/
DP.createDownloadButton = function ( $container ) {
- // TODO: Use oojs-ui constructive button widget instead
+ // TODO: Use OOUI progressive button widget instead
this.$downloadButton = $( '' )
.attr( 'target', '_blank' )
.attr( 'download', '' )
diff --git a/resources/mmv/ui/mmv.ui.download.pane.less
b/resources/mmv/ui/mmv.ui.download.pane.less
index 56da954..8587455 100644
--- a/resources/mmv/ui/mmv.ui.download.pane.less
+++ b/resources/mmv/ui/mmv.ui.download.pane.less
@@ -175,7 +175,7 @@
}
.mw-mmv-download-attr-input {
- // override OOJS-UI fixed width
+ // override OOUI fixed width
width: auto;
// margin between text widget and option switch widget
@@ -194,7 +194,7 @@
height: 1.5em;
// position approximately to the middle - probably
fragile but couldn't find a better way as
- // the height of OOJS-UI input widget has both em and
px parts and not possible to calculate
+ // the height of OOUI input widget has both em and px
parts and not possible to calculate
// exactly
margin: 8px 0.5em 8px 0;
}
diff --git a/resources/mmv/ui/mmv.ui.reuse.dialog.js
b/resources/mmv/ui/mmv.ui.reuse.dialog.js
index 5b61a90..11eb46f 100644
--- a/resources/mmv/ui/mmv.ui.reuse.dialog.js
+++ b/resources/mmv/ui/mmv.ui.reuse.dialog.js
@@ -37,7 +37,7 @@
this.tabs = null;
/**
-* @property {Object.} ooTabs
List of tab OOJS UI objects.
+* @property {Object.} ooTabs
List of tab OOUI objects.
*/
this.ooTabs = null;
diff --git a/resources/mmv/ui/mmv.ui.reuse.embed.less
b/resources/mmv/ui/mmv.ui.reuse.embed.less
index 1291ff9..cb4d812 100644
--- a/resources/mmv/ui/mmv.ui.reuse.embed.less
+++ b/resources/mmv/ui/mmv.ui.reuse.embed.less
@@ -13,7 +13,7 @@
display: block;
}
- // The selector has to be that deep and include [readonly] to
override OOJS UI's definition
+ // The selector has to be that deep and include [readonly] to
override OOUI's definition
textarea[ readonly ] {
color: @textarea-text-color;
text-shadow: none;
diff --git a/resources/mmv/ui/mmv.ui.reuse.share.less
b/resources/mmv/ui/mmv.ui.reuse.share.less
index 0833f81..9c54430 100644
--- a/resources/mmv/ui/mmv.ui.reuse.share.less
+++ b/resources/mmv/ui/mmv.ui.reuse.share.less
@@ -2,13 +2,13 @@
.mw-mmv-share-pane {
.mw-mmv-share-page {
- // override OOJS-UI fixed width
+ // override OOUI fixed width
width: auto;
// make sure this is a new block formatting context so that the
float shrinks it instead of
// running into it and pushing the input down (there is
probably a better way of doing this)
overflow: hidden;
- // The selector has to be that deep and include [readonly] to
override OOJS UI's definition
+ // The selector has to be that deep and include [readonly] to
override OOUI's definition
input[ readonly ] {
color: @input-text-color;
text-shadow: none;
@@ -21,7 +21,7 @@
width: 1.5em;
height: 1.5em;
// position approximately to the middle - probably fragile but
couldn't find a better way as
- // the height of OOJS-UI input widget has both em and px parts
and not possible to calculate
+ // the height of OOUI input widget has both em and px parts and
not possible to calculate
// exactly
[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Use “OOUI” as unified name in code comments
VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404634 )
Change subject: Use “OOUI” as unified name in code comments
..
Use “OOUI” as unified name in code comments
Bug: T182360
Change-Id: I20e85bf4d5ef55797b5be59ae1772f791d504ade
---
M resources/mmv/ui/mmv.ui.download.pane.js
M resources/mmv/ui/mmv.ui.download.pane.less
M resources/mmv/ui/mmv.ui.reuse.dialog.js
M resources/mmv/ui/mmv.ui.reuse.embed.less
M resources/mmv/ui/mmv.ui.reuse.share.less
5 files changed, 9 insertions(+), 9 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/34/404634/1
diff --git a/resources/mmv/ui/mmv.ui.download.pane.js
b/resources/mmv/ui/mmv.ui.download.pane.js
index d7fd273..7c7ecb7 100644
--- a/resources/mmv/ui/mmv.ui.download.pane.js
+++ b/resources/mmv/ui/mmv.ui.download.pane.js
@@ -81,7 +81,7 @@
* @param {jQuery} $container
*/
DP.createDownloadButton = function ( $container ) {
- // TODO: Use oojs-ui constructive button widget instead
+ // TODO: Use OOUI progressive button widget instead
this.$downloadButton = $( '' )
.attr( 'target', '_blank' )
.attr( 'download', '' )
diff --git a/resources/mmv/ui/mmv.ui.download.pane.less
b/resources/mmv/ui/mmv.ui.download.pane.less
index 56da954..8587455 100644
--- a/resources/mmv/ui/mmv.ui.download.pane.less
+++ b/resources/mmv/ui/mmv.ui.download.pane.less
@@ -175,7 +175,7 @@
}
.mw-mmv-download-attr-input {
- // override OOJS-UI fixed width
+ // override OOUI fixed width
width: auto;
// margin between text widget and option switch widget
@@ -194,7 +194,7 @@
height: 1.5em;
// position approximately to the middle - probably
fragile but couldn't find a better way as
- // the height of OOJS-UI input widget has both em and
px parts and not possible to calculate
+ // the height of OOUI input widget has both em and px
parts and not possible to calculate
// exactly
margin: 8px 0.5em 8px 0;
}
diff --git a/resources/mmv/ui/mmv.ui.reuse.dialog.js
b/resources/mmv/ui/mmv.ui.reuse.dialog.js
index 5b61a90..11eb46f 100644
--- a/resources/mmv/ui/mmv.ui.reuse.dialog.js
+++ b/resources/mmv/ui/mmv.ui.reuse.dialog.js
@@ -37,7 +37,7 @@
this.tabs = null;
/**
-* @property {Object.} ooTabs
List of tab OOJS UI objects.
+* @property {Object.} ooTabs
List of tab OOUI objects.
*/
this.ooTabs = null;
diff --git a/resources/mmv/ui/mmv.ui.reuse.embed.less
b/resources/mmv/ui/mmv.ui.reuse.embed.less
index 1291ff9..cb4d812 100644
--- a/resources/mmv/ui/mmv.ui.reuse.embed.less
+++ b/resources/mmv/ui/mmv.ui.reuse.embed.less
@@ -13,7 +13,7 @@
display: block;
}
- // The selector has to be that deep and include [readonly] to
override OOJS UI's definition
+ // The selector has to be that deep and include [readonly] to
override OOUI's definition
textarea[ readonly ] {
color: @textarea-text-color;
text-shadow: none;
diff --git a/resources/mmv/ui/mmv.ui.reuse.share.less
b/resources/mmv/ui/mmv.ui.reuse.share.less
index 0833f81..9c54430 100644
--- a/resources/mmv/ui/mmv.ui.reuse.share.less
+++ b/resources/mmv/ui/mmv.ui.reuse.share.less
@@ -2,13 +2,13 @@
.mw-mmv-share-pane {
.mw-mmv-share-page {
- // override OOJS-UI fixed width
+ // override OOUI fixed width
width: auto;
// make sure this is a new block formatting context so that the
float shrinks it instead of
// running into it and pushing the input down (there is
probably a better way of doing this)
overflow: hidden;
- // The selector has to be that deep and include [readonly] to
override OOJS UI's definition
+ // The selector has to be that deep and include [readonly] to
override OOUI's definition
input[ readonly ] {
color: @input-text-color;
text-shadow: none;
@@ -21,7 +21,7 @@
width: 1.5em;
height: 1.5em;
// position approximately to the middle - probably fragile but
couldn't find a better way as
- // the height of OOJS-UI input widget has both em and px parts
and not possible to calculate
+ // the height of OOUI input widget has both em and px parts and
not possible to calculate
// ex
