[MediaWiki-commits] [Gerrit] mediawiki...Nuke[master]: Improve some parameter docs

2017-08-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370951 )

Change subject: Improve some parameter docs
..


Improve some parameter docs

Change-Id: Ic9e8c1f4a9fc9a283def144cbba742e3fecb62f0
---
M Nuke.hooks.php
M Nuke_body.php
M composer.json
M phpcs.xml
4 files changed, 9 insertions(+), 13 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/Nuke.hooks.php b/Nuke.hooks.php
index d2cc607..374d2e8 100644
--- a/Nuke.hooks.php
+++ b/Nuke.hooks.php
@@ -7,7 +7,7 @@
 *
 * @param int $userId
 * @param Title $userPageTitle
-* @param string[] $toolLinks
+* @param string[] &$toolLinks
 * @param SpecialPage $sp
 */
public static function nukeContributionsLinks( $userId, $userPageTitle, 
&$toolLinks,
diff --git a/Nuke_body.php b/Nuke_body.php
index cd5dadf..fad9458 100644
--- a/Nuke_body.php
+++ b/Nuke_body.php
@@ -69,7 +69,7 @@
/**
 * Prompt for a username or IP address.
 *
-* @param $userName string
+* @param string $userName
 */
protected function promptForm( $userName = '' ) {
$out = $this->getOutput();
@@ -126,8 +126,8 @@
 *
 * @param string $username
 * @param string $reason
-* @param integer $limit
-* @param integer|null $namespace
+* @param int $limit
+* @param int|null $namespace
 */
protected function listForm( $username, $reason, $limit, $namespace = 
null ) {
$out = $this->getOutput();
@@ -244,8 +244,8 @@
 * Gets a list of new pages by the specified user or everyone when none 
is specified.
 *
 * @param string $username
-* @param integer $limit
-* @param integer|null $namespace
+* @param int $limit
+* @param int|null $namespace
 *
 * @return array
 */
diff --git a/composer.json b/composer.json
index d368985..c0f3175 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
"scripts": {
"fix": "phpcbf",
"test": [
-   "parallel-lint . --exclude vendor",
+   "parallel-lint . --exclude vendor --exclude 
node_modules",
"phpcs -p -s"
]
}
diff --git a/phpcs.xml b/phpcs.xml
index 61142db..2f17eb4 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,18 +2,14 @@
 


-   
-   
-   





-   Nuke.alias.php
+   Nuke\.alias\.php

.

-   
-   vendor
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/370951
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9e8c1f4a9fc9a283def144cbba742e3fecb62f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Nuke
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Nuke[master]: Improve some parameter docs

2017-08-09 Thread Umherirrender (Code Review) 
Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370951 )

Change subject: Improve some parameter docs
..

Improve some parameter docs

Change-Id: Ic9e8c1f4a9fc9a283def144cbba742e3fecb62f0
---
M Nuke.hooks.php
M Nuke_body.php
M composer.json
M phpcs.xml
4 files changed, 9 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Nuke 
refs/changes/51/370951/1

diff --git a/Nuke.hooks.php b/Nuke.hooks.php
index d2cc607..374d2e8 100644
--- a/Nuke.hooks.php
+++ b/Nuke.hooks.php
@@ -7,7 +7,7 @@
 *
 * @param int $userId
 * @param Title $userPageTitle
-* @param string[] $toolLinks
+* @param string[] &$toolLinks
 * @param SpecialPage $sp
 */
public static function nukeContributionsLinks( $userId, $userPageTitle, 
&$toolLinks,
diff --git a/Nuke_body.php b/Nuke_body.php
index cd5dadf..fad9458 100644
--- a/Nuke_body.php
+++ b/Nuke_body.php
@@ -69,7 +69,7 @@
/**
 * Prompt for a username or IP address.
 *
-* @param $userName string
+* @param string $userName
 */
protected function promptForm( $userName = '' ) {
$out = $this->getOutput();
@@ -126,8 +126,8 @@
 *
 * @param string $username
 * @param string $reason
-* @param integer $limit
-* @param integer|null $namespace
+* @param int $limit
+* @param int|null $namespace
 */
protected function listForm( $username, $reason, $limit, $namespace = 
null ) {
$out = $this->getOutput();
@@ -244,8 +244,8 @@
 * Gets a list of new pages by the specified user or everyone when none 
is specified.
 *
 * @param string $username
-* @param integer $limit
-* @param integer|null $namespace
+* @param int $limit
+* @param int|null $namespace
 *
 * @return array
 */
diff --git a/composer.json b/composer.json
index d368985..c0f3175 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
"scripts": {
"fix": "phpcbf",
"test": [
-   "parallel-lint . --exclude vendor",
+   "parallel-lint . --exclude vendor --exclude 
node_modules",
"phpcs -p -s"
]
}
diff --git a/phpcs.xml b/phpcs.xml
index 61142db..2f17eb4 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -2,18 +2,14 @@
 


-   
-   
-   





-   Nuke.alias.php
+   Nuke\.alias\.php

.

-   
-   vendor
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/370951
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9e8c1f4a9fc9a283def144cbba742e3fecb62f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Nuke
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits