[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Remove redundant $wgUser

2016-10-12 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove redundant $wgUser
..


Remove redundant $wgUser

See I180435f1

Change-Id: I997dd8d2b5d68c798b72c1310cdfbc0b4318c501
---
M tests/phpunit/includes/HooksTest.php
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/phpunit/includes/HooksTest.php 
b/tests/phpunit/includes/HooksTest.php
index b7c03a7..77353fa 100644
--- a/tests/phpunit/includes/HooksTest.php
+++ b/tests/phpunit/includes/HooksTest.php
@@ -71,8 +71,6 @@
}
 
public function testOnChangesListSpecialPageQuery() {
-   global $wgUser;
-   $oldUser = $wgUser;
$this->setMwGlobals( 'wgUser', $this->user );
 
$opts = new FormOptions();
@@ -128,8 +126,6 @@
$this->assertSame( $expected['conds'], $conds );
$this->assertSame( $expected['query_options'], $query_options );
$this->assertSame( $expected['join_conds'], $join_conds );
-
-   $this->setMwGlobals( 'wgUser', $oldUser );
}
 
public function testOnEnhancedChangesListModifyLineDataDamaging() {

-- 
To view, visit https://gerrit.wikimedia.org/r/315606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I997dd8d2b5d68c798b72c1310cdfbc0b4318c501
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: Hoo man 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Remove redundant $wgUser

2016-10-12 Thread Ladsgroup (Code Review) 
Ladsgroup has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315606

Change subject: Remove redundant $wgUser
..

Remove redundant $wgUser

See I180435f1

Change-Id: I997dd8d2b5d68c798b72c1310cdfbc0b4318c501
---
M tests/phpunit/includes/HooksTest.php
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/06/315606/1

diff --git a/tests/phpunit/includes/HooksTest.php 
b/tests/phpunit/includes/HooksTest.php
index b7c03a7..77353fa 100644
--- a/tests/phpunit/includes/HooksTest.php
+++ b/tests/phpunit/includes/HooksTest.php
@@ -71,8 +71,6 @@
}
 
public function testOnChangesListSpecialPageQuery() {
-   global $wgUser;
-   $oldUser = $wgUser;
$this->setMwGlobals( 'wgUser', $this->user );
 
$opts = new FormOptions();
@@ -128,8 +126,6 @@
$this->assertSame( $expected['conds'], $conds );
$this->assertSame( $expected['query_options'], $query_options );
$this->assertSame( $expected['join_conds'], $join_conds );
-
-   $this->setMwGlobals( 'wgUser', $oldUser );
}
 
public function testOnEnhancedChangesListModifyLineDataDamaging() {

-- 
To view, visit https://gerrit.wikimedia.org/r/315606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I997dd8d2b5d68c798b72c1310cdfbc0b4318c501
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits