[MediaWiki-commits] [Gerrit] mediawiki...OpenStackManager[master]: Fix apihelp for param id in api action novaaddress
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/370067 )
Change subject: Fix apihelp for param id in api action novaaddress
..
Fix apihelp for param id in api action novaaddress
The 'id' was not documented, but the documented 'address' was not used,
so changed the parameter name
Change-Id: I17635f2308c3920dee332a3b2d7e95a8677f109b
---
M api/ApiNovaAddress.php
M i18n/en.json
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/api/ApiNovaAddress.php b/api/ApiNovaAddress.php
index 2b616a0..5317f06 100644
--- a/api/ApiNovaAddress.php
+++ b/api/ApiNovaAddress.php
@@ -130,7 +130,7 @@
public function getParamDescription() {
return array_merge( parent::getParamDescription(), [
'subaction' => 'The subaction to perform.',
- 'address' => 'The ID of the Nova IP address on which we
will perform the action.',
+ 'id' => 'The ID of the Nova IP address on which we will
perform the action.',
'project' => 'The project in which the address exists.',
'region' => 'The region of the currently-associated
instance.',
] );
@@ -149,7 +149,7 @@
public function getExamples() {
return [
'api.php?action=novaaddress&subaction=disassociate' .
- '&address=7&project=testing®ion=mars'
+ '&id=7&project=testing®ion=mars'
=> 'Disassociate IP 208.80.153.198 in project testing',
];
}
@@ -159,7 +159,7 @@
*/
protected function getExamplesMessages() {
return [
-
'action=novaaddress&subaction=disassociate&address=7&project=testing®ion=mars'
+
'action=novaaddress&subaction=disassociate&id=7&project=testing®ion=mars'
=> 'apihelp-novaaddress-example-1',
];
}
diff --git a/i18n/en.json b/i18n/en.json
index 2e3d5cc..c731fbb 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -363,7 +363,7 @@
"apihelp-novaaddress-description": "Perform actions on Nova IP
addresses.",
"apihelp-novaaddress-summary": "Perform actions on Nova IP addresses.",
"apihelp-novaaddress-param-subaction": "The subaction to perform.",
- "apihelp-novaaddress-param-id": "",
+ "apihelp-novaaddress-param-id": "The ID of the Nova IP address on which
we will perform the action.",
"apihelp-novaaddress-param-project": "The project in which the address
exists.",
"apihelp-novaaddress-param-region": "The region of the
currently-associated instance.",
"apihelp-novaaddress-example-1": "Disassociate the address with ID 7 in
project testing in region mars",
--
To view, visit https://gerrit.wikimedia.org/r/370067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17635f2308c3920dee332a3b2d7e95a8677f109b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender
Gerrit-Reviewer: Anomie
Gerrit-Reviewer: Nikerabbit
Gerrit-Reviewer: Raimond Spekking
Gerrit-Reviewer: Siebrand
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...OpenStackManager[master]: Fix apihelp for param id in api action novaaddress
Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370067 )
Change subject: Fix apihelp for param id in api action novaaddress
..
Fix apihelp for param id in api action novaaddress
The 'id' was not documented, but the documented 'address' was not used,
so changed the parameter name
Change-Id: I17635f2308c3920dee332a3b2d7e95a8677f109b
---
M api/ApiNovaAddress.php
M i18n/en.json
2 files changed, 4 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager
refs/changes/67/370067/1
diff --git a/api/ApiNovaAddress.php b/api/ApiNovaAddress.php
index 2b616a0..5317f06 100644
--- a/api/ApiNovaAddress.php
+++ b/api/ApiNovaAddress.php
@@ -130,7 +130,7 @@
public function getParamDescription() {
return array_merge( parent::getParamDescription(), [
'subaction' => 'The subaction to perform.',
- 'address' => 'The ID of the Nova IP address on which we
will perform the action.',
+ 'id' => 'The ID of the Nova IP address on which we will
perform the action.',
'project' => 'The project in which the address exists.',
'region' => 'The region of the currently-associated
instance.',
] );
@@ -149,7 +149,7 @@
public function getExamples() {
return [
'api.php?action=novaaddress&subaction=disassociate' .
- '&address=7&project=testing®ion=mars'
+ '&id=7&project=testing®ion=mars'
=> 'Disassociate IP 208.80.153.198 in project testing',
];
}
@@ -159,7 +159,7 @@
*/
protected function getExamplesMessages() {
return [
-
'action=novaaddress&subaction=disassociate&address=7&project=testing®ion=mars'
+
'action=novaaddress&subaction=disassociate&id=7&project=testing®ion=mars'
=> 'apihelp-novaaddress-example-1',
];
}
diff --git a/i18n/en.json b/i18n/en.json
index 2e3d5cc..c731fbb 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -363,7 +363,7 @@
"apihelp-novaaddress-description": "Perform actions on Nova IP
addresses.",
"apihelp-novaaddress-summary": "Perform actions on Nova IP addresses.",
"apihelp-novaaddress-param-subaction": "The subaction to perform.",
- "apihelp-novaaddress-param-id": "",
+ "apihelp-novaaddress-param-id": "The ID of the Nova IP address on which
we will perform the action.",
"apihelp-novaaddress-param-project": "The project in which the address
exists.",
"apihelp-novaaddress-param-region": "The region of the
currently-associated instance.",
"apihelp-novaaddress-example-1": "Disassociate the address with ID 7 in
project testing in region mars",
--
To view, visit https://gerrit.wikimedia.org/r/370067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17635f2308c3920dee332a3b2d7e95a8677f109b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Umherirrender
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
