[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Allow 3rd party to check Popups enabled state by accessing m...

2017-08-09 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369711 )

Change subject: Allow 3rd party to check Popups enabled state by accessing 
mw.popups object
..


Allow 3rd party to check Popups enabled state by accessing mw.popups object

Changes:
 - introduced js module defining mw.popups object
 - introduced isEnabled() method which checks the redux store to retrieve
 isEnabled status

Bug: T171287
Change-Id: I523369831e2aa8a915ed1cb001b35d13b770f9da
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/index.js
A src/integrations/mwpopups.js
A tests/node-qunit/integrations/mwpopups.test.js
5 files changed, 75 insertions(+), 2 deletions(-)

Approvals:
  Jhernandez: Looks good to me, approved
  jenkins-bot: Verified
  Phuedx: Looks good to me, but someone else must approve




-- 
To view, visit https://gerrit.wikimedia.org/r/369711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I523369831e2aa8a915ed1cb001b35d13b770f9da
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Frankiebot 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Jhernandez 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Allow 3rd party to check Popups enabled state by accessing m...

2017-08-02 Thread Pmiazga (Code Review)
Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369711 )

Change subject: Allow 3rd party to check Popups enabled state by accessing 
mw.popups object
..

Allow 3rd party to check Popups enabled state by accessing mw.popups object

Changes:
 - introduced js module defining mw.popups object
 - introduced isEnabled() method which checks the redux store to retrieve
 isEnabled status

Bug: T171287
Change-Id: I523369831e2aa8a915ed1cb001b35d13b770f9da
---
M resources/dist/index.js
M resources/dist/index.js.map
M src/index.js
A src/integrations/mwpopups.js
4 files changed, 23 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/11/369711/1


-- 
To view, visit https://gerrit.wikimedia.org/r/369711
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I523369831e2aa8a915ed1cb001b35d13b770f9da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits