[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: make integrations/mwpopups pure
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370790 ) Change subject: Hygiene: make integrations/mwpopups pure .. Hygiene: make integrations/mwpopups pure Instead of registering global variables in a function, make it pure return the external interface and set it to mw.popups in the src/index.js entry point. Explicitly comment on index.js what is being set and why. Bug: T171287 Change-Id: I94d467bfa7fa6e56033dd254518ad50b5dde5bfc --- M resources/dist/index.js M resources/dist/index.js.map M src/index.js M src/integrations/mwpopups.js M tests/node-qunit/integrations/mwpopups.test.js 5 files changed, 44 insertions(+), 44 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/370790 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94d467bfa7fa6e56033dd254518ad50b5dde5bfc Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez Gerrit-Reviewer: Jdlrobson Gerrit-Reviewer: Jhernandez Gerrit-Reviewer: Phuedx Gerrit-Reviewer: Pmiazga Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Hygiene: make integrations/mwpopups pure
Jhernandez has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370790 ) Change subject: Hygiene: make integrations/mwpopups pure .. Hygiene: make integrations/mwpopups pure Instead of registering global variables in a function, make it pure return the external interface and set it to mw.popups in the src/index.js entry point. Explicitly comment on index.js what is being set and why. Bug: T171287 Change-Id: I94d467bfa7fa6e56033dd254518ad50b5dde5bfc --- M resources/dist/index.js M resources/dist/index.js.map M src/index.js M src/integrations/mwpopups.js M tests/node-qunit/integrations/mwpopups.test.js 5 files changed, 44 insertions(+), 44 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/90/370790/1 -- To view, visit https://gerrit.wikimedia.org/r/370790 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I94d467bfa7fa6e56033dd254518ad50b5dde5bfc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
