[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: previews: More visual design tweaks

2016-12-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: previews: More visual design tweaks
..


previews: More visual design tweaks

Per T150814#2833030.

Changes:
* Round the preview's border.
* Adjust the shadow cast by the preview.
* Make both fade-in and -out animations last 200 ms.

Bug: T150814
Change-Id: I55c728680ebb208e7cd1bd4c99a8453ae9915f2e
---
M resources/ext.popups.desktop/ext.popups.animation.less
M resources/ext.popups/styles/ext.popups.core.less
2 files changed, 5 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/resources/ext.popups.desktop/ext.popups.animation.less 
b/resources/ext.popups.desktop/ext.popups.animation.less
index ea13a02..9f6a9c8 100644
--- a/resources/ext.popups.desktop/ext.popups.animation.less
+++ b/resources/ext.popups.desktop/ext.popups.animation.less
@@ -131,9 +131,9 @@
 }
 
 .mwe-popups-fade-out-down {
-   .animation(mwe-popups-fade-out-down, 0.15s, ease, forwards);
+   .animation(mwe-popups-fade-out-down, 0.2s, ease, forwards);
 }
 
 .mwe-popups-fade-out-up {
-   .animation(mwe-popups-fade-out-up, 0.15s, ease, forwards);
+   .animation(mwe-popups-fade-out-up, 0.2s, ease, forwards);
 }
diff --git a/resources/ext.popups/styles/ext.popups.core.less 
b/resources/ext.popups/styles/ext.popups.core.less
index 3ecd50a..c97755b 100644
--- a/resources/ext.popups/styles/ext.popups.core.less
+++ b/resources/ext.popups/styles/ext.popups.core.less
@@ -67,13 +67,14 @@
 
// FIXME: The .box-shadow mixin provided by mediawiki.mixins doesn't 
support
// multiple values.
-   -webkit-box-shadow: 0 45px 70px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
-   box-shadow: 0 45px 70px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
+   -webkit-box-shadow: 0 30px 90px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
+   box-shadow: 0 30px 90px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
padding: 0;
display: none;
font-size: 14px;
line-height: 20px;
min-width: 300px;
+   border-radius: 2px;
 
.mwe-popups-container {
margin-top: -9px;

-- 
To view, visit https://gerrit.wikimedia.org/r/324399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55c728680ebb208e7cd1bd4c99a8453ae9915f2e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: mpga
Gerrit-Owner: Phuedx 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[mpga]: previews: More visual design tweaks

2016-11-30 Thread Phuedx (Code Review) 
Phuedx has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324399

Change subject: previews: More visual design tweaks
..

previews: More visual design tweaks

Per T150814#2833030.

Changes:
* Round the preview's border.
* Adjust the shadow cast by the preview.
* Make both fade-in and -out animations last 200 ms.

Bug: T150814
Change-Id: I55c728680ebb208e7cd1bd4c99a8453ae9915f2e
---
M resources/ext.popups.desktop/ext.popups.animation.less
M resources/ext.popups/styles/ext.popups.core.less
2 files changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/99/324399/1

diff --git a/resources/ext.popups.desktop/ext.popups.animation.less 
b/resources/ext.popups.desktop/ext.popups.animation.less
index ea13a02..9f6a9c8 100644
--- a/resources/ext.popups.desktop/ext.popups.animation.less
+++ b/resources/ext.popups.desktop/ext.popups.animation.less
@@ -131,9 +131,9 @@
 }
 
 .mwe-popups-fade-out-down {
-   .animation(mwe-popups-fade-out-down, 0.15s, ease, forwards);
+   .animation(mwe-popups-fade-out-down, 0.2s, ease, forwards);
 }
 
 .mwe-popups-fade-out-up {
-   .animation(mwe-popups-fade-out-up, 0.15s, ease, forwards);
+   .animation(mwe-popups-fade-out-up, 0.2s, ease, forwards);
 }
diff --git a/resources/ext.popups/styles/ext.popups.core.less 
b/resources/ext.popups/styles/ext.popups.core.less
index 2cf965e..46ccdec 100644
--- a/resources/ext.popups/styles/ext.popups.core.less
+++ b/resources/ext.popups/styles/ext.popups.core.less
@@ -77,13 +77,14 @@
 
// FIXME: The .box-shadow mixin provided by mediawiki.mixins doesn't 
support
// multiple values.
-   -webkit-box-shadow: 0 45px 70px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
-   box-shadow: 0 45px 70px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
+   -webkit-box-shadow: 0 30px 90px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
+   box-shadow: 0 30px 90px -20px rgba(0,0,0,0.3), 0px 0px 1px 
rgba(0,0,0,0.5);
padding: 0;
display: none;
font-size: 14px;
line-height: 20px;
min-width: 300px;
+   border-radius: 2px;
 
.mwe-popups-container {
margin-top: -9px;

-- 
To view, visit https://gerrit.wikimedia.org/r/324399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I55c728680ebb208e7cd1bd4c99a8453ae9915f2e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: mpga
Gerrit-Owner: Phuedx 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits