[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update scroll type detection

2017-08-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370427 )

Change subject: Update scroll type detection
..


Update scroll type detection

Port of a fix in the original source:
https://github.com/othree/jquery.rtl-scroll-type/commit/1c6d6845032c3cd91b2b387634642471d711380d

Change-Id: I2d53e467b79d586efc079a15ebc0a52382352f9e
---
M modules/ext.RevisionSlider.util.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ext.RevisionSlider.util.js 
b/modules/ext.RevisionSlider.util.js
index 6d9450d..66e51d6 100644
--- a/modules/ext.RevisionSlider.util.js
+++ b/modules/ext.RevisionSlider.util.js
@@ -95,13 +95,13 @@
$dummy = $( '' )
.css( {
dir: 'rtl',
-   width: '1px',
+   width: '4px',
height: '1px',
position: 'absolute',
top: '-1000px',
overflow: 'scroll'
} )
-   .text( 'A' )
+   .text( 'ABCD' )
.appendTo( 'body' )[ 0 ];
if ( $dummy.scrollLeft > 0 ) {
return 'default';

-- 
To view, visit https://gerrit.wikimedia.org/r/370427
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d53e467b79d586efc079a15ebc0a52382352f9e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: Update scroll type detection

2017-08-06 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370427 )

Change subject: Update scroll type detection
..

Update scroll type detection

Port of a fix in the original source:
https://github.com/othree/jquery.rtl-scroll-type/commit/1c6d6845032c3cd91b2b387634642471d711380d

Change-Id: I2d53e467b79d586efc079a15ebc0a52382352f9e
---
M modules/ext.RevisionSlider.util.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/27/370427/1

diff --git a/modules/ext.RevisionSlider.util.js 
b/modules/ext.RevisionSlider.util.js
index 6d9450d..66e51d6 100644
--- a/modules/ext.RevisionSlider.util.js
+++ b/modules/ext.RevisionSlider.util.js
@@ -95,13 +95,13 @@
$dummy = $( '' )
.css( {
dir: 'rtl',
-   width: '1px',
+   width: '4px',
height: '1px',
position: 'absolute',
top: '-1000px',
overflow: 'scroll'
} )
-   .text( 'A' )
+   .text( 'ABCD' )
.appendTo( 'body' )[ 0 ];
if ( $dummy.scrollLeft > 0 ) {
return 'default';

-- 
To view, visit https://gerrit.wikimedia.org/r/370427
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d53e467b79d586efc079a15ebc0a52382352f9e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits