[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Fix videojs mode control bar in RTL

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Fix videojs mode control bar in RTL
..


Fix videojs mode control bar in RTL

Apply a global 'noflip' to video.js's CSS which is already using
correct values for RTL (which is to say, make most of it look LTR
as actually correct for media controls!)

Bug: T148565
Change-Id: Ide171ef03a2628865932093eb54384c14195446c
Depends-On: Icbad20d8a6e9a0d354ad159f5816f4fb67cc2775
---
M TimedMediaHandler.hooks.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Brion VIBBER: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index a6699a7..5123520 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -82,6 +82,7 @@
'ext.tmh.video-js' => $baseExtensionResource + [
'scripts' => 
'resources/videojs/video.js',
'styles' => 
'resources/videojs/video-js.css',
+   'noflip' => true,
'targets' => [ 'mobile', 'desktop' ],
'languageScripts' => [
'ar' => 
'resources/videojs/lang/ar.js',

-- 
To view, visit https://gerrit.wikimedia.org/r/316612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide171ef03a2628865932093eb54384c14195446c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 
Gerrit-Reviewer: Brion VIBBER 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: TheDJ 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Fix videojs mode control bar in RTL

[Brion VIBBER (Code Review)]

Brion VIBBER has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/316612

Change subject: Fix videojs mode control bar in RTL
..

Fix videojs mode control bar in RTL

Apply a global 'noflip' to video.js's CSS which is already using
correct values for RTL (which is to say, make most of it look LTR
as actually correct for media controls!)

Bug: T148565
Change-Id: Ide171ef03a2628865932093eb54384c14195446c
Depends-On: Icbad20d8a6e9a0d354ad159f5816f4fb67cc2775
---
M TimedMediaHandler.hooks.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/12/316612/1

diff --git a/TimedMediaHandler.hooks.php b/TimedMediaHandler.hooks.php
index a6699a7..5123520 100644
--- a/TimedMediaHandler.hooks.php
+++ b/TimedMediaHandler.hooks.php
@@ -82,6 +82,7 @@
'ext.tmh.video-js' => $baseExtensionResource + [
'scripts' => 
'resources/videojs/video.js',
'styles' => 
'resources/videojs/video-js.css',
+   'noflip' => true,
'targets' => [ 'mobile', 'desktop' ],
'languageScripts' => [
'ar' => 
'resources/videojs/lang/ar.js',

-- 
To view, visit https://gerrit.wikimedia.org/r/316612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide171ef03a2628865932093eb54384c14195446c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits