[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Remove $purpose parameter from password validity check

2016-12-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove $purpose parameter from password validity check
..


Remove $purpose parameter from password validity check

This was added in I56b6600 in an attempt to work around a bug in
CentralAuth, but the bug has since been fixed in a better way. No hook
functions in Gerrit use the parameter, and anything that was passing a
value other than the default 'login' has since been removed. So let's
just get rid of it instead of keeping it around doing nothing.

Change-Id: If7573198586804ade19e1e537f48e2834da99caf
---
M api/ApiTranslateSandbox.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aaron Schulz: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/api/ApiTranslateSandbox.php b/api/ApiTranslateSandbox.php
index 41889ea..0e6951a 100644
--- a/api/ApiTranslateSandbox.php
+++ b/api/ApiTranslateSandbox.php
@@ -72,7 +72,7 @@
}
 
$password = $params['password'];
-   $status = $user->checkPasswordValidity( $password, 'login' );
+   $status = $user->checkPasswordValidity( $password );
if ( !$status->isGood() ) {
$this->dieStatus( $status );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/324835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7573198586804ade19e1e537f48e2834da99caf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Anomie 
Gerrit-Reviewer: Aaron Schulz 
Gerrit-Reviewer: CSteipp 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Remove $purpose parameter from password validity check

2016-12-01 Thread Anomie (Code Review) 
Anomie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324835

Change subject: Remove $purpose parameter from password validity check
..

Remove $purpose parameter from password validity check

This was added in I56b6600 in an attempt to work around a bug in
CentralAuth, but the bug has since been fixed in a better way. No hook
functions in Gerrit use the parameter, and anything that was passing a
value other than the default 'login' has since been removed. So let's
just get rid of it instead of keeping it around doing nothing.

Change-Id: If7573198586804ade19e1e537f48e2834da99caf
---
M api/ApiTranslateSandbox.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/35/324835/1

diff --git a/api/ApiTranslateSandbox.php b/api/ApiTranslateSandbox.php
index 41889ea..0e6951a 100644
--- a/api/ApiTranslateSandbox.php
+++ b/api/ApiTranslateSandbox.php
@@ -72,7 +72,7 @@
}
 
$password = $params['password'];
-   $status = $user->checkPasswordValidity( $password, 'login' );
+   $status = $user->checkPasswordValidity( $password );
if ( !$status->isGood() ) {
$this->dieStatus( $status );
}

-- 
To view, visit https://gerrit.wikimedia.org/r/324835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If7573198586804ade19e1e537f48e2834da99caf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Anomie 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits