[MediaWiki-commits] [Gerrit] mediawiki...UIFeedback[master]: Use lastDoneWrites() instead of doneWrites()

2016-10-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Use lastDoneWrites() instead of doneWrites()
..


Use lastDoneWrites() instead of doneWrites()

The latter may be deprecated at some point.

Change-Id: If3ce76416093deebfe2365c18123d53416751c23
---
M ApiUiFeedback.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ApiUiFeedback.php b/ApiUiFeedback.php
index e257812..2c9b06d 100644
--- a/ApiUiFeedback.php
+++ b/ApiUiFeedback.php
@@ -140,7 +140,7 @@
 
$dbw->endAtomic( __METHOD__ );
 
-   if( $dbw->doneWrites() ) {
+   if( $dbw->lastDoneWrites() ) {
$this->getResult()->addValue( null, 
$this->getModuleName(), array( 'status' => 'ok', 'params' => $params ) );
} else {
$this->dieUsage( 'Write to DB was not 
successful', 'error' );

-- 
To view, visit https://gerrit.wikimedia.org/r/315917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If3ce76416093deebfe2365c18123d53416751c23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UIFeedback
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UIFeedback[master]: Use lastDoneWrites() instead of doneWrites()

2016-10-14 Thread Aaron Schulz (Code Review) 
Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315917

Change subject: Use lastDoneWrites() instead of doneWrites()
..

Use lastDoneWrites() instead of doneWrites()

The latter may be deprecated at some point.

Change-Id: If3ce76416093deebfe2365c18123d53416751c23
---
M ApiUiFeedback.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UIFeedback 
refs/changes/17/315917/1

diff --git a/ApiUiFeedback.php b/ApiUiFeedback.php
index e257812..2c9b06d 100644
--- a/ApiUiFeedback.php
+++ b/ApiUiFeedback.php
@@ -140,7 +140,7 @@
 
$dbw->endAtomic( __METHOD__ );
 
-   if( $dbw->doneWrites() ) {
+   if( $dbw->lastDoneWrites() ) {
$this->getResult()->addValue( null, 
$this->getModuleName(), array( 'status' => 'ok', 'params' => $params ) );
} else {
$this->dieUsage( 'Write to DB was not 
successful', 'error' );

-- 
To view, visit https://gerrit.wikimedia.org/r/315917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If3ce76416093deebfe2365c18123d53416751c23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UIFeedback
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits