Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311217
Change subject: DesktopArticleTarget: Invalidate, rather than recompute, the
toolbar's narrowThreshold
......................................................................
DesktopArticleTarget: Invalidate, rather than recompute, the toolbar's
narrowThreshold
narrowThreshold is now being lazily computed by OO.ui.Toolbar, so we can
just clear the cached value (if any) rather than recalculating it on
the spot (which causes a slow forced reflow).
Change-Id: I89f357f95fdd9047087f004fde96186ce1ea99b7
Depends-On: I18077599ccd9012e6d3c834b6635687bf087639c
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/17/311217/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 96a6189..26f85b1 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -1095,7 +1095,7 @@
this.toolbar.$actions.append( this.toolbarSaveButton.$element );
// Make the toolbar recalculate its sizes for narrow/wide switching.
// This really should not be necessary.
- this.toolbar.narrowThreshold = this.toolbar.$group.width() +
this.toolbar.$actions.width();
+ this.toolbar.narrowThreshold = null;
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/311217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89f357f95fdd9047087f004fde96186ce1ea99b7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
