[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove unused ContentHandlerDefaultModelFor hook

2016-09-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove unused ContentHandlerDefaultModelFor hook
..


Remove unused ContentHandlerDefaultModelFor hook

This was supposed to be removed in 7f02824ec4b0 except it got missed
somehow...

There was nothing registering it in extension.json, so it was entirely
unused.

Change-Id: I991c464ef0b60543a0ecd4cb1f9dda62e9d73dd4
---
M VisualEditor.hooks.php
1 file changed, 0 insertions(+), 20 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 4a2cc62..c52b934 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -196,26 +196,6 @@
}
 
/**
-* Convert the content model of a message that is actually JSON to JSON.
-* This only affects validation and UI when saving and editing, not
-* loading the content.
-*
-* @param Title $title
-* @param string $model
-* @return bool
-*/
-   public static function onContentHandlerDefaultModelFor( Title $title, 
&$model ) {
-   if (
-   $title->inNamespace( NS_MEDIAWIKI ) &&
-   $title->getText() === 
'Visualeditor-quick-access-characters.json'
-   ) {
-   $model = CONTENT_MODEL_JSON;
-   }
-
-   return true;
-   }
-
-   /**
 * Changes the Edit tab and adds the VisualEditor tab.
 *
 * This is attached to the MediaWiki 'SkinTemplateNavigation' hook.

-- 
To view, visit https://gerrit.wikimedia.org/r/311076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I991c464ef0b60543a0ecd4cb1f9dda62e9d73dd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove unused ContentHandlerDefaultModelFor hook

2016-09-15 Thread Legoktm (Code Review) 
Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311076

Change subject: Remove unused ContentHandlerDefaultModelFor hook
..

Remove unused ContentHandlerDefaultModelFor hook

This was supposed to be removed in 7f02824ec4b0 except it got missed
somehow...

There was nothing registering it in extension.json, so it was entirely
unused.

Change-Id: I991c464ef0b60543a0ecd4cb1f9dda62e9d73dd4
---
M VisualEditor.hooks.php
1 file changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/76/311076/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 4a2cc62..c52b934 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -196,26 +196,6 @@
}
 
/**
-* Convert the content model of a message that is actually JSON to JSON.
-* This only affects validation and UI when saving and editing, not
-* loading the content.
-*
-* @param Title $title
-* @param string $model
-* @return bool
-*/
-   public static function onContentHandlerDefaultModelFor( Title $title, 
&$model ) {
-   if (
-   $title->inNamespace( NS_MEDIAWIKI ) &&
-   $title->getText() === 
'Visualeditor-quick-access-characters.json'
-   ) {
-   $model = CONTENT_MODEL_JSON;
-   }
-
-   return true;
-   }
-
-   /**
 * Changes the Edit tab and adds the VisualEditor tab.
 *
 * This is attached to the MediaWiki 'SkinTemplateNavigation' hook.

-- 
To view, visit https://gerrit.wikimedia.org/r/311076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I991c464ef0b60543a0ecd4cb1f9dda62e9d73dd4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits