[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: VisualDiff: Store diffmode in query string on diff pages

2017-08-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371057 )

Change subject: VisualDiff: Store diffmode in query string on diff pages
..


VisualDiff: Store diffmode in query string on diff pages

Change-Id: I092ac68dd31b29b4418e7afb37bfe94befa16558
---
M modules/ve-mw/init/ve.init.mw.DiffPage.init.js
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/init/ve.init.mw.DiffPage.init.js 
b/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
index 8fd8322..18c7f07 100644
--- a/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
+++ b/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
@@ -10,7 +10,7 @@
reviewModeButtonSelect,
revCache = {},
uri = new mw.Uri(),
-   mode = 'source',
+   mode = uri.query.diffmode || 'source',
conf = mw.config.get( 'wgVisualEditorConfig' ),
pluginModules = conf.pluginModules.filter( mw.loader.getState );
 
@@ -83,6 +83,12 @@
$wikitextDiff.removeClass( 'oo-ui-element-hidden' );
$revSlider.removeClass( 
've-init-mw-diffPage-revSlider-visual' );
}
+
+   if ( history.replaceState ) {
+   uri.query.diffmode = mode;
+   history.replaceState( '', document.title, uri );
+   }
+
}
 
mw.hook( 'wikipage.diff' ).add( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/371057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I092ac68dd31b29b4418e7afb37bfe94befa16558
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Tchanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: VisualDiff: Store diffmode in query string on diff pages

2017-08-10 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371057 )

Change subject: VisualDiff: Store diffmode in query string on diff pages
..

VisualDiff: Store diffmode in query string on diff pages

Change-Id: I092ac68dd31b29b4418e7afb37bfe94befa16558
---
M modules/ve-mw/init/ve.init.mw.DiffPage.init.js
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/57/371057/1

diff --git a/modules/ve-mw/init/ve.init.mw.DiffPage.init.js 
b/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
index 8fd8322..18c7f07 100644
--- a/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
+++ b/modules/ve-mw/init/ve.init.mw.DiffPage.init.js
@@ -10,7 +10,7 @@
reviewModeButtonSelect,
revCache = {},
uri = new mw.Uri(),
-   mode = 'source',
+   mode = uri.query.diffmode || 'source',
conf = mw.config.get( 'wgVisualEditorConfig' ),
pluginModules = conf.pluginModules.filter( mw.loader.getState );
 
@@ -83,6 +83,12 @@
$wikitextDiff.removeClass( 'oo-ui-element-hidden' );
$revSlider.removeClass( 
've-init-mw-diffPage-revSlider-visual' );
}
+
+   if ( history.replaceState ) {
+   uri.query.diffmode = mode;
+   history.replaceState( '', document.title, uri );
+   }
+
}
 
mw.hook( 'wikipage.diff' ).add( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/371057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I092ac68dd31b29b4418e7afb37bfe94befa16558
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits