Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/312102

Change subject: Only register the NWE beta feature if the feature flag is set
......................................................................

Only register the NWE beta feature if the feature flag is set

Change-Id: I2dc168e2ff735d40867d1c064085c0f8e3bab71c
---
M VisualEditor.hooks.php
1 file changed, 19 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/02/312102/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index f9eb001..aeb8e8c 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -588,24 +588,25 @@
                        ]
                ];
 
-               $preferences['visualeditor-newwikitext'] = [
-                       'version' => '1.0',
-                       'label-message' => 
'visualeditor-preference-newwikitexteditor-label',
-                       'desc-message' => 
'visualeditor-preference-newwikitexteditor-description',
-                       'screenshot' => [
-                               'ltr' => 
"$iconpath/betafeatures-icon-WikitextEditor-ltr.svg",
-                               'rtl' => 
"$iconpath/betafeatures-icon-WikitextEditor-rtl.svg",
-                       ],
-                       'info-message' => 
'visualeditor-preference-newwikitexteditor-info-link',
-                       'discussion-message' => 
'visualeditor-preference-newwikitexteditor-discussion-link',
-                       'requirements' => [
-                               'javascript' => true,
-                               'blacklist' => $veConfig->get( 
'VisualEditorBrowserBlacklist' ),
-                               'skins' => $veConfig->get( 
'VisualEditorSupportedSkins' ),
-                       ],
-                       'exempt-from-auto-enrollment' => true
-               ];
-
+               if ( $veConfig->get( 'VisualEditorEnableWikitext' ) ) {
+                       $preferences['visualeditor-newwikitext'] = [
+                               'version' => '1.0',
+                               'label-message' => 
'visualeditor-preference-newwikitexteditor-label',
+                               'desc-message' => 
'visualeditor-preference-newwikitexteditor-description',
+                               'screenshot' => [
+                                       'ltr' => 
"$iconpath/betafeatures-icon-WikitextEditor-ltr.svg",
+                                       'rtl' => 
"$iconpath/betafeatures-icon-WikitextEditor-rtl.svg",
+                               ],
+                               'info-message' => 
'visualeditor-preference-newwikitexteditor-info-link',
+                               'discussion-message' => 
'visualeditor-preference-newwikitexteditor-discussion-link',
+                               'requirements' => [
+                                       'javascript' => true,
+                                       'blacklist' => $veConfig->get( 
'VisualEditorBrowserBlacklist' ),
+                                       'skins' => $veConfig->get( 
'VisualEditorSupportedSkins' ),
+                               ],
+                               'exempt-from-auto-enrollment' => true
+                       ];
+               }
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/312102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dc168e2ff735d40867d1c064085c0f8e3bab71c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to