Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370808 )
Change subject: [WIP] Restore add and remove feature in the sitelink UI
......................................................................
[WIP] Restore add and remove feature in the sitelink UI
The previous patch left the sitelinks UI in a problematic state. It
was not possible to remove a sitelink in specific situations, and not
possible to add a new one in others.
This also removes some unused code.
Bug: T153204
Change-Id: Id95ceabbab6a3da2707bfdbff44937b1c599dbbc
---
M view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
M view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
2 files changed, 4 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/08/370808/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
index f71b12e..17c77b0 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinklistview.js
@@ -152,21 +152,16 @@
}
self._trigger( 'change' );
} )
- .on( listItemAdapter.prefixedEvent( 'toggleerror.' +
this.widgetName ), function ( event, error ) {
- event.stopPropagation();
- } )
- .on( 'keydown.' + this.widgetName, function ( event ) {
- if ( event.keyCode === $.ui.keyCode.BACKSPACE )
{
- var $sitelinkview = $( event.target
).parentsUntil( this ).addBack().filter( '.listview-item' ),
- sitelinkview =
listItemAdapter.liInstance( $sitelinkview );
- }
+ .on( 'removetoolbarremove.' + this.widgetName, function
( event ) {
+ self._updateAutoInput();
} )
.on(
[
listItemAdapter.prefixedEvent(
'create.' + this.widgetName ),
listItemAdapter.prefixedEvent(
'afterstartediting.' + this.widgetName ),
listItemAdapter.prefixedEvent(
'afterstopediting.' + this.widgetName ),
- listItemAdapter.prefixedEvent(
'disable.' + this.widgetName )
+ listItemAdapter.prefixedEvent(
'disable.' + this.widgetName ),
+ listItemAdapter.prefixedEvent(
'toggleerror.' + this.widgetName )
].join( ' ' ),
function ( event ) {
event.stopPropagation();
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
index efad921..36d95dc 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.sitelinkview.js
@@ -158,7 +158,6 @@
// Adding/removing badges decreases/increases
available space:
self.updatePageNameInputAutoExpand();
self._trigger( 'change' );
- self._siteLinkRemover[ self.value() === null ?
'disable' : 'enable' ]();
} );
this._badgeselector = $badgeselector.data(
'badgeselector' );
--
To view, visit https://gerrit.wikimedia.org/r/370808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id95ceabbab6a3da2707bfdbff44937b1c599dbbc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
